From: "Krzysztof Wilczyński" <kw@linux.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] Documentation: Fix config_acs= example
Date: Wed, 15 Jan 2025 20:17:51 +0900 [thread overview]
Message-ID: <20250115111751.GD4176564@rocinante> (raw)
In-Reply-To: <20240915-acs-v1-1-b9ee536ee9bd@daynix.com>
Hello,
> The documentation used to say:
> > For example,
> > pci=config_acs=10x
> > would configure all devices that support ACS to enable P2P Request
> > Redirect, disable Translation Blocking, and leave Source Validation
> > unchanged from whatever power-up or firmware set it to.
>
> However, a flag specification always needs to be suffixed with "@" and a
> PCI device string, which is missing in this example. It needs to be
> suffixed with "@pci:0:0" to configure all devices that support ACS in
> particular.
Applied to config-acs for v6.14, thank you!
Krzysztof
prev parent reply other threads:[~2025-01-15 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 1:36 [PATCH] Documentation: Fix config_acs= example Akihiko Odaki
2025-01-11 5:20 ` Akihiko Odaki
2025-01-13 17:40 ` Bjorn Helgaas
2025-01-14 0:32 ` Krzysztof Wilczyński
2025-01-15 11:17 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115111751.GD4176564@rocinante \
--to=kw@linux.com \
--cc=akihiko.odaki@daynix.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox