* [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
@ 2025-01-21 22:52 Reyders Morales
2025-01-22 0:06 ` Jonathan Corbet
0 siblings, 1 reply; 7+ messages in thread
From: Reyders Morales @ 2025-01-21 22:52 UTC (permalink / raw)
To: linux-doc; +Cc: linux-kernel, valla.francesco, corbet, Reyders Morales
In the current struct sockaddr_can tp is member of can_addr.
tp is not member of struct sockaddr_can.
Signed-off-by: Reyders Morales <reyders1@gmail.com>
---
Documentation/networking/iso15765-2.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
index 0e9d96074178..37ebb2c417cb 100644
--- a/Documentation/networking/iso15765-2.rst
+++ b/Documentation/networking/iso15765-2.rst
@@ -369,8 +369,8 @@ to their default.
addr.can_family = AF_CAN;
addr.can_ifindex = if_nametoindex("can0");
- addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
- addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
+ addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
+ addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
if (ret < 0)
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
2025-01-21 22:52 [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2 Reyders Morales
@ 2025-01-22 0:06 ` Jonathan Corbet
2025-01-22 0:48 ` Jakub Kicinski
0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Corbet @ 2025-01-22 0:06 UTC (permalink / raw)
To: Reyders Morales, linux-doc
Cc: linux-kernel, valla.francesco, Reyders Morales, netdev
[CC += netdev - they may want a resend after the merge window though]
Reyders Morales <reyders1@gmail.com> writes:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
> ---
> Documentation/networking/iso15765-2.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>
> addr.can_family = AF_CAN;
> addr.can_ifindex = if_nametoindex("can0");
> - addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> - addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> + addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> + addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>
> ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
> if (ret < 0)
> --
> 2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
2025-01-22 0:06 ` Jonathan Corbet
@ 2025-01-22 0:48 ` Jakub Kicinski
0 siblings, 0 replies; 7+ messages in thread
From: Jakub Kicinski @ 2025-01-22 0:48 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Reyders Morales, linux-doc, linux-kernel, valla.francesco, netdev
On Tue, 21 Jan 2025 17:06:08 -0700 Jonathan Corbet wrote:
> [CC += netdev - they may want a resend after the merge window though]
Thanks! Yes, please resend after the merge window, and also include
linux-can@vger.kernel.org at that time (ideally just run the patch
thru scripts/get_maintainer.pl to get the full CC list).
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
@ 2025-02-03 22:47 Reyders Morales
2025-02-04 7:40 ` Oliver Hartkopp
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Reyders Morales @ 2025-02-03 22:47 UTC (permalink / raw)
To: kuba
Cc: Reyders Morales, Oliver Hartkopp, Marc Kleine-Budde,
David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
Jonathan Corbet, linux-can, netdev, linux-doc, linux-kernel
In the current struct sockaddr_can tp is member of can_addr.
tp is not member of struct sockaddr_can.
Signed-off-by: Reyders Morales <reyders1@gmail.com>
---
Documentation/networking/iso15765-2.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
index 0e9d96074178..37ebb2c417cb 100644
--- a/Documentation/networking/iso15765-2.rst
+++ b/Documentation/networking/iso15765-2.rst
@@ -369,8 +369,8 @@ to their default.
addr.can_family = AF_CAN;
addr.can_ifindex = if_nametoindex("can0");
- addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
- addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
+ addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
+ addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
if (ret < 0)
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
2025-02-03 22:47 Reyders Morales
@ 2025-02-04 7:40 ` Oliver Hartkopp
2025-02-04 13:45 ` Simon Horman
2025-02-06 8:02 ` Marc Kleine-Budde
2 siblings, 0 replies; 7+ messages in thread
From: Oliver Hartkopp @ 2025-02-04 7:40 UTC (permalink / raw)
To: Reyders Morales, kuba
Cc: Marc Kleine-Budde, David S. Miller, Eric Dumazet, Paolo Abeni,
Simon Horman, Jonathan Corbet, linux-can, netdev, linux-doc,
linux-kernel
On 03.02.25 23:47, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks!
> ---
> Documentation/networking/iso15765-2.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>
> addr.can_family = AF_CAN;
> addr.can_ifindex = if_nametoindex("can0");
> - addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> - addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> + addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> + addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>
> ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
> if (ret < 0)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
2025-02-03 22:47 Reyders Morales
2025-02-04 7:40 ` Oliver Hartkopp
@ 2025-02-04 13:45 ` Simon Horman
2025-02-06 8:02 ` Marc Kleine-Budde
2 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2025-02-04 13:45 UTC (permalink / raw)
To: Reyders Morales
Cc: kuba, Oliver Hartkopp, Marc Kleine-Budde, David S. Miller,
Eric Dumazet, Paolo Abeni, Jonathan Corbet, linux-can, netdev,
linux-doc, linux-kernel
On Mon, Feb 03, 2025 at 11:47:20PM +0100, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
2025-02-03 22:47 Reyders Morales
2025-02-04 7:40 ` Oliver Hartkopp
2025-02-04 13:45 ` Simon Horman
@ 2025-02-06 8:02 ` Marc Kleine-Budde
2 siblings, 0 replies; 7+ messages in thread
From: Marc Kleine-Budde @ 2025-02-06 8:02 UTC (permalink / raw)
To: Reyders Morales
Cc: kuba, Oliver Hartkopp, David S. Miller, Eric Dumazet, Paolo Abeni,
Simon Horman, Jonathan Corbet, linux-can, netdev, linux-doc,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On 03.02.2025 23:47:20, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
Applied to linux-can.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-02-06 8:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-21 22:52 [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2 Reyders Morales
2025-01-22 0:06 ` Jonathan Corbet
2025-01-22 0:48 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2025-02-03 22:47 Reyders Morales
2025-02-04 7:40 ` Oliver Hartkopp
2025-02-04 13:45 ` Simon Horman
2025-02-06 8:02 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).