From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2084.outbound.protection.outlook.com [40.107.236.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 734C0320B; Thu, 23 Jan 2025 13:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.84 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737639827; cv=fail; b=CGPzuajMngxp/eOzDqb9oyVw6jczG6YE7mZUji+FzkM1LgsnR6f+XokYh1ZLW5YtkMIwM5G2ai3qaqzK4ZT7dgt/00HM6nTd8Fk39mZ7ffAG2ALMFQVNam+eoA68ie9VycuxP5F41orSq7YV3HAO/dkTBFcRk1qARvCnnMnvcDI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737639827; c=relaxed/simple; bh=mj8hJKHE+y1HExsdI/CbQ3k1Wf5zm66b5t2WYP4Ehfg=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=BSAyx5d2rsImDAvG1wb0NuIpLcfWZmlezoJThTdG3Qj5ug/dm0il3C37mpUeBK5urzJSJrEvKarrvDvT+hSCkTyoCuRB6CT5EiMr1lIoCZWI36zQ5O5l7f7Z6wkL9W+O+Sp3fJd+sBMDWpSypnEYK5yE5kF2W/Zl98xP2T+a4Eo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IMOZVvY1; arc=fail smtp.client-ip=40.107.236.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IMOZVvY1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=twKhLd5hOzZ42LSs16XQDjdoDqHEfxBb2TxOSdCVARmehlPo8eMwug1LKqStvWP+n0/olAw322+PwG4MASBoNRKUI3n+LPrpCv8HvBmmSd2nEfmYmTxaHQWk1L7WOdpQY943hY7LR3UrCQRyE4tJkG8LHsn6DTNmyKm3ywfV7Irr7at61DWOOLrT7AqwXXRrQUtBkp7/qN9h3XG/6vvVFV+VbPl7ZnfAljsahaaA3wPoH0SXi/zVUzNZgL3Sj19xDPEFn1ZzXh6oTRpoKqttfkrp22NLm7Ve/gvF3hVWO+amnf0iyWrARht4bE4GSxObLZiosVdD94/BEHO+6JzKyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mj8hJKHE+y1HExsdI/CbQ3k1Wf5zm66b5t2WYP4Ehfg=; b=adx3W/jSDT23q4+yFPIcuqdFykA4KLH8mODe3SJ4tg/d5O3XrA2hhZZ7Gw1QNqr164xVnNZ0OCNLEAMqeITO0nNDfFkDxMUuCCHxGtkCvxmDPWZb5AY3zeGzYLJEQS2553vV/3Ea5e8buBAoXOSNJRarPchEH7PsG2jDb/dAuMHornA78dtFK0w2MmtseFxyBBLMYzNKneb8BSOL+x2/PqojiZQUPlALJQCp7CmZy12LNK5KMqnB79kmZwCf3Cgdgx1Pd1+4/kp0WROwU+/kzCgQ7XeNOruVvW3rXPtpylsV+fqHqE0w9aN1mXLy17e2i1DXQHXju3U7wHoDxgP24Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mj8hJKHE+y1HExsdI/CbQ3k1Wf5zm66b5t2WYP4Ehfg=; b=IMOZVvY1bW0FWtCRQqHjWCqwDku0C4UYH1zUjp4NyIbSNPECvs+MQ7YNtv4aNUVPWUTupnaf6FLIp/BI2jBoulmAbg+pfsMeomug3ZzK26e9/Oz5vLHFc8Uipx/s76ykosgQjLF3sXbW/YjXpnCUGVi3tzccak5Eoqu+42fRZ2+g3NOKMdekrFQOouOBpVqkoR/7qimaamQWKsExKuHyBh926CbJajpCtH5+QnHEBg3CoehVPsxO6mzyVEfb/w4x49Wi7kHLutZz4RKSMjJ/fZPJBhXje05nKjEAA1opUykhqtUhdvJVAaOWLmgPX+ZZJrA/PgHVVldbJEMG/JFthA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by SN7PR12MB7252.namprd12.prod.outlook.com (2603:10b6:806:2ac::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.20; Thu, 23 Jan 2025 13:43:44 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%5]) with mapi id 15.20.8356.010; Thu, 23 Jan 2025 13:43:43 +0000 Date: Thu, 23 Jan 2025 09:43:42 -0400 From: Jason Gunthorpe To: Nicolin Chen Cc: kevin.tian@intel.com, corbet@lwn.net, will@kernel.org, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, shuah@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, eric.auger@redhat.com, jean-philippe@linaro.org, mdf@kernel.org, mshavit@google.com, shameerali.kolothum.thodi@huawei.com, smostafa@google.com, ddutile@redhat.com, yi.l.liu@intel.com, patches@lists.linux.dev Subject: Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper Message-ID: <20250123134342.GP5556@nvidia.com> References: <20250121183611.GY5556@nvidia.com> <20250121200924.GZ5556@nvidia.com> <20250121211404.GB5556@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BN9PR03CA0576.namprd03.prod.outlook.com (2603:10b6:408:10d::11) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|SN7PR12MB7252:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c9c7cd5-51ca-46ab-fb46-08dd3bb3f41f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5Aj5ABV1HL8Ha1svOMhKpA6Hjlb+m8ZJZ4Blqpit0rpuTxIdVj8+f8fGIv5m?= =?us-ascii?Q?V8aReQJjaINlYAjuAsMEEVnX2y0F1Uv7z8lIle6RFxd+BbYA1YiviF9AVlUd?= =?us-ascii?Q?Yt79o5DFYbO8VXNxCK8om4SDMRneLyZe2rplR9yzkEu8GMS2fDkTjBe9i7OS?= =?us-ascii?Q?sYh1LnQITvgAHX3ywVo+pxmTxQS1+pqcBS0I6E2qriOiySVRxnJG8RB08K93?= =?us-ascii?Q?qyjg1W927hurgq//j9T128RQXD3gP0HkthY434zucmpAsjYAm0W78MaolDzY?= =?us-ascii?Q?4FLcIsrrfF9tFqcZ4nquTGvyFIZ3TRmnKsyWJVGAb6sluF/cTHDIEbl6zFHm?= =?us-ascii?Q?6yViFgp+bIe+64ei/uHT7QAL+uqvjmqYM4GeshSr+65TIuwmId8eT0b7Rd8p?= =?us-ascii?Q?Yl4F7dSV/iores73WmsOfhGasK0LKELl3xteuJ7jEWHwSIktdZRScNC+/TEC?= =?us-ascii?Q?r3k4rerscHTbXBd5eKGMgdMVQ/rPckKETqUcu+LdDxmsO31XhGf0tDZRi8v9?= =?us-ascii?Q?y+cNm0EXUYMqiMrEYG8xvRTj51vPBkvqBSw53zx9VYzagg1tE+Q/jfZsCKDJ?= =?us-ascii?Q?c+vt7tWxe31twr+okSvkw/9oJuOoeRVx6ELzILfAZ2C1L6y/KHpVh4lEacWp?= =?us-ascii?Q?VRqdBs9ja8jjWe7bQuvsPCCYMcH64ca4M6Mu64w/DsaBF4aSUpjaLMIfRZAP?= =?us-ascii?Q?K7uL2UpTtEOO42dqSopEsZUZ3cvV30xXFD0LvJ/lIkomtII1wrSwQNQvwEi0?= =?us-ascii?Q?RtS4Xz5+nHntb9eP7jpKvSo0nNYt06jp0yc1Ak9dfNr/ImpoN54d+5Lkt5Gu?= =?us-ascii?Q?mR/yiv363ABcUrNiLVzYkEbnhagwpgP5kSHBSRdHIjvy2Ll63d2Mr2ycfwfb?= =?us-ascii?Q?Z2P0e5gIutvijgfzKLQeXtT6sMKFgN8plS6tDyddLtkeMulpFzYw+c4IkcAo?= =?us-ascii?Q?gTG/wy0BTF2SeY/CTO4GxsRUZOZN+2oDQTgWwDTod8dMJ4k09UxxgP2iUYYc?= =?us-ascii?Q?FtGIuICqnUSwC9BNdQo92VI9v8HmL8U0DUWmXXA4QepQkyCV3YCi9PoEUtW6?= =?us-ascii?Q?g9gJPi6CNP8y4MG1BWQcSj26MyERFDPc9fMkXe3cHbIai/R/Owd/sS35kZ8p?= =?us-ascii?Q?M5F98DgLFNkPSQ60EvRI9O1YJy5CJGGze5PUPo0GXrR4WJyfs5/oklypiE1A?= =?us-ascii?Q?HAocfqpWvDBC+vg4Oe7nGhRnQXyQaPCrePwku5OTKnqluNNSiRx75/FW2/eu?= =?us-ascii?Q?GKx5xSBQd9QvfN8BiCqDxa6ZqU9ibyCPXubMdS14PQOdGHcwJyaHc7Lq/hl8?= =?us-ascii?Q?51/SGB1y0dlv2NtihvgD1Ebx3IWvSGOgLw1Shgb21dhkzyfEbshSOuW7ZBB7?= =?us-ascii?Q?Y0uK4zaOV9IJeKERwHox/Oy1+ryU?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BP1g8Bz1sXjzlFdoU6e6KmMJT6mbs5U9+iq7iUc8cURQ9FA+/8nrOnWQBXdu?= =?us-ascii?Q?JiNrWlvudgFcwAg2lGy+GPV4PijosWFy5iVZ8hNtaCvXoe5GqZanvEh2vE/0?= =?us-ascii?Q?/VRkNXiEKSrRyGFJ0CPmAyKLPtTz3Qnyk51KNcuyDwiyYKSCePS4a0bJTyO7?= =?us-ascii?Q?P/LRx+X/tgvXoVpV+/+1z53W4MMk+BzzOITwP0qCpGPwiRNjW4QneoHLLCDI?= =?us-ascii?Q?j9F3azPZoIdbhSfVwrJmtpUaIIJWWrPpJVICjVlC6UgXb4TWJjGS5E7B6d3N?= =?us-ascii?Q?3RVN7jt4vY6xIBMuXCegXM10wt4pND5dUYR6IdXiDZjaw/+jTu+JiXQwQBWT?= =?us-ascii?Q?y+6Sa94kag2+sZ6pu6jcJCQDhD7ufaEUIM5E6pNUlCxSn3JS17LR79qKEnjT?= =?us-ascii?Q?VjiC+aFLHcAmafqR3fdkqF7CnIGwNoFuaVhHyflPhT/NsL62iwC6ckdu+rQR?= =?us-ascii?Q?TYyPGNUGIfLebGFHBeD+/jukNMxRZhVa1LflVOtRn1O8gAkYPN3cUxCVxVMB?= =?us-ascii?Q?vB4g5q3y1D9nhnsjou4kqkGou/lnR2Csuq5QcqMRaVfF1etVKr0mpDwMT/hj?= =?us-ascii?Q?vjrFMMjeEOE8eOMyfBYNSuStD6ZRjRu11qnV7ZI609mPV7CZ8rhEQvjrEaSi?= =?us-ascii?Q?MQu1e3qFsh/TOdxo+5KN/07672FkQ8XqM6ZR4ZcyZiSSb0E1x34s9vh3BzBE?= =?us-ascii?Q?9d8ZeW3K5Xnm261CasWWliA3WJaIVgv4FIElNoutjYyYwX3DtTQjuQyHn2Fb?= =?us-ascii?Q?eYASkK45E8/zxaeL4a6F8e73KPzT9wlWwU2YD70vWQ0rSKMlLMN5UfCUL9E2?= =?us-ascii?Q?QlryiyM4IiePyu5MIiNQLextTzuZNKCgbpPkACt3QKi7eS3xtSRdfcLc+Rak?= =?us-ascii?Q?62UzeES43ONRIxzfkKDhZnBvjqcsxe0XAmSDAHmZ0R9s/03FBBSmALEQX9qg?= =?us-ascii?Q?2tbw1qJIX94GVum+HP9VnlNBp9V7o60Uj+7VPj1Vg8zbhuz4HvVbqQQlAhu/?= =?us-ascii?Q?d4nG/Nb5IYH4J5yeSqcVKBqjugsZn6OvfQ56adY9d3gvtB8WAtfzWcPmpShz?= =?us-ascii?Q?bPAwsFYVowHBYKv8iX82yQA+weI5iyFP8ZHOvec7hcTjHgoDoBC07q3g27yg?= =?us-ascii?Q?Be6MSQSZf6rpqlJRGL5OwfLEu3DleZgWo+lqjTnhodMnX9eajzdfh8MFOFqh?= =?us-ascii?Q?27YrNLq7GtKJXdLPTKoz+FX9eY5iWsGVzCvEMNO6bwLV1noWl1/AWsxMQp2K?= =?us-ascii?Q?eWfACV8LxS9kpS3uQ/XJiwikAWvZQpTIhvCFtDtXt7Q3S6TN0iayHfz6prN2?= =?us-ascii?Q?iwURDRc+Zqvz3sxjvZpaNbbazt/TWJjczPo7QtnlCAX4giEnt2byg/jCMpYn?= =?us-ascii?Q?pIZwcFcxjQmGsb8pI13hG76t0tmZGLewDlptm5jPOrBuqmubw3hW9CAUfiQF?= =?us-ascii?Q?HMo9lztFtYTPBOX+XA5hVwdErnnRmDAFXO4XM1Byn20P/+IWABq90igIyCX8?= =?us-ascii?Q?LbHzaxUswln8eZZHJP1Ri35p+9FZifwGPPYraRwM8H2y5RCgNpqetQKnYZzm?= =?us-ascii?Q?D5Osz8nxDoiEy3sKP50=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c9c7cd5-51ca-46ab-fb46-08dd3bb3f41f X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 13:43:43.8704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DaSxrAtxTVCeVk6xs/9EMcFOC84Tu69h/dKpZ58rNVpAaJeGNlCDubXxeGsjDTEr X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7252 On Wed, Jan 22, 2025 at 11:02:59PM -0800, Nicolin Chen wrote: > I made a change to duplicate the overflow node in the fetch() that > is protected by the spinlock, which is used for copy_to_user. Then > the other routine for vEVENT reporting, protected by the spinlock, > can race-freely update the preallocated overflow node. That seems like the right answer, copy the few bytes you need on the stack under the spinlock. Jason