From: Lee Jones <lee@kernel.org>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
thomas.petazzoni@bootlin.com, blake.vermeer@keysight.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 2/2] mfd: cgbc: add a hwmon cell
Date: Tue, 11 Feb 2025 13:39:55 +0000 [thread overview]
Message-ID: <20250211133955.GR1868108@google.com> (raw)
In-Reply-To: <20250203-congatec-board-controller-hwmon-v4-2-ff6c76a4662c@bootlin.com>
If you resubmit this set, please capitalise the first char in the
subject line after the driver identifiers.
> The Board Controller has some internal sensors.
> Add a hwmon cell for the cgbc-hwmon driver which adds support for
> temperature, voltage, current and fan sensors.
Generally fine.
Line-breaking just for a new sentence is an odd choice though.
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
> drivers/mfd/cgbc-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
> index 85283c8dde25..0460e4e3f3c5 100644
> --- a/drivers/mfd/cgbc-core.c
> +++ b/drivers/mfd/cgbc-core.c
> @@ -236,6 +236,7 @@ static struct mfd_cell cgbc_devs[] = {
> { .name = "cgbc-gpio" },
> { .name = "cgbc-i2c", .id = 1 },
> { .name = "cgbc-i2c", .id = 2 },
> + { .name = "cgbc-hwmon" },
> };
>
> static int cgbc_map(struct cgbc_device_data *cgbc)
>
> --
> 2.39.5
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-02-11 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 11:01 [PATCH v4 0/2] Enable sensors support for the Congatec Board Controller Thomas Richard
2025-02-03 11:01 ` [PATCH v4 1/2] hwmon: Add Congatec Board Controller monitoring driver Thomas Richard
2025-03-17 18:16 ` Guenter Roeck
2025-02-03 11:01 ` [PATCH v4 2/2] mfd: cgbc: add a hwmon cell Thomas Richard
2025-02-11 13:39 ` Lee Jones [this message]
2025-03-21 11:27 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211133955.GR1868108@google.com \
--to=lee@kernel.org \
--cc=blake.vermeer@keysight.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).