From: Anusha Srivatsa <asrivats@redhat.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Joel Selvaraj <jo@jsfamily.in>,
Ondrej Jirman <megi@xff.cz>,
Javier Martinez Canillas <javierm@redhat.com>,
Jianhua Lu <lujianhua000@gmail.com>,
Robert Chiras <robert.chiras@nxp.com>,
Artur Weber <aweber.kernel@gmail.com>,
Jonathan Corbet <corbet@lwn.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Anusha Srivatsa <asrivats@redhat.com>
Subject: [PATCH 04/20] drm/panel/boe-bf060y8m-aj0: Move to using mipi_dsi_*_multi() variants
Date: Thu, 13 Feb 2025 15:44:21 -0500 [thread overview]
Message-ID: <20250213-mipi_cocci_multi-v1-4-67d94ff319cc@redhat.com> (raw)
In-Reply-To: <20250213-mipi_cocci_multi-v1-0-67d94ff319cc@redhat.com>
Stop using deprecated API.
Used Coccinelle to make the change.
@rule_3@
identifier dsi_var;
identifier r;
identifier func;
type t;
position p;
expression dsi_device;
expression list es;
@@
t func(...) {
...
struct mipi_dsi_device *dsi_var = dsi_device;
+struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi_var };
<+...
(
-mipi_dsi_dcs_write_seq(dsi_var,es);
+mipi_dsi_dcs_write_seq_multi(&dsi_ctx,es);
|
-r = mipi_dsi_dcs_exit_sleep_mode(dsi_var)@p;
+mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
|
-r = mipi_dsi_dcs_enter_sleep_mode(dsi_var)@p;
+mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
|
-r = mipi_dsi_dcs_set_display_off(dsi_var)@p;
+mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
|
.....//rest of the mipi APIs with _multi variant
)
<+...
-if(r < 0) {
-...
-}
...+>
}
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
---
drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 75 +++++++++++---------------
1 file changed, 30 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
index 7e66db4a88bbed27920107458d01efd9cf4986df..8903a6c889794330fa1f54a30e779c7d5fbc4b14 100644
--- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
+++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c
@@ -55,42 +55,34 @@ static void boe_bf060y8m_aj0_reset(struct boe_bf060y8m_aj0 *boe)
static int boe_bf060y8m_aj0_on(struct boe_bf060y8m_aj0 *boe)
{
struct mipi_dsi_device *dsi = boe->dsi;
- struct device *dev = &dsi->dev;
- int ret;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
- mipi_dsi_dcs_write_seq(dsi, 0xb0, 0xa5, 0x00);
- mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x00, 0x4c);
- mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_3D_CONTROL, 0x10);
- mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, DCS_ALLOW_HBM_RANGE);
- mipi_dsi_dcs_write_seq(dsi, 0xf8,
- 0x00, 0x08, 0x10, 0x00, 0x22, 0x00, 0x00, 0x2d);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb0, 0xa5, 0x00);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x00, 0x4c);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_SET_3D_CONTROL, 0x10);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE,
+ DCS_ALLOW_HBM_RANGE);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf8, 0x00, 0x08, 0x10, 0x00,
+ 0x22, 0x00, 0x00, 0x2d);
- ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
- if (ret < 0) {
- dev_err(dev, "Failed to exit sleep mode: %d\n", ret);
- return ret;
- }
+ mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
msleep(30);
- mipi_dsi_dcs_write_seq(dsi, 0xb0, 0xa5, 0x00);
- mipi_dsi_dcs_write_seq(dsi, 0xc0,
- 0x08, 0x48, 0x65, 0x33, 0x33, 0x33,
- 0x2a, 0x31, 0x39, 0x20, 0x09);
- mipi_dsi_dcs_write_seq(dsi, 0xc1, 0x00, 0x00, 0x00, 0x1f, 0x1f,
- 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f,
- 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);
- mipi_dsi_dcs_write_seq(dsi, 0xe2, 0x20, 0x04, 0x10, 0x12, 0x92,
- 0x4f, 0x8f, 0x44, 0x84, 0x83, 0x83, 0x83,
- 0x5c, 0x5c, 0x5c);
- mipi_dsi_dcs_write_seq(dsi, 0xde, 0x01, 0x2c, 0x00, 0x77, 0x3e);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb0, 0xa5, 0x00);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0x08, 0x48, 0x65, 0x33,
+ 0x33, 0x33, 0x2a, 0x31, 0x39, 0x20, 0x09);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x00, 0x00, 0x00, 0x1f,
+ 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f,
+ 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe2, 0x20, 0x04, 0x10, 0x12,
+ 0x92, 0x4f, 0x8f, 0x44, 0x84, 0x83, 0x83,
+ 0x83, 0x5c, 0x5c, 0x5c);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xde, 0x01, 0x2c, 0x00, 0x77,
+ 0x3e);
msleep(30);
- ret = mipi_dsi_dcs_set_display_on(dsi);
- if (ret < 0) {
- dev_err(dev, "Failed to set display on: %d\n", ret);
- return ret;
- }
+ mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
msleep(50);
return 0;
@@ -99,24 +91,18 @@ static int boe_bf060y8m_aj0_on(struct boe_bf060y8m_aj0 *boe)
static int boe_bf060y8m_aj0_off(struct boe_bf060y8m_aj0 *boe)
{
struct mipi_dsi_device *dsi = boe->dsi;
- struct device *dev = &dsi->dev;
- int ret;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
/* OFF commands sent in HS mode */
dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
- ret = mipi_dsi_dcs_set_display_off(dsi);
- if (ret < 0) {
- dev_err(dev, "Failed to set display off: %d\n", ret);
- return ret;
- }
+ mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
+
msleep(20);
- ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
- if (ret < 0) {
- dev_err(dev, "Failed to enter sleep mode: %d\n", ret);
- return ret;
- }
+ mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
+
usleep_range(1000, 2000);
+
dsi->mode_flags |= MIPI_DSI_MODE_LPM;
return 0;
@@ -233,12 +219,10 @@ static const struct drm_panel_funcs boe_bf060y8m_aj0_panel_funcs = {
static int boe_bf060y8m_aj0_bl_update_status(struct backlight_device *bl)
{
struct mipi_dsi_device *dsi = bl_get_data(bl);
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
u16 brightness = backlight_get_brightness(bl);
- int ret;
- ret = mipi_dsi_dcs_set_display_brightness(dsi, brightness);
- if (ret < 0)
- return ret;
+ mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx, brightness);
return 0;
}
@@ -246,6 +230,7 @@ static int boe_bf060y8m_aj0_bl_update_status(struct backlight_device *bl)
static int boe_bf060y8m_aj0_bl_get_brightness(struct backlight_device *bl)
{
struct mipi_dsi_device *dsi = bl_get_data(bl);
+
u16 brightness;
int ret;
--
2.47.0
next prev parent reply other threads:[~2025-02-13 20:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 20:44 [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 01/20] drm/panel/xpp055c272: Move to using mipi_dsi_*_multi() variants Anusha Srivatsa
2025-02-13 21:06 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 02/20] drm/panel/visionox-r66451: " Anusha Srivatsa
2025-02-13 21:07 ` Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 03/20] drm/panel/asus-tm5p5-n35596: " Anusha Srivatsa
2025-02-13 21:08 ` Dmitry Baryshkov
2025-02-13 20:44 ` Anusha Srivatsa [this message]
2025-02-13 21:27 ` [PATCH 04/20] drm/panel/boe-bf060y8m-aj0: " Dmitry Baryshkov
2025-02-13 20:44 ` [PATCH 05/20] drm/panel/dsi-cm: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 06/20] drm/panel/sony-nt35521: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 07/20] drm/panel/ebbg-ft8719: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 08/20] drm/panel/himax-hx8394: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 09/20] drm/panel/jdi-lpm102a188a: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 10/20] drm/panel/jdi-lt070me05000: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 11/20] drm/panel/novatek-nt36523: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 12/20] drm/panel/raydium-rm67191: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 13/20] drm/panel/samsung-s6d7aa0:Move " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 14/20] drm/panel/s6e88a0-ams452ef01: Move " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 15/20] drm/panel/samsung-sofef00: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 16/20] drm/panel/ls043t1le01: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 17/20] drm/panel/ls060t1sx01: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 18/20] drm/panel/sony-td4353-jdi: " Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 19/20] drm/panel: Remove deprecated functions Anusha Srivatsa
2025-02-13 20:44 ` [PATCH 20/20] Documentation: Update the documentation Anusha Srivatsa
2025-02-14 16:26 ` [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available Doug Anderson
2025-02-18 9:55 ` Maxime Ripard
2025-02-18 12:14 ` Dmitry Baryshkov
2025-02-18 15:52 ` Maxime Ripard
2025-02-19 9:11 ` Dmitry Baryshkov
2025-02-19 13:35 ` Maxime Ripard
2025-02-24 18:40 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213-mipi_cocci_multi-v1-4-67d94ff319cc@redhat.com \
--to=asrivats@redhat.com \
--cc=airlied@gmail.com \
--cc=aweber.kernel@gmail.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jo@jsfamily.in \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=megi@xff.cz \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robert.chiras@nxp.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox