From: Lee Jones <lee@kernel.org>
To: Manuel Fombuena <fombuena@outlook.com>
Cc: pavel@ucw.cz, corbet@lwn.net, linux-leds@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 0/5] LED1202 / leds-st1202 fixes and improvements
Date: Thu, 13 Feb 2025 10:41:19 +0000 [thread overview]
Message-ID: <20250213104119.GD2756671@google.com> (raw)
In-Reply-To: <CWLP123MB5473933B9B97137828ACC6A6C5EB2@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM>
On Sat, 01 Feb 2025, Manuel Fombuena wrote:
> Collection of patches for the recently added leds-st1202 driver. It is the
> same patchset sent on 2025-01-17. The cover letter wasn't properly threaded
> with the patches that time, so apologies for that.
>
> Obvious from the individual descriptions, but as a summary:
>
> - 0001: fix a NULL pointer access error that occurs when LEDs are
> registered but the LED driver is not fully initialized
> - 0002: initialize the LED driver before any DT LED initialization is done
> - 0003: some spacing and typo edits
> - 0004: include the appropriate select in Kconfig to make sure the
> required Pattern trigger driver is available.
> - 0005: remove .rst extension on Documentation/leds/index.rst
Stripping the separators from patch file names and pasting them
culminates in a terrible summary. In no way does this cover-letter
describe what you're trying to achieve, why you're trying to achieve it
and the consequences for not applying the set. Nor does it communicate
any merge intentions (which is required due to the assumptions made, as
described in our previous conversation).
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-02-13 10:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 13:00 [PATCH RESEND 0/5] LED1202 / leds-st1202 fixes and improvements Manuel Fombuena
2025-02-01 13:02 ` [PATCH RESEND 1/5] leds: leds-st1202: fix NULL pointer access on race condition Manuel Fombuena
2025-02-11 13:31 ` Lee Jones
2025-02-12 16:28 ` Manuel Fombuena
2025-02-13 10:24 ` Lee Jones
2025-02-13 15:25 ` Manuel Fombuena
2025-02-20 15:01 ` Lee Jones
2025-02-11 13:34 ` Lee Jones
2025-02-12 13:16 ` Manuel Fombuena
2025-02-01 13:04 ` [PATCH RESEND 2/5] leds: leds-st1202: initialize hardware before DT node child operations Manuel Fombuena
2025-02-11 13:32 ` Lee Jones
2025-02-12 15:15 ` Manuel Fombuena
2025-02-01 13:04 ` [PATCH RESEND 3/5] leds: leds-st1202: spacing and proofreading editing Manuel Fombuena
2025-02-11 13:34 ` Lee Jones
2025-02-12 14:28 ` Manuel Fombuena
2025-02-01 13:05 ` [PATCH RESEND 4/5] leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN Manuel Fombuena
2025-02-01 13:07 ` [PATCH RESEND 5/5] Documentation: leds: remove .rst extension for leds-st1202 on index Manuel Fombuena
2025-02-13 10:41 ` Lee Jones [this message]
2025-02-13 15:54 ` [PATCH RESEND 0/5] LED1202 / leds-st1202 fixes and improvements Manuel Fombuena
2025-02-20 15:03 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213104119.GD2756671@google.com \
--to=lee@kernel.org \
--cc=corbet@lwn.net \
--cc=fombuena@outlook.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).