From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E15874A07; Tue, 18 Feb 2025 00:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739837997; cv=none; b=Ktu8363TYSClLwv7EznhlfFNG9cAUT4WhFf//InA1Yb5kfVbgjeHKhtKuuKXU7oPi/b3KirHJtUuVE+Z3QZafE9GpCA2ASkA3sILRd2K1TDmOJ6F0DVtorrGN70EGBcAsAVXoiX4qDPgEXI8KAgFGHQeDBnk8iuL5bzGckFGMXs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739837997; c=relaxed/simple; bh=Ymnq93z6WFJ6BRThQv4kCuwLR3K+xrELo2Jr0tkpPsI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SwrdCJS7aHiGZdaDvNjnLH4zQDpnNuR19/xZ0ZHNMR/VJ8emytgJvVGVp3jHNkRjkxY0goyjLeBAgRR6csznErWBhuXg41b+GdzFlRyMfdD9FkosTPZ5JTfzsYcDDYbV3CrWWiQm0IRLxlL6f+RU9r0LxwzTqGbjTzUQa/F+Fik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ey9hpuXj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ey9hpuXj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B51A3C4CED1; Tue, 18 Feb 2025 00:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739837996; bh=Ymnq93z6WFJ6BRThQv4kCuwLR3K+xrELo2Jr0tkpPsI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ey9hpuXjWUy/V5uxdQ/fYHDNf82JcViWzyEiVOhkuIo1U3xEpzqV2me+DUdRdp/us bvk3JzQ9lqlB4oVy4NjGjgsrBpfFrRykkPpHr2VZ7zf+yAg8riFCOI6h/uC5sYGF+i bw4whhBD4SJ/Rrh275sAFcPZRRJTCeuK2bcj2ieI7c4Cdj7KJYLiNc2JgpLBI6jTRh w2bC6fhvrkhQdTeRawdHp3NMSDHhKn4GN+sGDb3XGHG3ZPiJkoY1ALNaXNR91sl8ug jDogUHpvpLYXx5HMD/44LKMoH9TWwOjMIWFYp7nmJuo0REL/rvr6zJ0XGx0ZpoH01i R8ipranr/ULhQ== Date: Mon, 17 Feb 2025 16:19:54 -0800 From: Jakub Kicinski To: Gal Pressman Cc: "David S. Miller" , , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "Tariq Toukan" , Edward Cree , Ahmed Zaki , , Nimrod Oren Subject: Re: [PATCH net-next v3 5/5] selftests: drv-net-hw: Add a test for symmetric RSS hash Message-ID: <20250217161954.57fd1457@kernel.org> In-Reply-To: <20250216182453.226325-6-gal@nvidia.com> References: <20250216182453.226325-1-gal@nvidia.com> <20250216182453.226325-6-gal@nvidia.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 16 Feb 2025 20:24:53 +0200 Gal Pressman wrote: > + # Check for symmetric xor/or-xor > + if input_xfrm and (input_xfrm == 1 or input_xfrm == 2): > + port1 = _get_rand_port(cfg.remote) > + port2 = _get_rand_port(cfg.remote) > + ksft_pr(f'Running traffic on ports: {port1 = }, {port2 = }') > + > + cnts = _get_rx_cnts(cfg) > + GenerateTraffic(cfg, port=port1, parallel=1, > + cport=port2).wait_pkts_and_stop(20000) > + cnts = _get_rx_cnts(cfg, prev=cnts) > + rxq1 = _get_active_rx_queue(cnts) > + ksft_pr(f'Received traffic on {rxq1 = }') > + > + cnts = _get_rx_cnts(cfg) > + GenerateTraffic(cfg, port=port2, parallel=1, > + cport=port1).wait_pkts_and_stop(20000) > + cnts = _get_rx_cnts(cfg, prev=cnts) > + rxq2 = _get_active_rx_queue(cnts) > + ksft_pr(f'Received traffic on {rxq2 = }') > + > + ksft_eq( > + rxq1, rxq2, comment=f"Received traffic on different queues ({rxq1} != {rxq2}) while symmetric hash is configured") Wouldn't it be both faster and less error prone to test this with UDP sockets? sock = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM) sock.connect(cfg.remove_addr_v[ipver], remote_port) sock.recvmsg(100) tgt = f"{ipver}:{cfg.addr_v[ipver]}:{local_port},sourceport={remote_port}" cmd("echo a | socat - UDP" + tgt, host=cfg.remote) cpu = sock.getsockopt(socket.SOL_SOCKET, socket.SO_INCOMING_CPU) Run this for 10 pairs for ports, make sure we hit at least 2 CPUs, and that the CPUs match for each pair. Would be good to test both IPv4 and IPv6. I'm going to merge: https://lore.kernel.org/all/20250217194200.3011136-4-kuba@kernel.org/ it should make writing the v4 + v6 test combos easier. -- pw-bot: cr