From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D430542A8F; Thu, 27 Feb 2025 02:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740624793; cv=none; b=HEbK25Qxa9HmlqXivGTX49jSMiNOwrGDPEiUTYoSx1U32lB9o1wTKcsvdw3vYJaq75oX+XDg/4o/jwxeoEsfVgnJ9VKYc6vlxcQbMl/JLn9duZkrXNjlXwDMutpBOeXVjQaQ/oRZ8ExYeslzc6vwLS7WhmxnuBzpcgNdcgdLBJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740624793; c=relaxed/simple; bh=HQn3kFyIyqvH4epxW53yWGH/1SfObMrTDpgmVoEPrqk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L/u3G8OWXwbYMw3Phyc8i6lnhjuJVNucgTIPRFIUeqDgTh+1iqtPore8PhK/zo96Dgb0+/gVQxlNT5L+iRKcN+b8YvBRQqvYwxo/CVZcylVKqwmW6mrf9oEFgG2iIoyMVTR7Izr2jGTpJQdU/CvQhPuSgj7Fmzyx4xw33+Kvn3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dm72vgPE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dm72vgPE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A49E4C4CEE2; Thu, 27 Feb 2025 02:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740624792; bh=HQn3kFyIyqvH4epxW53yWGH/1SfObMrTDpgmVoEPrqk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dm72vgPEzDhxvXsgbDuBab5q4/HSlANu+hcSMiVek6Dli7PMo6Ut2OyQ8JRZJId/+ l9oINZuu8w9LBLepUw0hj3uA40e2waZT4+0dFHGLsgMqR54gX7T51FxPZpJKI5Ah19 NnQctRX3OJOkL63XXn+CXkEYC7GC1f8N1X5t5kMTgD8TQeBz0F24EjgQcRA+rSB2JZ bfau5kfi0old55RcolHdlHhebS1OpD0lTTOUMu1O8UR7EhOa0evwNThttf4EIuXmef oRfDDLCQ47Kl7rRQI//1SALuvxXiDDUJnqYaB/Gls5xgg1NVOzjv2f9+Nbxp2DS4NE JSoRWsGM5jn+Q== Date: Wed, 26 Feb 2025 18:53:10 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: Tariq Toukan , "David S. Miller" , Paolo Abeni , Eric Dumazet , Andrew Lunn , Jiri Pirko , Cosmin Ratiu , Carolina Jubran , Gal Pressman , Mark Bloch , Donald Hunter , Jonathan Corbet , Saeed Mahameed , Leon Romanovsky , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next 03/10] devlink: Serialize access to rate domains Message-ID: <20250226185310.42305482@kernel.org> In-Reply-To: References: <20250213180134.323929-1-tariqt@nvidia.com> <20250213180134.323929-4-tariqt@nvidia.com> <20250218182130.757cc582@kernel.org> <20250225174005.189f048d@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 26 Feb 2025 15:44:35 +0100 Jiri Pirko wrote: > > Why would there still be PF instances? I'm not suggesting that you > > create a hierarchy of instances. > > I'm not sure how you imagine getting rid of them. One PCI PF > instantiates one devlink now. There are lots of configuration (e.g. params) > that is per-PF. You need this instance for that, how else would you do > per-PF things on shared ASIC instance? There are per-PF ports, right? > Creating SFs is per-PF operation for example. I didn't to thorough > analysis, but I'm sure there are couple of per-PF things like these. Seems like adding a port attribute to SF creation would be a much smaller extension than adding a layer of objects. > Also not breaking the existing users may be an argument to keep per-PF > instances. We're talking about multi-PF devices only. Besides pretty sure we moved multiple params and health reporters to be per port, so IDK what changed now.