From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Donald Hunter <donald.hunter@gmail.com>,
Rob Herring <robh@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 06/12] net: pse-pd: Add support for budget evaluation strategies
Date: Mon, 3 Mar 2025 17:12:26 -0800 [thread overview]
Message-ID: <20250303171226.4fb78c99@kernel.org> (raw)
In-Reply-To: <20250303144051.2503fb43@kmaincent-XPS-13-7390>
On Mon, 3 Mar 2025 14:40:51 +0100 Kory Maincent wrote:
> > Ok, I assume we are talking about different things. I mean - not port
> > specific configurations and diagnostic, will have different interface.
> >
> > BUDGET_EVAL_STRAT is port specific. HP and Cisco implement it as port
> > specific. PD692x0 Protocol manual describe it as port specific too:
> > 3.3.6 Set BT Port Parameters
> > Bits [3..0]—BT port PM mode
> > 0x0: The port power that is used for power management purposes is
> > dynamic (Iport x Vmain).
> > 0x1: The port power that is used for power management purposes is port
> > TPPL_BT.
> > 0x2: The port power that is used for power management purposes is
> > dynamic for non LLDP/CDP/Autoclass ports and TPPL_BT for
> > LLDP/CDP/Autoclass ports. 0xF: Do not change settings.
>
> I don't really understand how that can be port specific when the power budget is
> per PD69208 manager. Maybe I am missing information here.
+1
> > So, I assume, critical components are missing anyway.
>
> As we are not supporting the budget method configured by the user in this
> series, I agreed we should not add any uAPI related to it that could be broken
> or confusing later.
>
> I will remove it and send v6.
v6 sounds like a good idea.
next prev parent reply other threads:[~2025-03-04 1:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 16:19 [PATCH net-next v5 00/12] Add support for PSE budget evaluation strategy Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 01/12] net: ethtool: Add support for ethnl_info_init_ntf helper function Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 02/12] net: pse-pd: Add support for reporting events Kory Maincent
2025-02-21 0:42 ` Jakub Kicinski
2025-02-24 12:33 ` Kory Maincent
2025-02-24 21:47 ` Jakub Kicinski
2025-02-21 8:50 ` Oleksij Rempel
2025-02-24 11:02 ` Kory Maincent
2025-02-24 18:19 ` Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 03/12] net: pse-pd: tps23881: Add support for PSE events and interrupts Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 04/12] net: pse-pd: Add support for PSE power domains Kory Maincent
2025-02-21 0:43 ` Jakub Kicinski
2025-02-18 16:19 ` [PATCH net-next v5 05/12] net: ethtool: Add support for new power domains index description Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 06/12] net: pse-pd: Add support for budget evaluation strategies Kory Maincent
2025-02-21 0:51 ` Jakub Kicinski
2025-02-24 13:10 ` Kory Maincent
2025-02-24 21:45 ` Jakub Kicinski
2025-02-25 9:25 ` Kory Maincent
2025-02-26 1:47 ` Jakub Kicinski
2025-02-26 5:59 ` Oleksij Rempel
2025-02-26 6:06 ` Oleksij Rempel
2025-02-27 2:42 ` Jakub Kicinski
2025-02-27 7:40 ` Oleksij Rempel
2025-02-27 14:57 ` Kory Maincent
2025-02-27 16:40 ` Oleksij Rempel
2025-02-27 18:26 ` Kory Maincent
2025-03-01 13:00 ` Oleksij Rempel
2025-03-03 13:40 ` Kory Maincent
2025-03-04 1:12 ` Jakub Kicinski [this message]
2025-02-18 16:19 ` [PATCH net-next v5 07/12] net: ethtool: Add PSE new budget evaluation strategy support feature Kory Maincent
2025-02-21 13:49 ` Oleksij Rempel
2025-02-24 13:13 ` Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 08/12] net: pse-pd: pd692x0: Add support for PSE PI priority feature Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 09/12] net: pse-pd: pd692x0: Add support for controller and manager power supplies Kory Maincent
2025-02-24 12:42 ` Maxime Chevallier
2025-02-24 12:49 ` Russell King (Oracle)
2025-02-24 13:17 ` Maxime Chevallier
2025-02-18 16:19 ` [PATCH net-next v5 10/12] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply Kory Maincent
2025-02-19 7:41 ` Krzysztof Kozlowski
2025-02-18 16:19 ` [PATCH net-next v5 11/12] net: pse-pd: tps23881: Add support for static port priority feature Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 12/12] dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description Kory Maincent
2025-02-19 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303171226.4fb78c99@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).