From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] docs: netdev: add a note on selftest posting
Date: Thu, 6 Mar 2025 11:25:22 -0800 [thread overview]
Message-ID: <20250306112522.0a2b38b6@kernel.org> (raw)
In-Reply-To: <ba1afa07-ea24-4ae5-8f65-fc2fc24f1a22@kernel.org>
On Thu, 6 Mar 2025 19:22:49 +0100 Matthieu Baerts wrote:
> > +Co-posting selftests
> > +--------------------
> > +
> > +Selftests should be part of the same series as the code changes.
> > +Specifically for fixes both code change and related test should go into
> > +the same tree (the tests may lack a Fixes tag, which is expected).
>
> Regarding the Fixes tag in the tests, could we eventually suggest using
> the same one as for the code change?
>
> Sometimes, I do that to get the corresponding test backported as well,
> if there are no conflicts. That's good to have an easy way to check if
> something has been correctly fixed on stable versions as well.
Hm, that's probably up to the stable team to decide. My intuition
is to reserve Fixes tags for fixes, and add another tag if necessary.
The mention of the Fixes tag was primarily because of NIPA checks...
A bit of a wink and a nod since we try not to speak about NIPA checks.
> The only thing is with the selftests written in Python or Bash: it is
> easy to get a situation where there are no conflicts, but the
> modification doesn't work, e.g. some functions or variables are not
> available, etc. The stable team will then not notice that during their
> build tests. Not sure if my suggestion is safe to recommend then.
Good point..
next prev parent reply other threads:[~2025-03-06 19:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 18:05 [PATCH net-next] docs: netdev: add a note on selftest posting Jakub Kicinski
2025-03-06 18:22 ` Matthieu Baerts
2025-03-06 19:25 ` Jakub Kicinski [this message]
2025-03-07 13:25 ` Aaron Conole
2025-03-06 23:31 ` Cong Wang
2025-03-07 0:41 ` Kuniyuki Iwashima
2025-03-07 1:15 ` Jakub Kicinski
2025-03-11 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306112522.0a2b38b6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).