From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <horms@kernel.org>,
<linux-doc@vger.kernel.org>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH net-next] docs: netdev: add a note on selftest posting
Date: Thu, 6 Mar 2025 17:15:28 -0800 [thread overview]
Message-ID: <20250306171528.6c24bf6d@kernel.org> (raw)
In-Reply-To: <20250307004251.55786-1-kuniyu@amazon.com>
On Thu, 6 Mar 2025 16:41:41 -0800 Kuniyuki Iwashima wrote:
> > +Selftests should be part of the same series as the code changes.
> > +Specifically for fixes both code change and related test should go into
> > +the same tree (the tests may lack a Fixes tag, which is expected).
> > +Mixing code changes and test changes in a single commit is discouraged.
>
> I guess an exception for the mixing is when a code change breaks a
> selftest, or is it fine for NIPA ? (still other CI may complain though)
If it breaks compilation yes, but that should almost never happen?
Functionality-wise it's fine, we don't expect patch-by-patch
compatibility of selftests. At least I don't recall it coming up
in discussions before.
next prev parent reply other threads:[~2025-03-07 1:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 18:05 [PATCH net-next] docs: netdev: add a note on selftest posting Jakub Kicinski
2025-03-06 18:22 ` Matthieu Baerts
2025-03-06 19:25 ` Jakub Kicinski
2025-03-07 13:25 ` Aaron Conole
2025-03-06 23:31 ` Cong Wang
2025-03-07 0:41 ` Kuniyuki Iwashima
2025-03-07 1:15 ` Jakub Kicinski [this message]
2025-03-11 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306171528.6c24bf6d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).