[PATCH] Documentation: Add "Unaccepted" meminfo entry

[PATCH] Documentation: Add "Unaccepted" meminfo entry

[Nico Pache]

Commit dcdfdd40fa82 ("mm: Add support for unaccepted memory") added a
entry to meminfo but did not document it in the proc.rst file.

This counter tracks the amount of "Unaccepted" guest memory for some
Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP.

Add the missing entry in the documentation.

Signed-off-by: Nico Pache <npache@redhat.com>
---
 Documentation/filesystems/proc.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
index 09f0aed5a08b..8fcf19c31b18 100644
--- a/Documentation/filesystems/proc.rst
+++ b/Documentation/filesystems/proc.rst
@@ -1060,6 +1060,7 @@ Example output. You may not have all of these fields.
     FilePmdMapped:         0 kB
     CmaTotal:              0 kB
     CmaFree:               0 kB
+    Unaccepted:            0 kB
     HugePages_Total:       0
     HugePages_Free:        0
     HugePages_Rsvd:        0
@@ -1228,6 +1229,8 @@ CmaTotal
               Memory reserved for the Contiguous Memory Allocator (CMA)
 CmaFree
               Free remaining memory in the CMA reserves
+Unaccepted
+              Memory that has not been accepted by the guest
 HugePages_Total, HugePages_Free, HugePages_Rsvd, HugePages_Surp, Hugepagesize, Hugetlb
               See Documentation/admin-guide/mm/hugetlbpage.rst.
 DirectMap4k, DirectMap2M, DirectMap1G
-- 
2.48.1

Re: [PATCH] Documentation: Add "Unaccepted" meminfo entry

[Kirill A. Shutemov]

On Mon, Mar 17, 2025 at 05:04:03PM -0600, Nico Pache wrote:
> Commit dcdfdd40fa82 ("mm: Add support for unaccepted memory") added a
> entry to meminfo but did not document it in the proc.rst file.
> 
> This counter tracks the amount of "Unaccepted" guest memory for some
> Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP.
> 
> Add the missing entry in the documentation.
> 
> Signed-off-by: Nico Pache <npache@redhat.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

Re: [PATCH] Documentation: Add "Unaccepted" meminfo entry

[David Hildenbrand]

On 18.03.25 00:04, Nico Pache wrote:
> Commit dcdfdd40fa82 ("mm: Add support for unaccepted memory") added a
> entry to meminfo but did not document it in the proc.rst file.
> 
> This counter tracks the amount of "Unaccepted" guest memory for some
> Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP.
> 
> Add the missing entry in the documentation.
> 
> Signed-off-by: Nico Pache <npache@redhat.com>
> ---
>   Documentation/filesystems/proc.rst | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> index 09f0aed5a08b..8fcf19c31b18 100644
> --- a/Documentation/filesystems/proc.rst
> +++ b/Documentation/filesystems/proc.rst
> @@ -1060,6 +1060,7 @@ Example output. You may not have all of these fields.
>       FilePmdMapped:         0 kB
>       CmaTotal:              0 kB
>       CmaFree:               0 kB
> +    Unaccepted:            0 kB
>       HugePages_Total:       0
>       HugePages_Free:        0
>       HugePages_Rsvd:        0
> @@ -1228,6 +1229,8 @@ CmaTotal
>                 Memory reserved for the Contiguous Memory Allocator (CMA)
>   CmaFree
>                 Free remaining memory in the CMA reserves
> +Unaccepted
> +              Memory that has not been accepted by the guest

I was wondering if we could be clearer like

"Memory that has not been accepted. Especially in some confidential VM 
implementations, memory must be accepted manually by the guest OS before 
it can be used the first time."

In any case

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH] Documentation: Add "Unaccepted" meminfo entry

[Nico Pache]

On Tue, Mar 18, 2025 at 2:42 AM David Hildenbrand <david@redhat.com> wrote:
>
> On 18.03.25 00:04, Nico Pache wrote:
> > Commit dcdfdd40fa82 ("mm: Add support for unaccepted memory") added a
> > entry to meminfo but did not document it in the proc.rst file.
> >
> > This counter tracks the amount of "Unaccepted" guest memory for some
> > Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP.
> >
> > Add the missing entry in the documentation.
> >
> > Signed-off-by: Nico Pache <npache@redhat.com>
> > ---
> >   Documentation/filesystems/proc.rst | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst
> > index 09f0aed5a08b..8fcf19c31b18 100644
> > --- a/Documentation/filesystems/proc.rst
> > +++ b/Documentation/filesystems/proc.rst
> > @@ -1060,6 +1060,7 @@ Example output. You may not have all of these fields.
> >       FilePmdMapped:         0 kB
> >       CmaTotal:              0 kB
> >       CmaFree:               0 kB
> > +    Unaccepted:            0 kB
> >       HugePages_Total:       0
> >       HugePages_Free:        0
> >       HugePages_Rsvd:        0
> > @@ -1228,6 +1229,8 @@ CmaTotal
> >                 Memory reserved for the Contiguous Memory Allocator (CMA)
> >   CmaFree
> >                 Free remaining memory in the CMA reserves
> > +Unaccepted
> > +              Memory that has not been accepted by the guest
>
> I was wondering if we could be clearer like
>
> "Memory that has not been accepted. Especially in some confidential VM
> implementations, memory must be accepted manually by the guest OS before
> it can be used the first time."
I actually grappled with the description for longer than I'd like to
admit lol. I wanted to add more but *most* others left the description
short-- so I tried to make it short too.
>
> In any case
>
> Acked-by: David Hildenbrand <david@redhat.com>

Thanks!
>
> --
> Cheers,
>
> David / dhildenb
>