From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BCE11BB6BA for ; Sat, 22 Mar 2025 12:14:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742645650; cv=none; b=BCNigqk1F6aYkU7A4tQbW+piqbz7slcNy9VNL397OAXyfvUzhzc6H+q30BqBFcbB2SPQddQy5iIB4fYTIHNyYbvq2mDSSl9MBirQ2XSbstNsNNePOzjlqLEFlYKq66W9Qtoz2ZjmXEBPkf6ocTibajoZByjjD4brqiM62Y03qDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742645650; c=relaxed/simple; bh=iLuUvH+BOjwrqKZjC7j/H8dzxx6q9BF6OuiO0QRhlK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UolC/larh4HwploKgHrV1LhlkuRuFYKa0vITsTjGLX1wVPz6TukOl0BgxhJzYyBWoH0Pp9/8mZx8aHhrNjXIehQRKzjUphwuyj+bGWem92l6xzOVipbi61ji5PrqkUaWWqlfEy6ysyrM1yDqMKy3kGEZZBWnCZyQx5dCwpmdY6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=Irt5RVt3; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="Irt5RVt3" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3913fdd0120so1610976f8f.0 for ; Sat, 22 Mar 2025 05:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1742645646; x=1743250446; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HWiG+xsp/K3sKHDmBr99lwm1kmwvHTycl73xMSShxhA=; b=Irt5RVt3Wg/+34xFRaCi1zdm4799Ag/5EWaD49kooVaaZOCCdIbT+zbJpRatn7Tphf MZoN+bwlHa9uWHos9I1dNly7Kxe7EqNahC0i0kZpsT87e4qOza9tDCPRU5FhcWZjQF6B ooYGxcauvRK5LJ3chskl2JPjBGuiyPBbAJ0tbWHN59aCviaTwhMabFqXiPnJSvafKBNB Mnib8EQUQbOvZUrWin59M6/hgRsU8In8eVeGiYc53vIsdsxCXmQALPAk3atyl7nN2mW7 4Vx4TWZpX4Ik9F+mj0POIbHProsebxIX7ABssC6klu5bX8dpZ9zy5maGf5SwoTW1eTnM nYWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742645646; x=1743250446; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HWiG+xsp/K3sKHDmBr99lwm1kmwvHTycl73xMSShxhA=; b=LkZT9UClV2CDhQfA69PRwacQA31vGA+z/N6SK/azaaZIFv2L1YyM6iA/vECw8VJ1ue JYMfa03+v3zeDbsJgSxDtQ12VOkCX7vBqlNbbqgcsafmgQ4vbCO81H8YIMJSrStucHWs nwrxMy99Px+XYnPCqQdRE0mQkJ4ir78vpTQtP1ilTJRhDLvOCSTxQZ1CrQkgsj+shv5R v7U0oYSLrF5EQw1UhaS5SgSGQoo4RCUMFWiM+lV0GpvIzhcgvUrBl+WImf6JLVXbw0+H gospo1Uzo6JLa/DXg+qWxrdJZALTZg3qRthNxs0BrnUpFuzFUjs3drmZgPyy+9SMzUjf CZ9w== X-Forwarded-Encrypted: i=1; AJvYcCXfd7H1rBMCS8/KnSD8hZyuOoDmo0PUnCRPRnwyNjySqKLW91APjLyHWJ6hVJOejdxe3M7oMA5rOtU=@vger.kernel.org X-Gm-Message-State: AOJu0YzqnoGjjp2d2X9y2VzAqn404jfANH58doXI8zJb5RedPGo3i5Ka FVJ8xGUSuoemoUfTHQd20o9zlYkeN78KgJxHawhVhY1I1miIXaHI3cmdPN789p8= X-Gm-Gg: ASbGncuUgF8YVaU0maQYxCW1+C73vfVcW39wIw5h6V6jZZwKf2fYv1Z7zErRzoFlXiC CY0gW8X4IvPY3MecV180BxbeRdKlWZqV23rqj/mZ+C2P7O8DPCpvORvu6lkcBvte5XHxNC+gJ/m tXv/HoKWhIhyoBv+mWV65CBJuskcKEFbCmKxa1+02K1net7UVBp58Ldj7x1TxiqxaXcrfmyRHg4 TsMEk7fKa9im+AmwwEOiF2YWqIdKyH9maSpnQ22zWKKMRWfREp0rVCalIf/o4ezcwLrTcqRvumU CXlx/fw+OAT10tkadfyDlVIfmSFPSuRQE8zzUe2W1EAtiXhhltnLa3pOhPRHcE2PMwImne6hqw= = X-Google-Smtp-Source: AGHT+IHDpqohOy/JFZMqFxMBBhwIE63mmqiaNSOUqHyk1TFZEA2JJgoaEQil96e3l0fdWRwlkr8L7g== X-Received: by 2002:a05:6000:1fa6:b0:391:34:4fa9 with SMTP id ffacd0b85a97d-3997f899fafmr5563180f8f.0.1742645645619; Sat, 22 Mar 2025 05:14:05 -0700 (PDT) Received: from localhost (cst2-173-28.cust.vodafone.cz. [31.30.173.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fdb0669sm54992695e9.34.2025.03.22.05.14.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Mar 2025 05:14:05 -0700 (PDT) Date: Sat, 22 Mar 2025 13:14:03 +0100 From: Andrew Jones To: =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= Cc: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, Samuel Holland Subject: Re: [PATCH v4 04/18] riscv: sbi: add SBI FWFT extension calls Message-ID: <20250322-62ad16eaf41abd98170fa6bb@orel> References: <20250317170625.1142870-1-cleger@rivosinc.com> <20250317170625.1142870-5-cleger@rivosinc.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250317170625.1142870-5-cleger@rivosinc.com> On Mon, Mar 17, 2025 at 06:06:10PM +0100, Clément Léger wrote: > Add FWFT extension calls. This will be ratified in SBI V3.0 hence, it is > provided as a separate commit that can be left out if needed. > > Signed-off-by: Clément Léger > --- > arch/riscv/kernel/sbi.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index d41a5642be24..54d9ceb7b723 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -299,6 +299,8 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, > return 0; > } > > +static bool sbi_fwft_supported; > + > /** > * sbi_fwft_get() - Get a feature for the local hart > * @feature: The feature ID to be set > @@ -308,7 +310,15 @@ static int __sbi_rfence_v02(int fid, const struct cpumask *cpu_mask, > */ > int sbi_fwft_get(u32 feature, unsigned long *value) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret = sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_GET, > + feature, 0, 0, 0, 0, 0); We're missing the if (!ret) *value = ret.value; part. > + > + return sbi_err_map_linux_errno(ret.error); > } > > /** > @@ -321,7 +331,15 @@ int sbi_fwft_get(u32 feature, unsigned long *value) > */ > int sbi_fwft_set(u32 feature, unsigned long value, unsigned long flags) > { > - return -EOPNOTSUPP; > + struct sbiret ret; > + > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > + ret = sbi_ecall(SBI_EXT_FWFT, SBI_EXT_FWFT_SET, > + feature, value, flags, 0, 0, 0); > + > + return sbi_err_map_linux_errno(ret.error); > } > > struct fwft_set_req { > @@ -360,6 +378,9 @@ int sbi_fwft_local_set_cpumask(const cpumask_t *mask, u32 feature, > .error = ATOMIC_INIT(0), > }; > > + if (!sbi_fwft_supported) > + return -EOPNOTSUPP; > + > if (feature & SBI_FWFT_GLOBAL_FEATURE_BIT) > return -EINVAL; > > @@ -691,6 +712,11 @@ void __init sbi_init(void) > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available = true; > } > + if ((sbi_spec_version >= sbi_mk_version(3, 0)) && > + (sbi_probe_extension(SBI_EXT_FWFT) > 0)) { > + pr_info("SBI FWFT extension detected\n"); > + sbi_fwft_supported = true; > + } > } else { > __sbi_set_timer = __sbi_set_timer_v01; > __sbi_send_ipi = __sbi_send_ipi_v01; > -- > 2.47.2 > Thanks, drew