From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBBAA265CC8; Wed, 9 Apr 2025 14:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209584; cv=none; b=hSE3lU7BdDpEKmAguPVIzjr/Bgzeek+5ASK5dk0RkpP9Irt67sVTiMZf4HsIBASKG2rBkk4dx6XFzH2z4V60TmXCDHbVVFdx64CHdGqifdGIvD2ASWV0XXuV6IfTUkCli/+mhbnRdIHtkN5c7g1PJdscxD/rhRh/btq8ja6FQVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744209584; c=relaxed/simple; bh=eavIfudAxkQ0CDQau8Hia0v1E+MVOHyrbHbwzaV3J3s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=owZl2NJQx6xqPhpDZdsH86KRESECK/YWkBcoSWTbToqgW/T1jPh7DSZgZ7Ngj5VSiqC9dsa68PrNVq5f6iKnNvDRQVJGMskOqYBUbdZtaVGbTGOgzXRzCE2NugWoNBxosXnpzIvjvKESqsbvtmBXjIlgIKsacPGs0eLE21cepwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZDPJ+PyY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZDPJ+PyY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0AD8C4CEE2; Wed, 9 Apr 2025 14:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744209583; bh=eavIfudAxkQ0CDQau8Hia0v1E+MVOHyrbHbwzaV3J3s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZDPJ+PyYJ7v5LlekieDdtXa/9JtPsnS46YRyqKRUgyHqOADYuP6sJ5qK64yRgHq2C 5Q7/sGYoAVToeYqmTUmL4rq8vbp/jr8KuRf3o0TXajXsuxrU6ndC334mA4y0pIIPIi 9w0Wlay9YgL+ciWQrzDZ4MdJq6ke23izETElJ/OHO3IA2Wnr5dILwPWQUuYB84DVY/ r081psyofHgIpm+3RNnhDCNQ2YAWvlCCjvh9bj6vQckNTzq2AuC/vfwoIEUhDYPJmq 4B4+k54kH/q+Opa//PJViA7Jur9L+r2iLKae+vGlt2dZfdKrRtXxjuqrnT2nFeZU3j 5h0rMRYs1cADA== Date: Wed, 9 Apr 2025 07:39:42 -0700 From: Jakub Kicinski To: "Jagielski, Jedrzej" Cc: "Nelson, Shannon" , "Nguyen, Anthony L" , "davem@davemloft.net" , "pabeni@redhat.com" , "Dumazet, Eric" , "andrew+netdev@lunn.ch" , "netdev@vger.kernel.org" , "Kitszel, Przemyslaw" , "jiri@resnulli.us" , "horms@kernel.org" , "corbet@lwn.net" , "linux-doc@vger.kernel.org" , Kalesh AP , "R, Bharath" Subject: Re: [PATCH net-next 01/15] devlink: add value check to devlink_info_version_put() Message-ID: <20250409073942.26be7914@kernel.org> In-Reply-To: References: <20250407215122.609521-1-anthony.l.nguyen@intel.com> <20250407215122.609521-2-anthony.l.nguyen@intel.com> <7e5aecb4-cb28-4f55-9970-406ec35a5ae7@amd.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 9 Apr 2025 14:14:23 +0000 Jagielski, Jedrzej wrote: > No insisting on that but should empty entry be really presented to the user? > Especially unintentionally? Actually it's exposing some driver's shortcomings. > That means the output was not properly validated so imho there's no point in > printing it. +1, FWIW, I don't see the point of outputting keys without values.