From: Conor Dooley <conor@kernel.org>
To: Cyan Yang <cyan.yang@sifive.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
corbet@lwn.net, paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, samuel.holland@sifive.com,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/12] dt-bindings: riscv: Add xsfvqmaccdod and xsfvqmaccqoq ISA extension description
Date: Tue, 22 Apr 2025 16:17:54 +0100 [thread overview]
Message-ID: <20250422-poise-tighten-aed2c0aae830@spud> (raw)
In-Reply-To: <20250418053239.4351-2-cyan.yang@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]
On Fri, Apr 18, 2025 at 01:32:28PM +0800, Cyan Yang wrote:
> Add "xsfvqmaccdod" and "xsfvqmaccqoq" ISA extensions which are provided by
> SiFive for int8 matrix multiplication instructions support.
>
> Signed-off-by: Cyan Yang <cyan.yang@sifive.com>
If these have some dependencies, please look at how other extensions
have made them required. Otherwise all three dt-binding patches look
fine. I'll leave acks on them all, but with the condition that you
should make dependencies required.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../devicetree/bindings/riscv/extensions.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
> index bcab59e0cc2e..d36e7c68d69a 100644
> --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
> +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
> @@ -662,6 +662,19 @@ properties:
> Registers in the AX45MP datasheet.
> https://www.andestech.com/wp-content/uploads/AX45MP-1C-Rev.-5.0.0-Datasheet.pdf
>
> + # SiFive
> + - const: xsfvqmaccdod
> + description:
> + SiFive Int8 Matrix Multiplication Extensions Specification.
> + See more details in
> + https://www.sifive.com/document-file/sifive-int8-matrix-multiplication-extensions-specification
> +
> + - const: xsfvqmaccqoq
> + description:
> + SiFive Int8 Matrix Multiplication Extensions Specification.
> + See more details in
> + https://www.sifive.com/document-file/sifive-int8-matrix-multiplication-extensions-specification
> +
> # T-HEAD
> - const: xtheadvector
> description:
> --
> 2.39.5 (Apple Git-154)
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-04-22 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 5:32 [PATCH 00/12] riscv: Add vendor extensions support for SiFive Cyan Yang
2025-04-18 5:32 ` [PATCH 01/12] dt-bindings: riscv: Add xsfvqmaccdod and xsfvqmaccqoq ISA extension description Cyan Yang
2025-04-22 15:17 ` Conor Dooley [this message]
2025-04-18 5:32 ` [PATCH 02/12] riscv: Add SiFive xsfvqmaccdod and xsfvqmaccqoq vendor extensions Cyan Yang
2025-05-07 13:34 ` kernel test robot
2025-04-18 5:32 ` [PATCH 03/12] riscv: hwprobe: Document " Cyan Yang
2025-04-18 5:32 ` [PATCH 04/12] riscv: hwprobe: Add SiFive vendor extension support and probe for xsfqmaccdod and xsfqmaccqoq Cyan Yang
2025-04-18 5:32 ` [PATCH 05/12] dt-bindings: riscv: Add xsfvfnrclipxfqf ISA extension description Cyan Yang
2025-04-22 15:18 ` Conor Dooley
2025-04-18 5:32 ` [PATCH 06/12] riscv: Add SiFive xsfvfnrclipxfqf vendor extension Cyan Yang
2025-04-18 5:32 ` [PATCH 07/12] riscv: hwprobe: Document " Cyan Yang
2025-04-18 5:32 ` [PATCH 08/12] riscv: hwprobe: Add " Cyan Yang
2025-04-18 5:32 ` [PATCH 09/12] dt-bindings: riscv: Add xsfvfwmaccqqq ISA extension description Cyan Yang
2025-04-22 15:18 ` Conor Dooley
2025-04-18 5:32 ` [PATCH 10/12] riscv: Add SiFive xsfvfwmaccqqq vendor extension Cyan Yang
2025-04-18 5:32 ` [PATCH 11/12] riscv: hwprobe: Document " Cyan Yang
2025-04-18 5:32 ` [PATCH 12/12] riscv: hwprobe: Add " Cyan Yang
2025-05-09 17:30 ` [PATCH 00/12] riscv: Add vendor extensions support for SiFive patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422-poise-tighten-aed2c0aae830@spud \
--to=conor@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=cyan.yang@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox