From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCD4F28F4; Thu, 8 May 2025 00:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746665231; cv=none; b=ICsM8lApsuaknnHYt3fNjmEU6JFWyH0RT4+lBhRVPJppRjn8ei+ivQ6iObsPwHcqyG07Bq8LQobYOw9NvN5vTgo6GWR2xvZEFB73KurXxRQocx0+8J28dxJhAIEv6vb3+fzq//8Xp6XeDIUoqgJYXG9xBXt4yPWrI2VOlorDvpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746665231; c=relaxed/simple; bh=u0s6dUMqXaUHGlcrUs1yTnxCrmADeAs8uJEdCUa6cn4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M7nxT+KRC2VrOR/YFpRtYR3MzOVPDAHMT9bV5svLwycgnq4KVaHCt1XW1kvFV1qwC5KlmTCi0Vk9pRMsVL+K/L+wcOck+/b9jSWrLduMp9BEep3Faj8VLJTh+oe0z1i5LTOxFBSJFFNQeMJwVp0PZdsgES6XQ3YMOLBIHPXC3rY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CuDieyUi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CuDieyUi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7EA0C4CEE2; Thu, 8 May 2025 00:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746665231; bh=u0s6dUMqXaUHGlcrUs1yTnxCrmADeAs8uJEdCUa6cn4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CuDieyUiM8oKt7l4Kdbwwrd9c4nOZzjrs13TRR0GrUfAJ7oWFxSGZZppytexK8mxL fY5Ol3aUCCcdHikf9a4VLMiIWdsPPJLBd28teLcKmPihLFcDC9q6f/jQTAbmdCVV+e Z0tGwaI/YlpcfgOiHn/8zMTch5IHEdXAlGlPiRIS7v5uNGtoovC5Uq30FRIenT/Exg 60tkh/3bzG/UKBPpdgpUT5hESkXx6g6AKpbVmzha7Ua2Ebp64SwD9sb6d5bHJK3OFT NOT7Wd9QvwllqOAkVWIRvvQz3rrJi43NxHjfD3Iw+0fp5UCtGUn9VK1fJ1Zbyg+/w4 YZhyk/q/D/6bA== Date: Wed, 7 May 2025 17:47:09 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: "David S. Miller" , Paolo Abeni , Eric Dumazet , "Andrew Lunn" , Jiri Pirko , Gal Pressman , "Leon Romanovsky" , Donald Hunter , "Jiri Pirko" , Jonathan Corbet , Saeed Mahameed , Leon Romanovsky , , , , , Moshe Shemesh , Mark Bloch , Carolina Jubran , Cosmin Ratiu Subject: Re: [PATCH net-next V8 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management Message-ID: <20250507174709.5790852a@kernel.org> In-Reply-To: <1746530803-450152-2-git-send-email-tariqt@nvidia.com> References: <1746530803-450152-1-git-send-email-tariqt@nvidia.com> <1746530803-450152-2-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 6 May 2025 14:26:39 +0300 Tariq Toukan wrote: > diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml > index bd9726269b4f..64b6aaa02047 100644 > --- a/Documentation/netlink/specs/devlink.yaml > +++ b/Documentation/netlink/specs/devlink.yaml > @@ -202,6 +202,11 @@ definitions: > name: exception > - > name: control > + - > + name: devlink-rate-tc-index-max > + header: net/devlink.h > + type: const > + value: 7 The spec is for uAPI, but you're declaring a value which is only known to the kernel.. What is the thinking here? It can't stay as is, it breaks the build for user space, since there is no user space header under net/devlink.h -- pw-bot: cr