From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4A49296FCF for ; Thu, 15 May 2025 08:23:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297440; cv=none; b=rTSMt0VwfXqVvxQyAPGpXuPxWoGpttdHC9CEb8q430qVfnCB8CqpvKKcyxOE4PD+e5fpS6k5l9Ly7ZduZgPmglcNoKYkD7TpwUntOCtgbw2xxSjAX18vt44pAL8KOHE/CGLHm0XL2f0AA9Ur96y5hezN4nKuJHGq0Dz9pvI6xU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747297440; c=relaxed/simple; bh=gz6VvvjTGk7E1cSwi96lm1FYuCpqd61naCtEyUpjT8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=StS692aUSIptYbLJD10P/8bUucnIlqTBRtbUSI9rv9NegOpNeY/YWVrsCCOEAdDpHTTD22FBf2qFWVtc8BD76EY3dcMgaZLEs3YaA8Ln40DeRCjIXaNzjcFRxN4y4HVqSNVFBZBGmfXzdhP6IvkHS9Sc/FPF0bdpTA3KK+Uukow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=HGtgdR7N; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="HGtgdR7N" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso4680655e9.3 for ; Thu, 15 May 2025 01:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1747297435; x=1747902235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pJAkm6pLaRGxiRfDXZi/YHgW/rz4khqaVw2vC12MUOY=; b=HGtgdR7N2fze2+HwtHUQlSYc0h6MLpSFAam2Wgs3kHeB+t1Pw7bmegiEWXH201YXmz 2W7rY/dBuTk6Q+ypIOFetOCBMl/Zkz2nEbIP2wjW2Xm2Hae6LbIBkiVnb2KAW2Du7RXv qjldTeZnZcw9995U2hNh98kaHAxF22lmiGAVBsX1Rd9U+iNmqVzNQB+PwfzapWzQPS4u /coCS2w/8djBi5IyG1/xAjuu5AzkRsF3B85yWFK5MxZLeHXnWJXcYR6iYhXqnuY5tNLQ h9mwKny1ZYXWNL1yBW5VDbQTqrrFloUmFUQTA8Vy/iInX0PA20FARmG0WhepAqlHdx3A yJ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747297435; x=1747902235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJAkm6pLaRGxiRfDXZi/YHgW/rz4khqaVw2vC12MUOY=; b=Lgb4NFNGliAHsnaKukvePZHzurCmManUSPp0PQ0iDaeQ5L3yHCBwBsYbmGVFioXYEn zJIZgzcQOZxYHJ3vvcRJSgLKc2oh1FLeQ3TTYE0b2C+uWOKMP5Vt+qsVuWMsTjla5sUk +e38i1uS6bLCzUuy3Mgx/QpD/sieGrwAVbB8P+hmd4HcMqqmvP3Eq5/z9VvLpjSK7k+4 lFHuWaxjT+LiGMPI8bN9wtjIdDifSFffD690LyS7rTGmA8vZLHOL46Auwsm/6zXHWx3N Homc+ZpYlBJHEFBVq2UZMBlRlDdWypQLcqfncDvmdOXNzOrijAUEJ5zpxbrsePmuYvs5 si3Q== X-Forwarded-Encrypted: i=1; AJvYcCXOt4yuvPCSXHoalTbfPoIpIBZgQwE2ucP0uFSm4BZ7D97/fhc8s0U5H9yHX55iPs0jPxsP3lNOqDk=@vger.kernel.org X-Gm-Message-State: AOJu0YyIGHFNphS89YQeM/YtOmwEnz2CI70L6YciMVawCrMWxsPXqH43 OkfRujfTh8dRbGYN/nbTix1MmBHDPCVDkupdoIY6EqoEa3X4xcyyC8vKOu1cHug= X-Gm-Gg: ASbGncv4jvoTg+Iy/7oxsK3SFWLcjDyIhGpXFZz/McSu0MZrlKxcqRHfHp87TFgI2Ed Wip0114KeVunlEyVZ0pQxDbJwDO3ztNntODVTNfJBROFqO/DVcqDWqd4p7vt3ypj0B/vfXs1qhT uioKTH8OMUJXlkKHz2ruBFx+jTkeHRWK/rVAFkLR08wslhir+y7NW2KVonm0NGYOOVAA/taiUir +zQQvLMW5P6rWjhl+keFNIfeqGvMgG6IK9z/RWJy2vg0KAtRqWIFhGfyPFTO4SyJXNbBnf7bnkD uLKui/aYcFvjbZqPIiUVqqQXfVvON2RFkiXtmqQ1ADRwu7WlzT0= X-Google-Smtp-Source: AGHT+IECzWumV9cA1BxSf0fk65MG1v936xTUBe9wcvvYI0imqbHM4JGZ7JFwZqaAyEUGXVqmxzPHUA== X-Received: by 2002:a05:600c:6612:b0:43d:db5:7b1a with SMTP id 5b1f17b1804b1-442f96e75eamr14059925e9.12.1747297434909; Thu, 15 May 2025 01:23:54 -0700 (PDT) Received: from carbon-x1.. ([91.197.138.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f395166fsm59310785e9.18.2025.05.15.01.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 01:23:53 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Samuel Holland , Andrew Jones , Deepak Gupta Subject: [PATCH v7 09/14] riscv: misaligned: move emulated access uniformity check in a function Date: Thu, 15 May 2025 10:22:10 +0200 Message-ID: <20250515082217.433227-10-cleger@rivosinc.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250515082217.433227-1-cleger@rivosinc.com> References: <20250515082217.433227-1-cleger@rivosinc.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Split the code that check for the uniformity of misaligned accesses performance on all cpus from check_unaligned_access_emulated_all_cpus() to its own function which will be used for delegation check. No functional changes intended. Signed-off-by: Clément Léger Reviewed-by: Andrew Jones --- arch/riscv/kernel/traps_misaligned.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c index e551ba17f557..287ec37021c8 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -647,6 +647,18 @@ bool __init check_vector_unaligned_access_emulated_all_cpus(void) } #endif +static bool all_cpus_unaligned_scalar_access_emulated(void) +{ + int cpu; + + for_each_online_cpu(cpu) + if (per_cpu(misaligned_access_speed, cpu) != + RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED) + return false; + + return true; +} + #ifdef CONFIG_RISCV_SCALAR_MISALIGNED static bool unaligned_ctl __read_mostly; @@ -685,8 +697,6 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu) bool __init check_unaligned_access_emulated_all_cpus(void) { - int cpu; - /* * We can only support PR_UNALIGN controls if all CPUs have misaligned * accesses emulated since tasks requesting such control can run on any @@ -694,10 +704,8 @@ bool __init check_unaligned_access_emulated_all_cpus(void) */ on_each_cpu(check_unaligned_access_emulated, NULL, 1); - for_each_online_cpu(cpu) - if (per_cpu(misaligned_access_speed, cpu) - != RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED) - return false; + if (!all_cpus_unaligned_scalar_access_emulated()) + return false; unaligned_ctl = true; return true; -- 2.49.0