From: "Krzysztof Wilczyński" <kw@linux.com>
To: Philipp Stanner <phasta@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Zijun Hu <quic_zijuhu@quicinc.com>,
Yang Yingliang <yangyingliang@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/6] PCI: Remove hybrid-devres region requests
Date: Sat, 17 May 2025 03:25:55 +0900 [thread overview]
Message-ID: <20250516182555.GA2914997@rocinante> (raw)
In-Reply-To: <20250516174141.42527-1-phasta@kernel.org>
Hello,
[...]
> the great day has finally arrived, I managed to get rid of one of the
> big three remaining problems in the PCI devres API (the other two being
> MSI having hybrid-devres, too, and the good old pcim_iomap_tablle)!
>
> It turned out that there aren't even that many users of the hybrid API,
> where pcim_enable_device() switches certain functions in pci.c into
> managed devres mode, which we want to remove.
>
> The affected drivers can be found with:
>
> grep -rlZ "pcim_enable_device" | xargs -0 grep -l "pci_request"
>
> These were:
>
> ASoC [1]
> alsa [2]
> cardreader [3]
> cirrus [4]
> i2c [5]
> mmc [6]
> mtd [7]
> mxser [8]
> net [9]
> spi [10]
> vdpa [11]
> vmwgfx [12]
>
> All of those have been merged and are queued up for the merge window.
> The only possible exception is vdpa, but it seems to be ramped up right
> now; vdpa, however, doesn't even use the hybrid behavior, so that patch
> is just for generic cleanup anyways.
>
> With the users of the hybrid feature gone, the feature itself can
> finally be burned.
>
> So I'm sending out this series now to probe whether it's judged to be
> good enough for the upcoming merge window. If we could take it, we would
> make it impossible that anyone adds new users of the hybrid thing.
>
> If it's too late for the merge window, then that's what it is, of
> course.
>
> In any case I'm glad we can get rid of most of that legacy stuff now.
Thank you for sending a v2! Much appreciated.
I pulled tentatively to the for-ci/devres branch, to get some soak time
with 0-day bot and KernelCI, while we wait for reviews and such.
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-05-16 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 17:41 [PATCH v2 0/6] PCI: Remove hybrid-devres region requests Philipp Stanner
2025-05-16 17:41 ` [PATCH v2 1/6] PCI: Remove hybrid devres nature from request functions Philipp Stanner
2025-05-16 22:58 ` Sathyanarayanan Kuppuswamy
2025-05-16 23:14 ` Sathyanarayanan Kuppuswamy
2025-05-19 7:33 ` Philipp Stanner
2025-05-16 17:41 ` [PATCH v2 2/6] Documentation/driver-api: Update pcim_enable_device() Philipp Stanner
2025-05-16 19:27 ` Randy Dunlap
2025-05-16 21:02 ` ALOK TIWARI
2025-05-16 17:41 ` [PATCH v2 3/6] PCI: Remove pcim_request_region_exclusive() Philipp Stanner
2025-05-16 17:41 ` [PATCH v2 4/6] PCI: Remove request_flags relict from devres Philipp Stanner
2025-05-16 17:41 ` [PATCH v2 5/6] PCI: Remove redundant set of request funcs Philipp Stanner
2025-05-16 17:41 ` [PATCH v2 6/6] PCI: Remove hybrid-devres hazzard warnings from doc Philipp Stanner
2025-05-16 18:25 ` Krzysztof Wilczyński [this message]
2025-05-16 23:14 ` [PATCH v2 0/6] PCI: Remove hybrid-devres region requests Sathyanarayanan Kuppuswamy
2025-05-17 16:33 ` Andy Shevchenko
2025-05-17 17:13 ` Sathyanarayanan Kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516182555.GA2914997@rocinante \
--to=kw@linux.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).