From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
bhelgaas@google.com, corbet@lwn.net,
marek.vasut+renesas@gmail.com, linux-pci@vger.kernel.org,
linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4] PCI: rcar-gen4: Add a document about the firmware
Date: Wed, 21 May 2025 01:47:13 +0900 [thread overview]
Message-ID: <20250520164713.GA1052522@rocinante> (raw)
In-Reply-To: <bo2hxi32znmikg3z6j3rreqqksoijfn3ugb5ahyn4qirixc2b6@k7bs2lvipfz2>
Hello,
> > +Renesas R-Car V4H (r8a779g0) has PCIe controller, and it requires specific
> > +firmware downloading. The firmware file "104_PCIe_fw_addr_data_ver1.05.txt"
> > +is available in the datasheet as a text file. But, Renesas is not able to
> > +distribute the firmware freely. So, it is required to convert the text file
> > +to a binary, and the binary should be placed in /lib/firmware before
> > +the driver runs by using the following script:
>
> nit: the above wording sounds like the script places the firmware under
> /lib/firmware, but it is not.
I took the liberty and refactored the entire document which is being added,
changing the wording and formatting it a little bit. Have a look at:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar-gen4&id=2bdf6ffe9f66d74a6baed3012d78f580c66c0583
Let me know if anything needs to be changed.
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-05-20 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 10:09 [PATCH v4] PCI: rcar-gen4: Add a document about the firmware Yoshihiro Shimoda
2025-05-15 13:12 ` Manivannan Sadhasivam
2025-05-20 16:47 ` Krzysztof Wilczyński [this message]
2025-05-20 16:50 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520164713.GA1052522@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox