From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 956DC1A23A5; Wed, 21 May 2025 14:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747837360; cv=none; b=Mp536ELrXPW6bANBtThrCXMBT75y2BssBa9IV53GcpNaer5pby3Psg0O9m5Td1TWwZYVkJ7i4tlPMT/10z6WE8NFty7JubiQq1r3GlyqsmAtOD/pAfXXwMer8ygjhtFenUuTD0YRaRZ7lNpJm+XCFDcb3BFAuAfCY58qeFLSG28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747837360; c=relaxed/simple; bh=SBMc3kULvbN/i0mN07lWs8tAIHU7iwXg5MTlRdbwlWA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y4PVL61IK5ze/IWKC6aiKrsCraRlAhVcqHTwpwdwNobRtuExypKUWQ9O6VE6wEORKZ/64Ab/w4xTmYLInm6y3BNuCPDd+Qe4h9oKMpxit/Yofw9PHc3tnv1L0G+mfzAo/GThbopx2/lqPnXb3yyBcB4F9vt2LYOXWgA6rnKqrBI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=fYSLMVVs; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="fYSLMVVs" Received: by mail.gandi.net (Postfix) with ESMTPSA id 8FD7443B3F; Wed, 21 May 2025 14:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1747837350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vyPpXbcuqSIPDBMFEqspo4iXigHvW7uXfydpRN7Xbhk=; b=fYSLMVVsQYfpq0UfcQjtXHhEeq5bfCS6ZfFtSy9WALjrRzfOI1oCmQiRh9/p/2Tov1lqL6 6hd7ysvk/ltTNuZ3CAlJ8hxNJb1U4hh9oDe0vFEV7Qmtyyl2jnGS6vHAh+CJjT02k5hPnx /8mrP78Ua2u8o332sEOuGFEL01a6KTHTgbKtJYOaO92+nm28+YzX+fKLT5azjlVWA6wd7P QGZK2iH33WbGHOFi2Bk+4Ix+bA6ASPEQH4bi0kJlvRry4ViIVwFyHbkOYow1fiiPEcPty3 9UYIHe6MjbBN6AI7Wu+J/2jCVZHKny42qJOnl6aqWr/VeHDBSzrL8xxwzk+UAA== Date: Wed, 21 May 2025 16:22:16 +0200 From: Luca Ceresoli To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Douglas Anderson , Chun-Kuang Hu , Krzysztof Kozlowski , Liu Ying Cc: Anusha Srivatsa , Paul Kocialkowski , Dmitry Baryshkov , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, Louis Chauvet , Alim Akhtar , Inki Dae , Kyungmin Park , Seung-Woo Kim , Manikandan Muralidharan , Adam Ford , Adrien Grassein , Aleksandr Mishin , Andy Yan , AngeloGioacchino Del Regno , Benson Leung , Biju Das , Christoph Fritz , Cristian Ciocaltea , Detlev Casanova , Dharma Balasubiramani , Guenter Roeck , Heiko Stuebner , Jani Nikula , Janne Grunau , Jerome Brunet , Jesse Van Gavere , Kevin Hilman , Kieran Bingham , Martin Blumenstingl , Matthias Brugger , Philipp Zabel , Phong LE , Sasha Finkelstein , Sugar Zhang , Sui Jingfeng , Tomi Valkeinen , Vitalii Mordan , "Rob Herring (Arm)" , Hsin-Te Yuan , Pin-yen Lin , Xin Ji , Aradhya Bhatia , Tomi Valkeinen , Ian Ray , Martyn Welch , Peter Senna Tschudin , Helge Deller , Kuninori Morimoto , Laurent Pinchart , Alexandre Torgue , Maxime Coquelin , Philippe Cornu , Raphael Gallais-Pou , Yannick Fertre , Alain Volmat , Raphael Gallais-Pou , Michal Simek , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Message-ID: <20250521162216.79dd3290@booty> In-Reply-To: <20250509-drm-bridge-convert-to-alloc-api-v3-0-b8bc1f16d7aa@bootlin.com> References: <20250509-drm-bridge-convert-to-alloc-api-v3-0-b8bc1f16d7aa@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdeffedtucdltddurdegfedvrddttddmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefnuhgtrgcuvegvrhgvshholhhiuceolhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepheelfeevlefgkeekvdffveehudeihfdtjefhieehgfejveduieffgffhjeejleevnecuffhomhgrihhnpehfrhgvvgguvghskhhtohhprdhorhhgpdhkvghrnhgvlhdrohhrghdpsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvpdhhvghlohepsghoohhthidpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeelhedprhgtphhtthhopehmrggrrhhtvghnrdhlrghnkhhhohhrshhtsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhto hepmhhrihhprghrugeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepthiiihhmmhgvrhhmrghnnhesshhushgvrdguvgdprhgtphhtthhopegrihhrlhhivggusehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhimhhonhgrsehffhiflhhlrdgthhdprhgtphhtthhopegrnhgurhiivghjrdhhrghjuggrsehinhhtvghlrdgtohhmpdhrtghpthhtohepnhgvihhlrdgrrhhmshhtrhhonhhgsehlihhnrghrohdrohhrghdprhgtphhtthhopehrfhhoshhssehkvghrnhgvlhdrohhrgh X-GND-Sasl: luca.ceresoli@bootlin.com Hello Maxime, Shawn, Liu, all, On Fri, 09 May 2025 15:53:26 +0200 Luca Ceresoli wrote: > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > bridge, and the only one supported from now on. It is the first milestone > towards removal of bridges from a still existing DRM pipeline without > use-after-free. I applied on drm-misc-next patches 3-17,20-21 as they match all the criteria: - At least a Acked-by (or R-by maintainers) - patch is for drm-misc Being my very first commits to drm-misc, I tried to be careful, and double checked all the patches with Louis (thanks!). Here are the pending questions and plan for the remaining patches. > Revert "drm/exynos: mic: convert to devm_drm_bridge_alloc() API" This reverts the commit applied my mistake: https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/91c5c7b5bb2dd09b43b025bce6d790d3c79f4518 Neither the original patch nor the revert has been reviewed/acked. As the commit was a mistake, I'm applying the revert by the end of this week (i.e. on Friday) unless there are better instructions. > drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API This patch affects multiple drivers. Running get_maintainers.pl points at Shawn Guo's repository. After reviewing the MAINTAINERS file, this looks like due to the 'N:' line in: ARM/FREESCALE IMX / MXC ARM ARCHITECTURE M: Shawn Guo M: Sascha Hauer R: Pengutronix Kernel Team ... T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git N: imx ... (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528) Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c' file that is touched by the patch. That regexp appears overly generic to me. Shawn, can it be fixed by making it less generic? If not, can we at least add a band-aid 'X:' entry for drivers/gpu/drm/bridge/imx? I think the other matching entry is the one to consider: DRM DRIVERS FOR FREESCALE IMX BRIDGE M: Liu Ying L: dri-devel@lists.freedesktop.org S: Maintained F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml F: drivers/gpu/drm/bridge/imx/ (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948) However it does not list any trees. I _guess_ drm-misc applies here as a fallback as well as common sense. Liu, should this entry have a 'T:' line for drm/misc? > drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API Not acked/reviewed, some discussion happened. I am resending it in v4, possibly with updates based on the discussion. But it has the same issue discussed above, with get_maintiners.pl pointing at Shawn Guo's tree, so in the future I'm assuming this goes to drm-misc unless there are news about that. > drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API No feedback, resending in v4. > drm/todo: add entry to remove devm_drm_put_bridge() This involves documentation maintained on another tree. Where should it be applied? There are two matching entries in MAINTAINERS: * DRM DRIVERS -> the drm tree * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree To me it looks like the second is obviously the closest match as we are dealing with DRM bridges, so I'm applying this as well on Friday unless there are better instructions. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com