From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35C06239E85; Thu, 22 May 2025 15:01:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747926120; cv=none; b=RqYJF4QOpXn287SOYJnrGlzFYuq3cLSyxfSf9Nt6YCXmEmRjdXmV7Lj7hz02NEAAhBeklOH4s5G+Idh+JQZGFVm8YSyI7lHUfs+EyhEY8jhzgfVzvh0g/zgkhfqh+cpPOleaI89L7p9tYgTu1Kg/UNVGe4nunFdOorbNPYwh5cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747926120; c=relaxed/simple; bh=1AAQm9CHyytzF4+9O6MKBfp9oHP7mXu2dEOCXa+XQ60=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sW4c/mhavjHn5NEOQppOtTmnOGX/5+421DmxDSbUvWxgufoZ66skBMY3MhJz2Yp+mta6Flq84JEQfPPuZvYuCnz1rRTaLmtc/Tqnbgv7J6hGP6GInXSXGiv04joKxljsUKCPR8F82S+fcqy61UFbwuYlB54EbXae8/vALxJ6Smo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Oz+QvmtP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Oz+QvmtP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37A09C4CEE4; Thu, 22 May 2025 15:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747926119; bh=1AAQm9CHyytzF4+9O6MKBfp9oHP7mXu2dEOCXa+XQ60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Oz+QvmtPcLQhIfHb7Dmv2r8M+WiSoRM5qPUWyn0k87l+wT8VAirzhjzTpBW0eGBlb UmHr0bWOMyDkznyYF5LwH3teEaFZ1uE9qr6HXEdA+j0uBq3hgFzQ6nt0ZspVQXE85T OIIkY81dtcbV0m2gziJg01/r6Y2SIPkamj7M1kl4Hwl0qo9CYgYZTmBxYNa7ftFs4G zPja9fq08Kq/yFwJiQQ67CJDZJ1PPEHri6tbgslerK1on4Zw3xOpk7dM39CBPgwm8x voI88BFxvrFhvQuMo4HtIGvK0M5a3QE0bAoKlVQx3xcpqnnkL1paG+vNMl/2NKstkd Ah2lYGSdfnOWQ== Date: Thu, 22 May 2025 17:01:57 +0200 From: Maxime Ripard To: Liu Ying Cc: Luca Ceresoli , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Douglas Anderson , Chun-Kuang Hu , Krzysztof Kozlowski , Anusha Srivatsa , Paul Kocialkowski , Dmitry Baryshkov , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, Louis Chauvet , Alim Akhtar , Inki Dae , Kyungmin Park , Seung-Woo Kim , Manikandan Muralidharan , Adam Ford , Adrien Grassein , Aleksandr Mishin , Andy Yan , AngeloGioacchino Del Regno , Benson Leung , Biju Das , Christoph Fritz , Cristian Ciocaltea , Detlev Casanova , Dharma Balasubiramani , Guenter Roeck , Heiko Stuebner , Jani Nikula , Janne Grunau , Jerome Brunet , Jesse Van Gavere , Kevin Hilman , Kieran Bingham , Martin Blumenstingl , Matthias Brugger , Philipp Zabel , Phong LE , Sasha Finkelstein , Sugar Zhang , Sui Jingfeng , Tomi Valkeinen , Vitalii Mordan , "Rob Herring (Arm)" , Hsin-Te Yuan , Pin-yen Lin , Xin Ji , Aradhya Bhatia , Tomi Valkeinen , Ian Ray , Martyn Welch , Peter Senna Tschudin , Helge Deller , Kuninori Morimoto , Laurent Pinchart , Alexandre Torgue , Maxime Coquelin , Philippe Cornu , Raphael Gallais-Pou , Yannick Fertre , Alain Volmat , Raphael Gallais-Pou , Michal Simek , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() Message-ID: <20250522-eager-cautious-dragon-c09cbe@houat> References: <20250509-drm-bridge-convert-to-alloc-api-v3-0-b8bc1f16d7aa@bootlin.com> <20250521162216.79dd3290@booty> <36ade269-a590-4243-889c-006f37d9ae6e@nxp.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="lkfsaolmoihne3h2" Content-Disposition: inline In-Reply-To: <36ade269-a590-4243-889c-006f37d9ae6e@nxp.com> --lkfsaolmoihne3h2 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 00/22] drm: convert all bridges to devm_drm_bridge_alloc() MIME-Version: 1.0 On Thu, May 22, 2025 at 11:20:17AM +0800, Liu Ying wrote: > >> drm: convert many bridge drivers from devm_kzalloc() to devm_drm= _bridge_alloc() API > >=20 > > This patch affects multiple drivers. Running get_maintainers.pl > > points at Shawn Guo's repository. After reviewing the MAINTAINERS file, > > this looks like due to the 'N:' line in: > >=20 > > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > M: Shawn Guo > > M: Sascha Hauer > > R: Pengutronix Kernel Team > > ... > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > > N: imx > > ... > >=20 > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MA= INTAINERS?ref_type=3Dheads#L2511-2528) > >=20 > > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c' > > file that is touched by the patch. That regexp appears overly generic t= o me. > >=20 > > Shawn, can it be fixed by making it less generic? > >=20 > > If not, can we at least add a band-aid 'X:' entry for > > drivers/gpu/drm/bridge/imx? > >=20 > > I think the other matching entry is the one to consider: > >=20 > > DRM DRIVERS FOR FREESCALE IMX BRIDGE > > M: Liu Ying > > L: dri-devel@lists.freedesktop.org > > S: Maintained > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-c= ombiner.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-l= ink.yaml > > F: Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi= =2Eyaml > > F: drivers/gpu/drm/bridge/imx/ > >=20 > > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MA= INTAINERS?ref_type=3Dheads#L7940-7948) > >=20 > > However it does not list any trees. I _guess_ drm-misc applies here as > > a fallback as well as common sense. > >=20 > > Liu, should this entry have a 'T:' line for drm/misc? >=20 > These bridge drivers also don't have a 'T:' line: >=20 > DRM DRIVER FOR CHIPONE ICN6211 MIPI-DSI to RGB CONVERTER BRIDGE > DRM DRIVER FOR PARADE PS8640 BRIDGE CHIP > DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE > DRM DRIVER FOR TI SN65DSI86 BRIDGE CHIP > LONTIUM LT8912B MIPI TO HDMI BRIDGE > MEGACHIPS STDPXXXX-GE-B850V3-FW LVDS/DP++ BRIDGES > MICROCHIP SAM9x7-COMPATIBLE LVDS CONTROLLER >=20 > I think that they fallback to drm-misc since "DRM DRIVERS FOR BRIDGE CHIP= S" > covers them. I don't have strong opinion on adding a "T" line to them, at > least to "DRM DRIVERS FOR FREESCALE IMX BRIDGE". Anyway, it would be good > to know comments from maintainers for "DRM DRIVERS FOR BRIDGE CHIPS" and > "DRM DRIVERS". That's good enough to me. drivers/gpu/drm/bridge is indeed under the maintenance of drm-misc and there's no exception afaik. get_maintainers.pl also properly reports it, so I'm not sure we need to do anything there. Maxime --lkfsaolmoihne3h2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaC88ZAAKCRAnX84Zoj2+ djG+AX9azcCjWg3uajj8kpv9U5tIOYfiLFB/+gEceKcg1OKQ4lA85Sy7O401gsKA sHQZxUMBf0Vj0sOJiWj/u8nCjMwjpC+xsQThFbSdD/ITqF4PFVw2BCwG7J/5XsKx gWgLGdqwyQ== =0NYb -----END PGP SIGNATURE----- --lkfsaolmoihne3h2--