From: Yu Kuai <yukuai1@huaweicloud.com>
To: hch@lst.de, xni@redhat.com, colyli@kernel.org, song@kernel.org,
yukuai3@huawei.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, yukuai1@huaweicloud.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: [PATCH 02/23] md: factor out a helper raid_is_456()
Date: Sat, 24 May 2025 14:12:59 +0800 [thread overview]
Message-ID: <20250524061320.370630-3-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20250524061320.370630-1-yukuai1@huaweicloud.com>
From: Yu Kuai <yukuai3@huawei.com>
There are no functional changes, the helper will be used by llbitmap in
following patches.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/md/md.c | 9 +--------
drivers/md/md.h | 6 ++++++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 18e03f651f6b..b0468e795d94 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9037,19 +9037,12 @@ static sector_t md_sync_position(struct mddev *mddev, enum sync_action action)
static bool sync_io_within_limit(struct mddev *mddev)
{
- int io_sectors;
-
/*
* For raid456, sync IO is stripe(4k) per IO, for other levels, it's
* RESYNC_PAGES(64k) per IO.
*/
- if (mddev->level == 4 || mddev->level == 5 || mddev->level == 6)
- io_sectors = 8;
- else
- io_sectors = 128;
-
return atomic_read(&mddev->recovery_active) <
- io_sectors * sync_io_depth(mddev);
+ (raid_is_456(mddev) ? 8 : 128) * sync_io_depth(mddev);
}
#define SYNC_MARKS 10
diff --git a/drivers/md/md.h b/drivers/md/md.h
index 5ba4a9093a92..c241119e6ef3 100644
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -1011,6 +1011,12 @@ static inline bool mddev_is_dm(struct mddev *mddev)
return !mddev->gendisk;
}
+static inline bool raid_is_456(struct mddev *mddev)
+{
+ return mddev->level == ID_RAID4 || mddev->level == ID_RAID5 ||
+ mddev->level == ID_RAID6;
+}
+
static inline void mddev_trace_remap(struct mddev *mddev, struct bio *bio,
sector_t sector)
{
--
2.39.2
next prev parent reply other threads:[~2025-05-24 6:18 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 6:12 [PATCH 00/23] md/llbitmap: md/md-llbitmap: introduce a new lockless bitmap Yu Kuai
2025-05-24 6:12 ` [PATCH 01/23] md: add a new parameter 'offset' to md_super_write() Yu Kuai
2025-05-25 15:50 ` Xiao Ni
2025-05-26 6:28 ` Christoph Hellwig
2025-05-26 7:28 ` Yu Kuai
2025-05-27 5:54 ` Hannes Reinecke
2025-05-24 6:12 ` Yu Kuai [this message]
2025-05-25 15:50 ` [PATCH 02/23] md: factor out a helper raid_is_456() Xiao Ni
2025-05-26 6:28 ` Christoph Hellwig
2025-05-27 5:55 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 03/23] md/md-bitmap: cleanup bitmap_ops->startwrite() Yu Kuai
2025-05-25 15:51 ` Xiao Ni
2025-05-26 6:29 ` Christoph Hellwig
2025-05-27 5:56 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 04/23] md/md-bitmap: support discard for bitmap ops Yu Kuai
2025-05-25 15:53 ` Xiao Ni
2025-05-26 6:29 ` Christoph Hellwig
2025-05-27 6:01 ` Hannes Reinecke
2025-05-28 7:04 ` Glass Su
2025-05-24 6:13 ` [PATCH 05/23] md/md-bitmap: remove parameter slot from bitmap_create() Yu Kuai
2025-05-25 16:09 ` Xiao Ni
2025-05-26 6:30 ` Christoph Hellwig
2025-05-27 6:01 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 06/23] md/md-bitmap: add a new sysfs api bitmap_type Yu Kuai
2025-05-25 16:32 ` Xiao Ni
2025-05-26 1:13 ` Yu Kuai
2025-05-26 5:11 ` Xiao Ni
2025-05-26 8:02 ` Yu Kuai
2025-05-26 6:32 ` Christoph Hellwig
2025-05-26 7:45 ` Yu Kuai
2025-05-27 8:21 ` Christoph Hellwig
2025-05-27 6:10 ` Hannes Reinecke
2025-05-27 7:43 ` Yu Kuai
2025-05-24 6:13 ` [PATCH 07/23] md/md-bitmap: delay registration of bitmap_ops until creating bitmap Yu Kuai
2025-05-26 6:32 ` Christoph Hellwig
2025-05-26 6:52 ` Xiao Ni
2025-05-26 7:57 ` Yu Kuai
2025-05-27 2:15 ` Xiao Ni
2025-05-27 2:49 ` Yu Kuai
2025-05-27 6:13 ` Hannes Reinecke
2025-05-27 7:53 ` Yu Kuai
2025-05-27 8:54 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 08/23] md/md-bitmap: add a new method skip_sync_blocks() in bitmap_operations Yu Kuai
2025-05-26 7:03 ` Xiao Ni
2025-05-27 6:14 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 09/23] md/md-bitmap: add a new method blocks_synced() " Yu Kuai
2025-05-27 2:35 ` Xiao Ni
2025-05-27 2:48 ` Yu Kuai
2025-05-27 6:16 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 10/23] md: add a new recovery_flag MD_RECOVERY_LAZY_RECOVER Yu Kuai
2025-05-27 6:17 ` Hannes Reinecke
2025-05-27 8:00 ` Yu Kuai
2025-05-24 6:13 ` [PATCH 11/23] md/md-bitmap: make method bitmap_ops->daemon_work optional Yu Kuai
2025-05-26 6:34 ` Christoph Hellwig
2025-05-27 6:19 ` Hannes Reinecke
2025-05-27 8:03 ` Yu Kuai
2025-05-27 8:55 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 12/23] md/md-bitmap: add macros for lockless bitmap Yu Kuai
2025-05-26 6:40 ` Christoph Hellwig
2025-05-26 8:12 ` Yu Kuai
2025-05-27 8:22 ` Christoph Hellwig
2025-05-27 6:21 ` Hannes Reinecke
2025-05-28 4:53 ` Xiao Ni
2025-05-24 6:13 ` [PATCH 13/23] md/md-bitmap: fix dm-raid max_write_behind setting Yu Kuai
2025-05-26 6:40 ` Christoph Hellwig
2025-05-27 6:21 ` Hannes Reinecke
2025-05-24 6:13 ` [PATCH 14/23] md/dm-raid: remove max_write_behind setting limit Yu Kuai
2025-05-26 6:41 ` Christoph Hellwig
2025-05-27 6:26 ` Hannes Reinecke
2025-05-28 4:58 ` Xiao Ni
2025-05-24 6:13 ` [PATCH 15/23] md/md-llbitmap: implement llbitmap IO Yu Kuai
2025-05-27 8:27 ` Christoph Hellwig
2025-05-27 8:55 ` Yu Kuai
2025-05-27 8:58 ` Yu Kuai
2025-06-06 3:21 ` Xiao Ni
2025-06-06 3:48 ` Yu Kuai
2025-06-06 6:24 ` Xiao Ni
2025-06-06 8:56 ` Yu Kuai
2025-06-30 2:07 ` Xiao Ni
2025-06-30 2:17 ` Yu Kuai
2025-05-24 6:13 ` [PATCH 16/23] md/md-llbitmap: implement bit state machine Yu Kuai
2025-06-30 2:14 ` Xiao Ni
2025-06-30 2:25 ` Yu Kuai
2025-06-30 8:25 ` Xiao Ni
2025-06-30 11:05 ` Yu Kuai
2025-06-30 11:30 ` Yu Kuai
2025-07-01 1:55 ` Xiao Ni
2025-07-01 2:02 ` Yu Kuai
2025-07-01 2:31 ` Xiao Ni
2025-05-24 6:13 ` [PATCH 17/23] md/md-llbitmap: implement APIs for page level dirty bits synchronization Yu Kuai
2025-05-24 6:13 ` [PATCH 18/23] md/md-llbitmap: implement APIs to mange bitmap lifetime Yu Kuai
2025-05-29 7:03 ` Xiao Ni
2025-05-29 9:03 ` Yu Kuai
2025-05-24 6:13 ` [PATCH 19/23] md/md-llbitmap: implement APIs to dirty bits and clear bits Yu Kuai
2025-05-24 6:13 ` [PATCH 20/23] md/md-llbitmap: implement APIs for sync_thread Yu Kuai
2025-05-24 6:13 ` [PATCH 21/23] md/md-llbitmap: implement all bitmap operations Yu Kuai
2025-05-24 6:13 ` [PATCH 22/23] md/md-llbitmap: implement sysfs APIs Yu Kuai
2025-05-24 6:13 ` [PATCH 23/23] md/md-llbitmap: add Kconfig Yu Kuai
2025-05-27 8:29 ` Christoph Hellwig
2025-05-27 9:00 ` Yu Kuai
2025-05-24 7:07 ` [PATCH 00/23] md/llbitmap: md/md-llbitmap: introduce a new lockless bitmap Yu Kuai
2025-05-30 6:45 ` Yu Kuai
2025-06-30 1:59 ` Xiao Ni
2025-06-30 2:34 ` Yu Kuai
2025-06-30 3:25 ` Xiao Ni
2025-06-30 3:46 ` Yu Kuai
2025-06-30 5:38 ` Xiao Ni
2025-06-30 6:09 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250524061320.370630-3-yukuai1@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=colyli@kernel.org \
--cc=hch@lst.de \
--cc=johnny.chenyi@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).