From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
"Amirreza Zarrabi" <amirreza.zarrabi@oss.qualcomm.com>,
"Jens Wiklander" <jens.wiklander@linaro.org>,
"Sumit Garg" <sumit.garg@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Apurupa Pattapu" <quic_apurupa@quicinc.com>,
"Kees Cook" <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Harshal Dev <quic_hdev@quicinc.com>,
linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
linux-doc@vger.kernel.org,
Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v5 09/12] tee: add Qualcomm TEE driver
Date: Wed, 28 May 2025 08:22:06 +0300 [thread overview]
Message-ID: <202505280653.Y79JKqDd-lkp@intel.com> (raw)
In-Reply-To: <20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-9-024e3221b0b9@oss.qualcomm.com>
Hi Amirreza,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Amirreza-Zarrabi/tee-allow-a-driver-to-allocate-a-tee_device-without-a-pool/20250527-151020
base: 3be1a7a31fbda82f3604b6c31e4f390110de1b46
patch link: https://lore.kernel.org/r/20250526-qcom-tee-using-tee-ss-without-mem-obj-v5-9-024e3221b0b9%40oss.qualcomm.com
patch subject: [PATCH v5 09/12] tee: add Qualcomm TEE driver
config: x86_64-randconfig-161-20250528 (https://download.01.org/0day-ci/archive/20250528/202505280653.Y79JKqDd-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202505280653.Y79JKqDd-lkp@intel.com/
smatch warnings:
drivers/tee/qcomtee/call.c:748 qcomtee_probe() warn: missing error code 'err'
vim +/err +748 drivers/tee/qcomtee/call.c
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 711 static int qcomtee_probe(struct platform_device *pdev)
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 712 {
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 713 struct workqueue_struct *async_wq;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 714 struct tee_device *teedev;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 715 struct tee_shm_pool *pool;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 716 struct tee_context *ctx;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 717 struct qcomtee *qcomtee;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 718 int err;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 719
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 720 qcomtee = kzalloc(sizeof(*qcomtee), GFP_KERNEL);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 721 if (!qcomtee)
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 722 return -ENOMEM;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 723
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 724 pool = qcomtee_shm_pool_alloc();
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 725 if (IS_ERR(pool)) {
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 726 err = PTR_ERR(pool);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 727
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 728 goto err_free_qcomtee;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 729 }
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 730
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 731 teedev = tee_device_alloc(&qcomtee_desc, NULL, pool, qcomtee);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 732 if (IS_ERR(teedev)) {
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 733 err = PTR_ERR(teedev);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 734
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 735 goto err_pool_destroy;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 736 }
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 737
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 738 qcomtee->teedev = teedev;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 739 qcomtee->pool = pool;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 740 err = tee_device_register(qcomtee->teedev);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 741 if (err)
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 742 goto err_unreg_teedev;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 743
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 744 platform_set_drvdata(pdev, qcomtee);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 745 /* Start async wq. */
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 746 async_wq = alloc_ordered_workqueue("qcomtee_wq", 0);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 747 if (!async_wq)
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 @748 goto err_unreg_teedev;
err = -ENOMEM;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 749
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 750 qcomtee->wq = async_wq;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 751 /* Driver context used for async operations of teedev. */
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 752 ctx = teedev_open(qcomtee->teedev);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 753 if (IS_ERR(ctx)) {
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 754 err = PTR_ERR(ctx);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 755
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 756 goto err_dest_wq;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 757 }
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 758
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 759 qcomtee->ctx = ctx;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 760 /* Init Object table. */
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 761 qcomtee->xa_last_id = 0;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 762 xa_init_flags(&qcomtee->xa_local_objects, XA_FLAGS_ALLOC);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 763 /* Get QTEE verion. */
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 764 qcomtee_get_qtee_feature_list(qcomtee->ctx,
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 765 QCOMTEE_FEATURE_VER_OP_GET_QTEE_ID,
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 766 &qtee_version);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 767
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 768 pr_info("QTEE version %u.%u.%u\n",
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 769 QTEE_VERSION_GET_MAJOR(qtee_version),
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 770 QTEE_VERSION_GET_MINOR(qtee_version),
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 771 QTEE_VERSION_GET_PATCH(qtee_version));
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 772
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 773 return 0;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 774
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 775 err_dest_wq:
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 776 destroy_workqueue(qcomtee->wq);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 777 err_unreg_teedev:
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 778 tee_device_unregister(qcomtee->teedev);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 779 err_pool_destroy:
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 780 tee_shm_pool_free(pool);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 781 err_free_qcomtee:
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 782 kfree(qcomtee);
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 783
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 784 return err;
accd33ce59c3367 Amirreza Zarrabi 2025-05-26 785 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-05-28 5:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 6:56 [PATCH v5 00/12] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE) Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 01/12] tee: allow a driver to allocate a tee_device without a pool Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 02/12] tee: add close_context to TEE driver operation Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 03/12] tee: add TEE_IOCTL_PARAM_ATTR_TYPE_UBUF Amirreza Zarrabi
2025-05-28 0:04 ` kernel test robot
2025-06-11 22:40 ` Andrew Davis
2025-06-11 23:45 ` Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 04/12] tee: add TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 05/12] tee: increase TEE_MAX_ARG_SIZE to 4096 Amirreza Zarrabi
2025-06-11 13:02 ` Sumit Garg
2025-05-27 6:56 ` [PATCH v5 06/12] firmware: qcom: scm: add support for object invocation Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 07/12] firmware: qcom: scm: remove unused arguments to the shm_brige Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 08/12] firmware: qcom: tzmem: export shm_bridge create/delete Amirreza Zarrabi
2025-07-01 11:47 ` Kuldeep Singh
2025-07-08 0:18 ` Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 09/12] tee: add Qualcomm TEE driver Amirreza Zarrabi
2025-05-27 21:28 ` kernel test robot
2025-05-28 5:22 ` Dan Carpenter [this message]
2025-07-07 12:09 ` Sumit Garg
2025-07-11 7:05 ` Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 10/12] qcomtee: add primordial object Amirreza Zarrabi
2025-05-27 6:56 ` [PATCH v5 11/12] qcomtee: enable TEE_IOC_SHM_ALLOC ioctl Amirreza Zarrabi
2025-07-07 12:15 ` Sumit Garg
2025-05-27 6:56 ` [PATCH v5 12/12] Documentation: tee: Add Qualcomm TEE driver Amirreza Zarrabi
2025-07-07 12:19 ` Sumit Garg
2025-07-11 5:05 ` Amirreza Zarrabi
2025-07-08 10:02 ` [PATCH v5 00/12] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE) Harshal Dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505280653.Y79JKqDd-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=amirreza.zarrabi@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=neil.armstrong@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=op-tee@lists.trustedfirmware.org \
--cc=quic_apurupa@quicinc.com \
--cc=quic_hdev@quicinc.com \
--cc=sumit.garg@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).