From: Mario Limonciello <superm1@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)),
"H . Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>, Huang Rui <ray.huang@amd.com>,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
platform-driver-x86@vger.kernel.org (open list:AMD HETERO CORE
HARDWARE FEEDBACK DRIVER),
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
AND 64-BIT)), linux-doc@vger.kernel.org (open list:DOCUMENTATION),
linux-pm@vger.kernel.org (open list:AMD PSTATE DRIVER),
Perry Yuan <Perry.Yuan@amd.com>
Subject: [PATCH v11 08/13] platform/x86: hfi: add power management callback
Date: Mon, 9 Jun 2025 15:05:13 -0500 [thread overview]
Message-ID: <20250609200518.3616080-9-superm1@kernel.org> (raw)
In-Reply-To: <20250609200518.3616080-1-superm1@kernel.org>
From: Perry Yuan <Perry.Yuan@amd.com>
Introduces power management callbacks for the `amd_hfi` driver.
Specifically, the `suspend` and `resume` callbacks have been added
to handle the necessary operations during system low power states
and wake-up.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Co-developed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/platform/x86/amd/hfi/hfi.c | 33 ++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
index 681767d169c26..2c6832a3020ec 100644
--- a/drivers/platform/x86/amd/hfi/hfi.c
+++ b/drivers/platform/x86/amd/hfi/hfi.c
@@ -385,6 +385,38 @@ static int amd_hfi_metadata_parser(struct platform_device *pdev,
return ret;
}
+static int amd_hfi_pm_resume(struct device *dev)
+{
+ int ret, cpu;
+
+ for_each_online_cpu(cpu) {
+ ret = amd_hfi_set_state(cpu, true);
+ if (ret < 0) {
+ dev_err(dev, "failed to enable workload class config: %d\n", ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
+static int amd_hfi_pm_suspend(struct device *dev)
+{
+ int ret, cpu;
+
+ for_each_online_cpu(cpu) {
+ ret = amd_hfi_set_state(cpu, false);
+ if (ret < 0) {
+ dev_err(dev, "failed to disable workload class config: %d\n", ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(amd_hfi_pm_ops, amd_hfi_pm_suspend, amd_hfi_pm_resume);
+
static const struct acpi_device_id amd_hfi_platform_match[] = {
{"AMDI0104", 0},
{ }
@@ -434,6 +466,7 @@ static struct platform_driver amd_hfi_driver = {
.driver = {
.name = AMD_HFI_DRIVER,
.owner = THIS_MODULE,
+ .pm = &amd_hfi_pm_ops,
.acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
},
.probe = amd_hfi_probe,
--
2.43.0
next prev parent reply other threads:[~2025-06-09 20:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 20:05 [PATCH v11 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 03/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 04/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 05/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 06/13] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 07/13] platform/x86: hfi: add online and offline callback support Mario Limonciello
2025-06-09 20:05 ` Mario Limonciello [this message]
2025-06-09 20:05 ` [PATCH v11 09/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 10/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 11/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 12/13] platform/x86/amd: hfi: Add debugfs support Mario Limonciello
2025-06-09 20:05 ` [PATCH v11 13/13] x86/itmt: Add debugfs file to show core priorities Mario Limonciello
2025-06-23 21:53 ` [PATCH v11 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2025-06-30 10:30 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609200518.3616080-9-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).