From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2086.outbound.protection.outlook.com [40.107.236.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68C091E008B; Mon, 16 Jun 2025 14:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.86 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750083304; cv=fail; b=SAQtsRM7mHVVHBWpHhXcOnXTqP3roEbgw07douIQ5OXvRlszumZNKJne1m8HdTyCupiniByvPgtjmfRM3xIq0N+f93Poa5YU4KsPNU0rlwb44UT5/m7gyjXp8Feycpe0N2615MN5roXJ5VxqYNMfRvcjI8CVvfkuBllXjZM1MMk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750083304; c=relaxed/simple; bh=Ia1vttmW1Nndbyqh/HJzL/NMKbFdtsP5TjmLQuQI42I=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=GgsjqT++wEWFGRS4WsZSlU6XzvCYmn+bH29J6/31YtU2xjPR9RdZfeH+KdYBHhRbktmENy277Zjejma0DgSSvrkirrebxJaWSscfzXT4MaR2qEANik3RMmB5hwk0MtfhKFhlnhfrU12CufrILSRWFgR8vGb0yjAaeVpCdGA+CeU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=USgOdyDm; arc=fail smtp.client-ip=40.107.236.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="USgOdyDm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ak3i0NRVKB+wPxMxAFt38x8WHoZfchX1vgkGmrmmSqYu8MrfTvXZotPhhmR1JS1LnOU45xHnzM+DPnqd3rdNzvmNAm8mnlQDh7PIdDkLvWsxfOQw8/FMI/J5BtMjHiBe4XUgbYzn6RQWMANqL7YAf1iUqnkEGTFzvrj7bpyB+ujiey76ehfz+0VLpHHPaeeoiqmaT464hmRpgh4qThpBGcNOzVgrTIwknVky9oCvgEt+Z62YTMSUtHIifgARVah0oJFMNYaoZScm9EptqvMMHIhpY49hG21ZWrK8F/srapdXZkDGTXbtJmca6ou+SGDoTu1K9MVAA9AHCA8X/x/bpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2iQlxE0rMcsR4uZRrJe1+Wk0B7WGJtyv2ttijAHHJEA=; b=P864DYIPFAqjEumZxj2QIlWKr2qYpn5VV1XdmkDMRYSOop4rmdis78pNj7Zwv58YSTewJkx+3NTD04v6eu9lqvRzuNGj8lpuCFE84FLAowZ+DUDMMrqbTCBpsBIR/e9FfjdjO4bHkB5/gpn/gRsriivS2xuKKVOROuWzM9tXOdFd31gJh/q+RtzTP0EMIbU8ofmey9kvJMXwr3J9eIcOuGqmNGNAlSEPpMtrw8dk4methoWsdFlKIG3VOlgXLUCTD5DbM+QO9PzzEKxQbOuhYBA+jmFJUxwA0CV4Xk5aCzyK9I6a9SgnEWNjYFIdo+X5+iea+4UW1f2+XhubwLj6+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2iQlxE0rMcsR4uZRrJe1+Wk0B7WGJtyv2ttijAHHJEA=; b=USgOdyDmVAUsLxaaVwNBNOGqHLAH4EkSBuyidJSAuM/Hzjr6tKjR295Or5R3QuuU8pkeFHG1SotCta/jIA/DYIroHnQ5t0VScUxVhdm9dywUIGCDrE1dF9ItBwFPd8F1Q0xb+gB7dGYdCRZXFPPjO2cGdjUrXcUKdEvd6fFqSHW+kBuLHtKbC1Nb0w9B/XZe1ZIX3OCLnIrQN1TUCtntds31wR0yf9ngNJN+GdWdPL/VsM6JaOkqb6X0wwclD8ZrSYxq1LEiqccpxOMltOtfdjIUm2yEJQlnLTUtGKqcF4Hpc9Fs4eLyRqhyFzOqkFFUIKl67LXDpHLYbV2PSkN9Tw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by DS0PR12MB7605.namprd12.prod.outlook.com (2603:10b6:8:13d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 16 Jun 2025 14:14:59 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%7]) with mapi id 15.20.8835.023; Mon, 16 Jun 2025 14:14:59 +0000 Date: Mon, 16 Jun 2025 11:14:57 -0300 From: Jason Gunthorpe To: Nicolin Chen Cc: kevin.tian@intel.com, corbet@lwn.net, will@kernel.org, bagasdotme@gmail.com, robin.murphy@arm.com, joro@8bytes.org, thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, shuah@kernel.org, jsnitsel@redhat.com, nathan@kernel.org, peterz@infradead.org, yi.l.liu@intel.com, mshavit@google.com, praan@google.com, zhangzekun11@huawei.com, iommu@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, mochs@nvidia.com, alok.a.tiwari@oracle.com, vasant.hegde@amd.com, dwmw2@infradead.org, baolu.lu@linux.intel.com Subject: Re: [PATCH v6 17/25] iommufd: Allow an input data_type via iommu_hw_info Message-ID: <20250616141457.GH1174925@nvidia.com> References: <8e1d8432fb7e11f0ed514bc96690ece1f5e47fdd.1749884998.git.nicolinc@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e1d8432fb7e11f0ed514bc96690ece1f5e47fdd.1749884998.git.nicolinc@nvidia.com> X-ClientProxiedBy: YT4PR01CA0089.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ff::14) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|DS0PR12MB7605:EE_ X-MS-Office365-Filtering-Correlation-Id: 995fda1c-87cf-4ffc-6afd-08ddace02d52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fIqYJxP9CUd2n3eHeiY1KO2hi/wamOk4Frk5frmSKAV31078V4A57QQzblDV?= =?us-ascii?Q?LzqcmIVG4capp5bmi1g687XHNHet2tBV14Y2u93W4Y9ZNb4F/uxJ9Rt8mutK?= =?us-ascii?Q?/JQfmTg0UrfVTcqj+nZcXVHkPYmqMCzwPphc/9zPZ9U3OEM3HdL3QtlhT+Wu?= =?us-ascii?Q?HfKHSVodsaemHmCiilnimrMHojX7Mtgo4W1Nww5+dOrJtTBWGhgOvx/PnZMw?= =?us-ascii?Q?mFJo62DbcSkUUACUzP9b2uTvFRLu7uN1PremAKrq2bLkKrGga9zGhHRmWeJ1?= =?us-ascii?Q?XAnFK6aKDfBhy/ly9hdwHMsMMwF5bBJpDfLNX1isXo+1ZnYYtXyCLoNdXBcY?= =?us-ascii?Q?OWmlE+SwqDtFrj6gMPZpyex/nU9iFwEo0JbXjBCHFFXRTqgGY96l5uc44Tnz?= =?us-ascii?Q?YJ/KcYJxUw7xrXX3j9GCfKx3sI824nWOCFbyDBjpG0NQUGH914DSHctIG+B/?= =?us-ascii?Q?LOkhs/wLQwDwUvm3X5QVub9gDHGkY65RaVUoTan9ExdRvImoqwnNrZoshMYI?= =?us-ascii?Q?2zlteVaPYP8TitPpnsIvhHsUPAJ/skHweK+h2qMYKySCaXFdqBwCTAQ/Vk/b?= =?us-ascii?Q?L+mNb7CVRf/WPTk/78UAe//rCmaacYmUDGQWmADiKYVU7tIRrjjTAvYkfhU6?= =?us-ascii?Q?KTaY3hoE675H/qRDtr+fFhJk6YeFDMx/XI5p5eAZE5k4pESrfy9W5aQ55ty+?= =?us-ascii?Q?vRaPHZwPp+eQ+j0nm2fy5jCdeIydSD6w9ochqm9eRl0kzLQCo7yW7zjCmIql?= =?us-ascii?Q?0H0B5E0UPpIxO7DtYQjlleMNsnwudW9JEYfUGZ9pa0JGBmXNbZbfyPk5criM?= =?us-ascii?Q?tCJQ8Axmthv0uQ1Y0ykpD3kYKeqOzEKGkIBrOEJwgFZJKGORctNzqSNx3BDc?= =?us-ascii?Q?9G84VmyQCUxpI29T0IApOIkuCfHZCQbs9w1anz8OfwTenB6I0fb2hTZJ6dV6?= =?us-ascii?Q?E5ZVo1tHhZ6ZNnq7UJ6x989T1UlUSZgJf17XUgvFzLnzfCgn19xZP/ElBGgz?= =?us-ascii?Q?TA+IBedwQJ/P9/oubGyEwz4i5SYc27bj7OgriKK2xxLrbhNBj/rTgHwIt13W?= =?us-ascii?Q?y0hy+bccaxeKfI+Yjj9SnOPQgGK6Qddr4UZFS+p07/IctkYe4Z7RmhM1/CRw?= =?us-ascii?Q?+Uiz6nENMt6A1KdpojiWl37XmOvehSVlhwkWZHW4EOSC3Bj7NpJATMXvTCp5?= =?us-ascii?Q?m0qURKsALNbKmWjJGwug278yKuryKh4J47ZqMVGp3cjoZ8ROqnmm8P9CzPzr?= =?us-ascii?Q?J/3w/9KQjjwIrxD84nEAhlWK+I2VW2HSHqwcnNDlOfV/zLyB8CFqiCktHxjU?= =?us-ascii?Q?nNI6vd2hhwilIHeaVKCcm0Qevax2bbhwfSsV9mt6y2ux2iT1BSCfG5GUUxWC?= =?us-ascii?Q?DpgZ5eWoDSTGMPNrT89lWEyfQBzZl9Sal9rrvv0xdjK8LKMMl+SxfqeN2FzH?= =?us-ascii?Q?+D27wesNHbk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XG0PU1QjCyotUADgDsx+wip/24EZGURGKQFhSciho0zdlyMUvxrV/nc86wcY?= =?us-ascii?Q?tkEN3VsEWOdjLu8B0NeXPYrJNIOLn2qTJNw2UvoYZijb0C0MCbZBu0cGxIi3?= =?us-ascii?Q?eI3ZJrzrCQEK1LS5P18ZRpDiR663JM1OYGeYgI2Era+A38Le+WnfHAxugvWt?= =?us-ascii?Q?vNe593wLnHh6zKLUNiqRf2VlO+K8KFa5l3XXx2ynN2KU35JGVd2m00dt+Rh6?= =?us-ascii?Q?rUcsJJ7uAQC7SbBjInOKZHZCe5176QQlR+RCpakXrxgJcXoQ6ydKO9ffXRC/?= =?us-ascii?Q?uiEH4zzXLQCLd8pH0djc7b5hCqSAo8CcR4kSVyXNdm+IHLLCDRnLbdYDoTDk?= =?us-ascii?Q?X9gN2nBYsJ6BUBcXMG7fcSzxLvCpwqZjwZQOtLDM82I2KoiYYSxXURYT9G1E?= =?us-ascii?Q?zloZa1KWsmyP/lXnGwUaIlzhyzCTGkF7GJgkdGTxX37EBuRiTDbzqUVa0Fup?= =?us-ascii?Q?a6g7/bnTKhezhtgGM2S4KAbZkfajP6w+FQ1qj9IxWblgG3XcBUZ75sjSJHA8?= =?us-ascii?Q?wYVSRUB4mPeuZaU1dC7JhsZCk24jTJH2kZh7RPjWHvcZPiqYLohmMBUgX3La?= =?us-ascii?Q?zaeDjY+9i+kSVY3lNTgYYn40pwYKL8pAGvQXDPDmTaAlbEnUqpWbqOznxahs?= =?us-ascii?Q?NXAZDfsRNOH+6Ob2O9LBNXR6d0UPEKfmdf3a2RW9aWZeS1FwivuILmSgecog?= =?us-ascii?Q?+JwQrLOGoQDpgqShQcXPsIPiR7LpDCh2l0Qm1L3bxbHrVgv3e1qSbitgw2Yy?= =?us-ascii?Q?S33knIr98qfqJcQtyMjHYyR8NF49kcmT4ajVpmibndgHa2r6cNwplw7g3UWR?= =?us-ascii?Q?uGJo8nPbwDB103V7oMSe5FpfW7hc3J85yctIVdRfWdkAQKkhLzftCDywyxka?= =?us-ascii?Q?C1stsXgA/wxiFPUVVzbGmCZ9LKoo9D7EiKBx6Sb6u96YzsJ+6ltp8CcOKhkT?= =?us-ascii?Q?oQ+pMoLpx0m9dUfd2TJPbNpfag3w52NVPnXByULrP6tk6/ZBlvnJtahACPEC?= =?us-ascii?Q?//FjJIvYw6BqHMhxKuhHywmaPMu3stWJxuSqNf46kwLZw2KvPMvmiBNU9ToU?= =?us-ascii?Q?CB1UHyfIeUzkjw+Me/3lXAXXLh/gB42kyS7LFbE0+feuDOC/CnNls404PB94?= =?us-ascii?Q?ct+B3CK6NwaAt5ZIHlPk0yFFjCnRmhQRzQpmwO2LUuRmo3Aj4ZC5rFq1F6qs?= =?us-ascii?Q?w8fndE8SIWtWsJj/+GNK45ppq6qfnNkc52p7m9Ya6zje2lsHGUx9j3BLbPXY?= =?us-ascii?Q?PLQ8f+p82EO3RWoJQAZ3joM3KI9CybT2YmQaQT0JGrTOJbQhhvt4T9nqoP8g?= =?us-ascii?Q?wm2aUrE3e4DYv/25ddvL/50pzdFo9baa1TaAMiPx4gCpBzPsUSpYO5/2EQ1b?= =?us-ascii?Q?hRe0aRyYfJi+36NfSQ2iwFII+kOULCl9A/uIH5rPjzy9/QA7cEtjz1v0kRWq?= =?us-ascii?Q?4tCcJ7YHJF11sm5EXTPb2yrLRuYHHzUGiFiroIhoJIjm15QxXx92f+IvgnrC?= =?us-ascii?Q?4pZtmVK600r201B9IO6nzOu42BDoN2+BoX8W5a/9Mf0Ca4Hxc0+9Zq6brGtg?= =?us-ascii?Q?7iKGWNlkfuGJgDfAa0Seqr7rrwlCUpsPDnxpIecl?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 995fda1c-87cf-4ffc-6afd-08ddace02d52 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2025 14:14:59.3495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5BliI63KFJesZQXQ2V0BzaUs55QT+uNPOZJQQ0uEt1kwlFE/9zRBJl9f4Q1ILR8A X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7605 On Sat, Jun 14, 2025 at 12:14:42AM -0700, Nicolin Chen wrote: > The iommu_hw_info can output via the out_data_type field the vendor data > type from a driver, but this only allows driver to report one data type. > > Now, with SMMUv3 having a Tegra241 CMDQV implementation, it has two sets > of types and data structs to report. > > One way to support that is to use the same type field bidirectionally. > > Reuse the same field by adding an "in_data_type", allowing user space to > request for a specific type and to get the corresponding data. > > For backward compatibility, since the ioctl handler has never checked an > input value, add an IOMMU_HW_INFO_FLAG_INPUT_TYPE to switch between the > old output-only field and the new bidirectional field. > > Reviewed-by: Kevin Tian > Signed-off-by: Nicolin Chen > --- > include/uapi/linux/iommufd.h | 20 +++++++++++++++++++- > drivers/iommu/iommufd/device.c | 9 ++++++--- > 2 files changed, 25 insertions(+), 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason