From: Jonathan Cameron <jic23@kernel.org>
To: Lothar Rubusch <l.rubusch@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
corbet@lwn.net, lucas.p.stankus@gmail.com, lars@metafoo.de,
Michael.Hennerich@analog.com, bagasdotme@gmail.com,
linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/8] iio: accel: adxl313: add function to enable measurement
Date: Sun, 22 Jun 2025 12:13:42 +0100 [thread overview]
Message-ID: <20250622121342.1d2bab14@jic23-huawei> (raw)
In-Reply-To: <20250615222258.117771-3-l.rubusch@gmail.com>
On Sun, 15 Jun 2025 22:22:52 +0000
Lothar Rubusch <l.rubusch@gmail.com> wrote:
> Refactor the control of measurement and standby modes for the sensor.
> Instead of directly writing to the register, encapsulate this operation
> in a dedicated function that handles enabling and disabling measurement.
> This approach will reduce code duplication wherever sensor configuration
> changes are required. In subsequent patches, measurement mode will be
> set to standby as part of this process.
>
> Additionally, simplify the control mask to include only the measurement
> bit. The sleep bit governs a different behavior—putting the sensor into
> sleep mode, not just standby for configuration—and is currently unused.
> Therefore, there's no need to include both the sleep and measurement
> bits in the same mask.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
Applied.
next prev parent reply other threads:[~2025-06-22 11:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-15 22:22 [PATCH v5 0/8] iio: accel: adxl313: add power-save on activity/inactivity Lothar Rubusch
2025-06-15 22:22 ` [PATCH v5 1/8] iio: accel: adxl313: make use of regmap cache Lothar Rubusch
2025-06-22 11:12 ` Jonathan Cameron
2025-06-15 22:22 ` [PATCH v5 2/8] iio: accel: adxl313: add function to enable measurement Lothar Rubusch
2025-06-22 11:13 ` Jonathan Cameron [this message]
2025-06-15 22:22 ` [PATCH v5 3/8] iio: accel: adxl313: add buffered FIFO watermark with interrupt handling Lothar Rubusch
2025-06-16 9:32 ` Andy Shevchenko
2025-06-17 9:27 ` Lothar Rubusch
2025-06-22 11:28 ` Jonathan Cameron
2025-06-15 22:22 ` [PATCH v5 4/8] iio: accel: adxl313: add activity sensing Lothar Rubusch
2025-06-16 9:35 ` Andy Shevchenko
2025-06-15 22:22 ` [PATCH v5 5/8] iio: accel: adxl313: add inactivity sensing Lothar Rubusch
2025-06-16 10:58 ` Andy Shevchenko
2025-06-17 10:10 ` Lothar Rubusch
2025-06-17 11:54 ` Andy Shevchenko
2025-06-15 22:22 ` [PATCH v5 6/8] iio: accel: adxl313: implement power-save on inactivity Lothar Rubusch
2025-06-15 22:22 ` [PATCH v5 7/8] iio: accel: adxl313: add AC coupled activity/inactivity events Lothar Rubusch
2025-06-16 11:08 ` Andy Shevchenko
2025-06-22 11:37 ` Jonathan Cameron
2025-06-15 22:22 ` [PATCH v5 8/8] docs: iio: add ADXL313 accelerometer Lothar Rubusch
2025-06-16 10:59 ` [PATCH v5 0/8] iio: accel: adxl313: add power-save on activity/inactivity Andy Shevchenko
2025-06-17 1:14 ` Bagas Sanjaya
2025-06-25 8:15 ` Lothar Rubusch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250622121342.1d2bab14@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox