From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5585C28A73D for ; Mon, 30 Jun 2025 13:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751288450; cv=none; b=cTftk9oe/pdqVE9T6sINABCUoDDLMuuVpFz65qoD5W9QrCY8qsUtsPfHAqR2U3XGFYpgiNoyvlFMxsapUhL7J3LwMv3EiUDL7I+UF3fIazlbMZa+ttUKw8tU2iW8Riyvlsu4bHZ80LZ2aNXgQRpSmIFJDGqnS6iAqC8CiRgm0Jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751288450; c=relaxed/simple; bh=eiWjuQAK343S0iGCo5U1CeA1xAD7ABzULSg4BICmapk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=npVDhK0epr9E1S4ZWe6/7Vbw7K2ZbpB3IcTg3up+3Lp98rjmnvx/r5k4cVLIZz/MTMfx4nMgo8VZKZZtqf77Q5c95n80LWH26btOKPbH/xqKfCJPLrfSaXBrICMw4N+Z3NMRMt78QvDhJu02dhfNPvTd7+1Tj/nUIA80nZsAl+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bim2XEHY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bim2XEHY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZjlP0D3eY9tZf8Nb4qLq/i9Tdq3zqU6lo6GiM8rDh3E=; b=bim2XEHYNrTnSjfetcwjQAvCPZnOiiULPhn3icm9ojOKWHg7qqVGalpej/RQ5Oc812JS6N mBLc8umpTl04UC+pDQ3kzniW7frAUa+dW8axHXIal5anMXpaAW6BOegYPpdnpI+fpbONy4 W2B4J3LcvOV0a8+cEelRW+oBr9Z2bL4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-oxBDZ5pZOk-mQBy7F6uIvA-1; Mon, 30 Jun 2025 09:00:42 -0400 X-MC-Unique: oxBDZ5pZOk-mQBy7F6uIvA-1 X-Mimecast-MFC-AGG-ID: oxBDZ5pZOk-mQBy7F6uIvA_1751288441 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so2651997f8f.0 for ; Mon, 30 Jun 2025 06:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288441; x=1751893241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZjlP0D3eY9tZf8Nb4qLq/i9Tdq3zqU6lo6GiM8rDh3E=; b=Lkb5ZkjHp9wM/R4mAlbeNg5W+7+OM0sP8hnvzo1pE8wcOT0RaxP/ulTlKK8yszoojd 9cgeAU0mpUEkGaykOlhRk7OSLDbsjmzsRP3vRSxi7HXhTod2Nrx4zffzUp+tNkQWKUyV /Sm5bf7knTnzqmMW5BWiDLM0I9dB5d6CC1RdhVJg+UOlNVa8LTnEloZwOPqfk4NcPpAR Mw/aSZ7agvJvf8RdzrTx86ILgQmLoBzPQ0gS3aW6YFSA+aG+L99pEg3m9khdB3a0pe23 0wLOEBz/pxEH26GtHgbxIHRo1/cmaUQ7ttNZyqXg0p/XiLydmYnlOXZ5kbvCM5Kx2LhG rtAw== X-Forwarded-Encrypted: i=1; AJvYcCWz2k3/oESA59OdNQm1mkwG8I/m6iMkg/OeTe7mcUzgeszYoJ/yLlWNUXBgfqmakPeSSoFqrdX1hV8=@vger.kernel.org X-Gm-Message-State: AOJu0YxM1skPsGgWDyY2m5CjEbo/AGNXlgiFWF7agExRjS6iprn6ZWsZ WrkOcCnC2v7L+4zAS9s1uPMUahmo8nLpfZoeSCJ1pVM9O8iFanVHGpM0A0QtRJ8PfqvEsQfbg+a bf6wKsqigH9x/ns95oVXuiOAZZ1p+miY1t9cWfmlUzRXmGApWrx7tZ11quC2l1A== X-Gm-Gg: ASbGncsxk6HNiKVEZY67Lv+mZqRJVw08HvhowHKqycHr7JIVA9zHLFuBO1r07bqxOeo OCHo764u7s3cbwi6d8MhfyMYjXVL6WpgM2G2x1X2Th1N2ClPByk7s97eabgnE/2SwQ+g+uuxVYY 3Xjh9NJfAii4F6rDh8BZvyYj7ZDzpaB6y0VecIKYR2a7veRJ2GNqBzPFSSQ8aTwj5CnBqbgPuCX n4BF7IX0owCoSWPznxh1GGAPdWc2T3FBvU0WwbvY3FDffw3mGelIGcw3onp08bvgwu3H2n1f9o3 YpKNWva7WOd+pRZiTnmw7PyuubzogYwGhF/0BmzXIwzueoCaO+U+WwO17udFVMljb66Q+0FAzOK nwgKXJso= X-Received: by 2002:a05:6000:200e:b0:3a6:daff:9e5 with SMTP id ffacd0b85a97d-3a6f31023bdmr13743600f8f.7.1751288440483; Mon, 30 Jun 2025 06:00:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaNYb3ONKvqKvr320nfpncqFiQLJi8PiPIyho0Wzz9N7dVDIemJ3QiyBdfpFdZCgx38anKxQ== X-Received: by 2002:a05:6000:200e:b0:3a6:daff:9e5 with SMTP id ffacd0b85a97d-3a6f31023bdmr13743499f8f.7.1751288439567; Mon, 30 Jun 2025 06:00:39 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e52ca4sm10445235f8f.58.2025.06.30.06.00.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:00:39 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 09/29] mm/migrate: factor out movable_ops page handling into migrate_movable_ops_page() Date: Mon, 30 Jun 2025 14:59:50 +0200 Message-ID: <20250630130011.330477-10-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let's factor it out, simplifying the calling code. The assumption is that flush_dcache_page() is not required for movable_ops pages: as documented for flush_dcache_folio(), it really only applies when the kernel wrote to pagecache pages / pages in highmem. movable_ops callbacks should be handling flushing caches if ever required. Note that we can now change folio_mapping_flags() to folio_test_anon() to make it clearer, because movable_ops pages will never take that path. Reviewed-by: Zi Yan Signed-off-by: David Hildenbrand --- mm/migrate.c | 82 ++++++++++++++++++++++++++++------------------------ 1 file changed, 45 insertions(+), 37 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index d97f7cd137e63..0898ddd2f661f 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -159,6 +159,45 @@ static void putback_movable_ops_page(struct page *page) folio_put(folio); } +/** + * migrate_movable_ops_page - migrate an isolated movable_ops page + * @page: The isolated page. + * + * Migrate an isolated movable_ops page. + * + * If the src page was already released by its owner, the src page is + * un-isolated (putback) and migration succeeds; the migration core will be the + * owner of both pages. + * + * If the src page was not released by its owner and the migration was + * successful, the owner of the src page and the dst page are swapped and + * the src page is un-isolated. + * + * If migration fails, the ownership stays unmodified and the src page + * remains isolated: migration may be retried later or the page can be putback. + * + * TODO: migration core will treat both pages as folios and lock them before + * this call to unlock them after this call. Further, the folio refcounts on + * src and dst are also released by migration core. These pages will not be + * folios in the future, so that must be reworked. + * + * Returns MIGRATEPAGE_SUCCESS on success, otherwise a negative error + * code. + */ +static int migrate_movable_ops_page(struct page *dst, struct page *src, + enum migrate_mode mode) +{ + int rc = MIGRATEPAGE_SUCCESS; + + VM_WARN_ON_ONCE_PAGE(!PageIsolated(src), src); + /* If the page was released by it's owner, there is nothing to do. */ + if (PageMovable(src)) + rc = page_movable_ops(src)->migrate_page(dst, src, mode); + if (rc == MIGRATEPAGE_SUCCESS) + ClearPageIsolated(src); + return rc; +} + /* * Put previously isolated pages back onto the appropriate lists * from where they were once taken off for compaction/migration. @@ -1023,51 +1062,20 @@ static int move_to_new_folio(struct folio *dst, struct folio *src, mode); else rc = fallback_migrate_folio(mapping, dst, src, mode); - } else { - const struct movable_operations *mops; - /* - * In case of non-lru page, it could be released after - * isolation step. In that case, we shouldn't try migration. - */ - VM_BUG_ON_FOLIO(!folio_test_isolated(src), src); - if (!folio_test_movable(src)) { - rc = MIGRATEPAGE_SUCCESS; - folio_clear_isolated(src); + if (rc != MIGRATEPAGE_SUCCESS) goto out; - } - - mops = folio_movable_ops(src); - rc = mops->migrate_page(&dst->page, &src->page, mode); - WARN_ON_ONCE(rc == MIGRATEPAGE_SUCCESS && - !folio_test_isolated(src)); - } - - /* - * When successful, old pagecache src->mapping must be cleared before - * src is freed; but stats require that PageAnon be left as PageAnon. - */ - if (rc == MIGRATEPAGE_SUCCESS) { - if (__folio_test_movable(src)) { - VM_BUG_ON_FOLIO(!folio_test_isolated(src), src); - - /* - * We clear PG_movable under page_lock so any compactor - * cannot try to migrate this page. - */ - folio_clear_isolated(src); - } - /* - * Anonymous and movable src->mapping will be cleared by - * free_pages_prepare so don't reset it here for keeping - * the type to work PageAnon, for example. + * For pagecache folios, src->mapping must be cleared before src + * is freed. Anonymous folios must stay anonymous until freed. */ - if (!folio_mapping_flags(src)) + if (!folio_test_anon(src)) src->mapping = NULL; if (likely(!folio_is_zone_device(dst))) flush_dcache_folio(dst); + } else { + rc = migrate_movable_ops_page(&dst->page, &src->page, mode); } out: return rc; -- 2.49.0