From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5BB0CA4E for ; Mon, 30 Jun 2025 13:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751288423; cv=none; b=ojlIgrrGDmTtGyT6itvl03i51bIN8qehPEXfuWBErOvRsIorSrjwrInXC/xwFQ+qf67i6cgMkfE+LIrmyJZexpEukrhvcoRHvtIWXPa3j6WKRcPIAtxcgVn3jegBc+OsLBJ3J3uaMrU8hU2Ybq/Hsr8Ei5mTAFyJyt6Jh7OvYak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751288423; c=relaxed/simple; bh=RPaleElAAsDd8ZXcp7V7mHwwcGHXNcadS42UzjFFaPQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tcxWAb6CGdl2LUWD/1D68mqWyVcey9Z8Ddi3F+wpC+yD+FQo8TJ6hpMB2ufUKAuUW8qUWcsRk5AfmpgrQNc/4cMi0PvQ2fksuGtbAYGrJRb1b328hQ9ocKrRv5eXR8IolT9+K0AAMl3tgokvZ4AbwxExPewc3fMNhEUQ8nqrz74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JrmFOfTH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JrmFOfTH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751288420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iLYHGg19bG0clXk7rQPjR4hvYWmeZvg7QKQ5c0snrQE=; b=JrmFOfTHghFiuGqmXbEXS8q03samMMV1Ch9jP4dUL4yVTh3GGuQFxo0IkQgZSUlpo3ns1B qhSvNduH8mp5OHu6BZ9M0V/+s1+vv0XlGzjFQeokdTGY6gOl+lX2CG3psnk0tQVnFIDH/n ADen8uVYJMMif6yfkzvGfXon6yYhr/U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-W9hPiEfeON-V-IYFpf_X8w-1; Mon, 30 Jun 2025 09:00:19 -0400 X-MC-Unique: W9hPiEfeON-V-IYFpf_X8w-1 X-Mimecast-MFC-AGG-ID: W9hPiEfeON-V-IYFpf_X8w_1751288418 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4538f375e86so21118185e9.3 for ; Mon, 30 Jun 2025 06:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751288418; x=1751893218; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iLYHGg19bG0clXk7rQPjR4hvYWmeZvg7QKQ5c0snrQE=; b=OcQY8n/C0n9M5yzT2izXoGxmD396LeuSbSLK9CshLqWFNLhItSsstjOPPhq4LPOgoF rd73vG9oC2QAlvvvxGI2nF1gnYCzSADo40z98L7iCIVYTyT9H5Ms4gPnQbJlDaye1/1M h7APFzl+ez3dnj1WLI2RQk9eOOm5EnFT74PpeoYUkP41B6DfMOmvAiaI+NYXgpo30wNR o+LDWXJwFRUAlyfmhg2VXo9D0oN4fR6i0lWoSQIP0IVZ4lBuLat1gw5+I8xkh2WEvDpR qmHXbeNaKGXCRFCpLFFaN4zzH+YduIMjx84d5ioVDfJf8EpkrLoFAYfUAmxyfSLP3fHK Xoig== X-Forwarded-Encrypted: i=1; AJvYcCXzMVlsE7vsfbJUH8SriH6LUws+vMhf3EkAbTvxCWL94YV07KqjR6wvqq4QUpaXQRtq/FpAI97G0zA=@vger.kernel.org X-Gm-Message-State: AOJu0YyRE8DSD8qL/9PaxqPQqwhxa5cpvz0HhWH/d09iTrVEhrmnmWQT Ylk3Mxom8dpd0FTQTPrTAOI1mF04lm5KD+pOHO/1rSTS5CZq+DF3LSNBqUo69OmFiVTBpp5qXAn ITfSOvaD0z7mHYfx4IKRB3hdjclq4WGEehN/zBwdudBkKR1LBrtaJ3V1XkUBpdQ== X-Gm-Gg: ASbGncv4ZEGC4/3sdZjGlaT8fIlQFTZ1Av5HZrsGyJ2t6V1rgwO+1tcuheulWIW14ay BpYRKPqDuh6dH+TJ8A9M9DNy8uyac7ToTUy8BAkTF/bCTlqSWeJCtSJOa0IJGWs9SDtSbA4W9am smWhIDEUxhrDnwBwjs77HQGWLkx0JXK9HBGruIw6J4g3COe+2FsiwOUyAvH6mYw9/oepY/jJkma ZiK95D8UhKYIc0Y40AjPQ8L3Yf74FX7cDDq53KB/Ho6SKoqYQT1xXFu5XA21Be1L8f+RTvb+y8I +grgIUBSLFEcpW9PwjNyIjunPWtaauvGX05nUn7FzJWUGRt7kRTBZ/4eVtxx6EiIQwAmMtjfKON uNDLayGs= X-Received: by 2002:a05:600c:35c9:b0:453:608:a18b with SMTP id 5b1f17b1804b1-453947d8ff2mr103853275e9.9.1751288417724; Mon, 30 Jun 2025 06:00:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGb/NAxjgNou29rgmmNKmV3zZO0Mb6cYoPiX5R9Zf8/khrmrYWUc/XyFqJpcvry+rGAxO8smA== X-Received: by 2002:a05:600c:35c9:b0:453:608:a18b with SMTP id 5b1f17b1804b1-453947d8ff2mr103852575e9.9.1751288417169; Mon, 30 Jun 2025 06:00:17 -0700 (PDT) Received: from localhost (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e59659sm10376420f8f.77.2025.06.30.06.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 06:00:16 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH v1 01/29] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Mon, 30 Jun 2025 14:59:42 +0200 Message-ID: <20250630130011.330477-2-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250630130011.330477-1-david@redhat.com> References: <20250630130011.330477-1-david@redhat.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Acked-by: Zi Yan Signed-off-by: David Hildenbrand --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index d3e00731e2628..fcb60233aa35d 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -94,12 +94,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, if (!trylock_page(page)) continue; - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); -- 2.49.0