Re: [PATCH v3 07/16] iomap: rename iomap_writepage_map to iomap_writeback_folio

Darrick J. Wong
2025-07-02T17:41:21Z

On Mon, Jun 23, 2025 at 07:21:26PM -0700, Joanne Koong wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> ->writepage is gone, and our naming wasn't always that great to start
> with.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Yesssssss
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
> fs/iomap/buffered-io.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index c262f883f9f9..c6bbee68812e 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -1586,7 +1586,7 @@ static int iomap_writeback_range(struct iomap_writepage_ctx *wpc,
> * If the folio is entirely beyond i_size, return false. If it straddles
> * i_size, adjust end_pos and zero all data beyond i_size.
> */
> -static bool iomap_writepage_handle_eof(struct folio *folio, struct inode *inode,
> +static bool iomap_writeback_handle_eof(struct folio *folio, struct inode *inode,
> u64 *end_pos)
> {
> u64 isize = i_size_read(inode);
> @@ -1638,7 +1638,7 @@ static bool iomap_writepage_handle_eof(struct folio *folio, struct inode *inode,
> return true;
> }
>
> -static int iomap_writepage_map(struct iomap_writepage_ctx *wpc,
> +static int iomap_writeback_folio(struct iomap_writepage_ctx *wpc,
> struct folio *folio)
> {
> struct iomap_folio_state *ifs = folio->private;
> @@ -1656,7 +1656,7 @@ static int iomap_writepage_map(struct iomap_writepage_ctx *wpc,
>
> trace_iomap_writepage(inode, pos, folio_size(folio));
>
> - if (!iomap_writepage_handle_eof(folio, inode, &end_pos)) {
> + if (!iomap_writeback_handle_eof(folio, inode, &end_pos)) {
> folio_unlock(folio);
> return 0;
> }
> @@ -1741,7 +1741,7 @@ iomap_writepages(struct iomap_writepage_ctx *wpc)
> return -EIO;
>
> while ((folio = writeback_iter(mapping, wpc->wbc, folio, &error)))
> - error = iomap_writepage_map(wpc, folio);
> + error = iomap_writeback_folio(wpc, folio);
>
> /*
> * If @error is non-zero, it means that we have a situation where some
> --
> 2.47.1
>
>