Re: [PATCH v4 4/5] mm/filemap: add write_begin_get_folio() helper function

Matthew Wilcox
2025-07-07T12:27:07Z

On Mon, Jul 07, 2025 at 07:48:34PM +0800, hanqi wrote:
> I think it might be worth considering adding an fgf_t parameter to the
> write_begin_get_folio() helper, since in some filesystems the fgp_flags
> passed to __filemap_get_folio() in write_begin are not limited to just
> FGP_WRITEBEGIN. Something like:
> struct folio *write_begin_get_folio(const struct kiocb *iocb,
> struct address_space *mapping,
> pgoff_t index, size_t len,
> fgf_t fgp_flags)

The point is to make the simple cases simple. Filesystems which need
something more complicated can do it all themselves. NAK your idea.