linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Xiongwei Song <xiongwei.song@windriver.com>,
	Xin Li <xin3.li@intel.com>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Michael Roth <michael.roth@amd.com>,
	Tony Luck <tony.luck@intel.com>,
	Alexey Kardashevskiy <aik@amd.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Sohil Mehta <sohil.mehta@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	Daniel Sneddon <daniel.sneddon@linux.intel.com>,
	Kai Huang <kai.huang@intel.com>,
	Sandipan Das <sandipan.das@amd.com>,
	Breno Leitao <leitao@debian.org>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Alexei Starovoitov <ast@kernel.org>, Hou Tao <houtao1@huawei.com>,
	Juergen Gross <jgross@suse.com>,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Kees Cook <kees@kernel.org>, Eric Biggers <ebiggers@google.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Yuntao Wang <ytcoode@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Tejun Heo <tj@kernel.org>, Changbin Du <changbin.du@huawei.com>,
	Huang Shijie <shijie@os.amperecomputing.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-efi@vger.kernel.org, linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [PATCHv9 16/16] x86: Re-enable Linear Address Masking
Date: Mon,  7 Jul 2025 11:03:16 +0300	[thread overview]
Message-ID: <20250707080317.3791624-17-kirill.shutemov@linux.intel.com> (raw)
In-Reply-To: <20250707080317.3791624-1-kirill.shutemov@linux.intel.com>

This reverts commit 3267cb6d3a174ff83d6287dcd5b0047bbd912452.

LASS mitigates the Spectre based on LAM (SLAM) [1] and the previous
commit made LAM depend on LASS, so we no longer need to disable LAM at
compile time, so revert the commit that disables LAM.

Adjust USER_PTR_MAX if LAM enabled, allowing tag bits to be set for
userspace pointers. The value for the constant is defined in a way to
avoid overflow compiler warning on 32-bit config.

[1] https://download.vusec.net/papers/slam_sp24.pdf

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
---
 arch/x86/Kconfig             | 1 -
 arch/x86/kernel/cpu/common.c | 5 +----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 71019b3b54ea..2b48e916b754 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2181,7 +2181,6 @@ config RANDOMIZE_MEMORY_PHYSICAL_PADDING
 config ADDRESS_MASKING
 	bool "Linear Address Masking support"
 	depends on X86_64
-	depends on COMPILE_TEST || !CPU_MITIGATIONS # wait for LASS
 	help
 	  Linear Address Masking (LAM) modifies the checking that is applied
 	  to 64-bit linear addresses, allowing software to use of the
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 382b687ce7e2..7ae757498a6f 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -2553,11 +2553,8 @@ void __init arch_cpu_finalize_init(void)
 	if (IS_ENABLED(CONFIG_X86_64)) {
 		unsigned long USER_PTR_MAX = TASK_SIZE_MAX;
 
-		/*
-		 * Enable this when LAM is gated on LASS support
 		if (cpu_feature_enabled(X86_FEATURE_LAM))
-			USER_PTR_MAX = (1ul << 63) - PAGE_SIZE;
-		 */
+			USER_PTR_MAX = (-1UL >> 1) & PAGE_MASK;
 		runtime_const_init(ptr, USER_PTR_MAX);
 
 		/*
-- 
2.47.2


  parent reply	other threads:[~2025-07-07  8:03 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07  8:03 [PATCHv9 00/16] x86: Enable Linear Address Space Separation support Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 01/16] x86/cpu: Enumerate the LASS feature bits Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 02/16] x86/alternatives: Disable LASS when patching kernel alternatives Kirill A. Shutemov
2025-07-09  1:08   ` Sohil Mehta
2025-07-09  9:35     ` Kirill A. Shutemov
2025-07-09 16:58   ` Dave Hansen
2025-07-25  2:35     ` Sohil Mehta
2025-07-28 19:11   ` David Laight
2025-07-28 19:28     ` H. Peter Anvin
2025-07-28 19:38       ` David Laight
2025-08-01  0:15         ` Sohil Mehta
2025-07-07  8:03 ` [PATCHv9 03/16] x86/cpu: Set LASS CR4 bit as pinning sensitive Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 04/16] x86/cpu: Defer CR pinning setup until core initcall Kirill A. Shutemov
2025-07-09  1:19   ` Sohil Mehta
2025-07-09  9:38     ` Kirill A. Shutemov
2025-07-09 17:00   ` Dave Hansen
2025-07-31 23:45     ` Sohil Mehta
2025-08-01  0:01       ` Dave Hansen
2025-08-01  4:43         ` Sohil Mehta
2025-08-01 14:22           ` Dave Hansen
2025-08-02 18:51         ` Kees Cook
2025-08-04  6:55           ` H. Peter Anvin
2025-07-07  8:03 ` [PATCHv9 05/16] efi: Disable LASS around set_virtual_address_map() EFI call Kirill A. Shutemov
2025-07-09  1:27   ` Sohil Mehta
2025-07-07  8:03 ` [PATCHv9 06/16] x86/vsyscall: Do not require X86_PF_INSTR to emulate vsyscall Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 07/16] x86/vsyscall: Reorganize the #PF emulation code Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 08/16] x86/traps: Consolidate user fixups in exc_general_protection() Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 09/16] x86/vsyscall: Add vsyscall emulation for #GP Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 10/16] x86/vsyscall: Disable LASS if vsyscall mode is set to EMULATE Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 11/16] x86/traps: Communicate a LASS violation in #GP message Kirill A. Shutemov
2025-07-09  2:40   ` Sohil Mehta
2025-07-09  9:31     ` Kirill A. Shutemov
2025-07-09  9:36       ` Geert Uytterhoeven
2025-07-09  9:51         ` Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 12/16] x86/traps: Generalize #GP address decode and hint code Kirill A. Shutemov
2025-07-09  4:59   ` Sohil Mehta
2025-07-07  8:03 ` [PATCHv9 13/16] x86/traps: Handle LASS thrown #SS Kirill A. Shutemov
2025-07-09  5:12   ` Sohil Mehta
2025-07-09 10:38     ` Kirill A. Shutemov
2025-07-11  1:22       ` Sohil Mehta
2025-07-11  1:23   ` Sohil Mehta
2025-07-07  8:03 ` [PATCHv9 14/16] x86/cpu: Enable LASS during CPU initialization Kirill A. Shutemov
2025-07-07  8:03 ` [PATCHv9 15/16] x86/cpu: Make LAM depend on LASS Kirill A. Shutemov
2025-07-07  8:03 ` Kirill A. Shutemov [this message]
2025-07-09  5:31   ` [PATCHv9 16/16] x86: Re-enable Linear Address Masking Sohil Mehta
2025-07-09 11:00     ` Kirill A. Shutemov
2025-07-11  0:42       ` Sohil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707080317.3791624-17-kirill.shutemov@linux.intel.com \
    --to=kirill.shutemov@linux.intel.com \
    --cc=acme@redhat.com \
    --cc=aik@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=ast@kernel.org \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=changbin.du@huawei.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ebiggers@google.com \
    --cc=geert+renesas@glider.be \
    --cc=houtao1@huawei.com \
    --cc=hpa@zytor.com \
    --cc=jgg@ziepe.ca \
    --cc=jgross@suse.com \
    --cc=jpoimboe@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=kees@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luto@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=michael.roth@amd.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=rppt@kernel.org \
    --cc=sandipan.das@amd.com \
    --cc=shijie@os.amperecomputing.com \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vegard.nossum@oracle.com \
    --cc=x86@kernel.org \
    --cc=xin3.li@intel.com \
    --cc=xiongwei.song@windriver.com \
    --cc=ytcoode@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).