linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [agd5f:amd-staging-drm-next 2314/2370] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:380: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
@ 2025-07-17 22:43 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-07-17 22:43 UTC (permalink / raw)
  To: Dominik Kaszewski; +Cc: oe-kbuild-all, Ivan Lipski, Alvin Lee, linux-doc

tree:   https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head:   b78bd8003071f2bcd1a9d2404f274ff0b52a4a6a
commit: c9130176a41e56044df495a72f7eb2027824034a [2314/2370] drm/amd/display: Workaround for stuck I2C arbitrage
config: arc-randconfig-002-20250718 (https://download.01.org/0day-ci/archive/20250718/202507180659.A4dgugSk-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250718/202507180659.A4dgugSk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507180659.A4dgugSk-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:380: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * If we boot without an HDMI display, the I2C engine does not get initialized


vim +380 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c

   378	
   379	/**
 > 380	 * If we boot without an HDMI display, the I2C engine does not get initialized
   381	 * correctly. One of its symptoms is that SW_USE_I2C does not get cleared after
   382	 * acquire, so that after setting SW_DONE_USING_I2C on release, the engine gets
   383	 * immediately reacquired by SW, preventing DMUB from using it.
   384	 */
   385	static void cntl_stuck_hw_workaround(struct dce_i2c_hw *dce_i2c_hw)
   386	{
   387		uint32_t arbitrate = 0;
   388	
   389		REG_GET(DC_I2C_ARBITRATION, DC_I2C_REG_RW_CNTL_STATUS, &arbitrate);
   390		if (arbitrate != DC_I2C_STATUS__DC_I2C_STATUS_USED_BY_SW)
   391			return;
   392	
   393		// Still acquired after release, release again as a workaround
   394		REG_UPDATE(DC_I2C_ARBITRATION, DC_I2C_SW_DONE_USING_I2C_REG, true);
   395		REG_GET(DC_I2C_ARBITRATION, DC_I2C_REG_RW_CNTL_STATUS, &arbitrate);
   396		ASSERT(arbitrate != DC_I2C_STATUS__DC_I2C_STATUS_USED_BY_SW);
   397	}
   398	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-07-17 22:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-17 22:43 [agd5f:amd-staging-drm-next 2314/2370] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:380: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).