From: Yu Kuai <yukuai1@huaweicloud.com>
To: corbet@lwn.net, agk@redhat.com, snitzer@kernel.org,
mpatocka@redhat.com, song@kernel.org, yukuai3@huawei.com,
hare@suse.de
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@lists.linux.dev, linux-raid@vger.kernel.org,
yukuai1@huaweicloud.com, yi.zhang@huawei.com,
yangerkun@huawei.com, johnny.chenyi@huawei.com
Subject: [PATCH v3 02/11] md: factor out a helper raid_is_456()
Date: Fri, 18 Jul 2025 17:23:27 +0800 [thread overview]
Message-ID: <20250718092336.3346644-3-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20250718092336.3346644-1-yukuai1@huaweicloud.com>
From: Yu Kuai <yukuai3@huawei.com>
There are no functional changes, the helper will be used by llbitmap in
following patches.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Xiao Ni <xni@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
drivers/md/md.c | 9 +--------
drivers/md/md.h | 6 ++++++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 1a19a9c2b50d..a70d8536075c 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9047,19 +9047,12 @@ static sector_t md_sync_position(struct mddev *mddev, enum sync_action action)
static bool sync_io_within_limit(struct mddev *mddev)
{
- int io_sectors;
-
/*
* For raid456, sync IO is stripe(4k) per IO, for other levels, it's
* RESYNC_PAGES(64k) per IO.
*/
- if (mddev->level == 4 || mddev->level == 5 || mddev->level == 6)
- io_sectors = 8;
- else
- io_sectors = 128;
-
return atomic_read(&mddev->recovery_active) <
- io_sectors * sync_io_depth(mddev);
+ (raid_is_456(mddev) ? 8 : 128) * sync_io_depth(mddev);
}
#define SYNC_MARKS 10
diff --git a/drivers/md/md.h b/drivers/md/md.h
index f9fdcc5eea22..ae8e7a9c5cc4 100644
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -1011,6 +1011,12 @@ static inline bool mddev_is_dm(struct mddev *mddev)
return !mddev->gendisk;
}
+static inline bool raid_is_456(struct mddev *mddev)
+{
+ return mddev->level == ID_RAID4 || mddev->level == ID_RAID5 ||
+ mddev->level == ID_RAID6;
+}
+
static inline void mddev_trace_remap(struct mddev *mddev, struct bio *bio,
sector_t sector)
{
--
2.39.2
next prev parent reply other threads:[~2025-07-18 9:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 9:23 [PATCH v3 00/11] md/llbitmap: md/md-llbitmap: introduce a new lockless bitmap Yu Kuai
2025-07-18 9:23 ` [PATCH v3 01/11] md: add a new parameter 'offset' to md_super_write() Yu Kuai
2025-07-18 9:23 ` Yu Kuai [this message]
2025-07-18 9:23 ` [PATCH v3 03/11] md/md-bitmap: support discard for bitmap ops Yu Kuai
2025-07-18 9:23 ` [PATCH v3 04/11] md: add a new mddev field 'bitmap_id' Yu Kuai
2025-07-18 9:23 ` [PATCH v3 05/11] md/md-bitmap: add a new sysfs api bitmap_type Yu Kuai
2025-07-18 9:23 ` [PATCH v3 06/11] md/md-bitmap: delay registration of bitmap_ops until creating bitmap Yu Kuai
2025-07-19 6:49 ` Li Nan
2025-07-19 9:45 ` Yu Kuai
2025-07-21 6:01 ` Hannes Reinecke
2025-07-21 6:10 ` Yu Kuai
2025-07-18 9:23 ` [PATCH v3 07/11] md/md-bitmap: add a new method skip_sync_blocks() in bitmap_operations Yu Kuai
2025-07-18 9:23 ` [PATCH v3 08/11] md/md-bitmap: add a new method blocks_synced() " Yu Kuai
2025-07-18 9:23 ` [PATCH v3 09/11] md: add a new recovery_flag MD_RECOVERY_LAZY_RECOVER Yu Kuai
2025-07-18 9:23 ` [PATCH v3 10/11] md/md-bitmap: make method bitmap_ops->daemon_work optional Yu Kuai
2025-07-18 9:23 ` [PATCH v3 11/11] md/md-llbitmap: introduce new lockless bitmap Yu Kuai
2025-07-21 6:20 ` Hannes Reinecke
2025-07-21 7:12 ` Yu Kuai
2025-07-21 7:20 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718092336.3346644-3-yukuai1@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=agk@redhat.com \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=hare@suse.de \
--cc=johnny.chenyi@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).