From: Steven Rostedt <rostedt@goodmis.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Greg KH <greg@kroah.com>, Sasha Levin <sashal@kernel.org>,
corbet@lwn.net, linux-doc@vger.kernel.org,
workflows@vger.kernel.org, josh@joshtriplett.org,
kees@kernel.org, konstantin@linuxfoundation.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/4] Add agent coding assistant configuration to Linux kernel
Date: Wed, 30 Jul 2025 13:12:53 -0400 [thread overview]
Message-ID: <20250730131253.48f5b08d@gandalf.local.home> (raw)
In-Reply-To: <aIpLB5oMc1tSq1SP@gallifrey>
On Wed, 30 Jul 2025 16:40:39 +0000
"Dr. David Alan Gilbert" <linux@treblig.org> wrote:
> * Steven Rostedt (rostedt@goodmis.org) wrote:
> > On Wed, 30 Jul 2025 16:34:28 +0100
> > Lorenzo Stoakes <lorenzo.stoakes@oracle.com> wrote:
> >
> > > > Which looked like someone else (now Cc'd on this thread) took it public,
>
> (I didn't know of the tab discussion)
Well, you were not there ;-)
> > I guess a statement in submitting-patches.rst would suffice, or should it
> > be a separate standalone document?
>
> If it's separate I think it needs to have a link from submitting-patches.rst
> to get people to read it.
>
> To summarise some other things that came up between the threads:
> a) I think there should be a standard syntax for stating it is
> AI written; I'd suggested using a new tag, but others were
> arguing on the side of reusing existing tags, which seems OK
> if it is done in a standard way and doesn't confuse existing tools.
Right. So I believe those that did not want the tag, wanted the statement
to be under the "---" so that it will not get into the git log. I prefer
the tag, but I'll be OK with the comment below the "---" as long as it is
clearly stated that the code was generated by AI.
>
> b) There's a whole spectrum of:
> i) AI wrote the whole patch based on a vague requirement
> ii) AI is in the editor and tab completes stuff
> iii) AI suggests fixes/changes
> which do you care about?
Yes, this is one of the controversial issues with having a policy. How much
does AI have to help you before you must disclose it. I would say basic
completions shouldn't be an issue. I've had editors where I type "for" it
then fills in "for (int i = 0; ; i++)". Is that AI? I don't think so.
I'm more concern where you use AI to come up with an algorith. "Hey AI,
sort this array with a quick-sort routine". And it does so. That should be
denoted in the change log. Either above or below the '---'.
>
> c) But then once you get stuff suggesting fixes/changes people were
> wondering if you should specify other non-AI tools as well.
> That might help reviewers who get bombed by a million patches
> from some conventional tool.
Fixes and changes I don't think require disclosure as long as the human
looks at that code and figures out that the code needs to change. Now if
the AI does the fix for you, as in makes the patch, then yeah, you should
disclose it. But if you manual make the patch after looking at what AI
pointed you to, then it should be fine.
>
> d) Either way there needs to be emphasis that the 'Signed-off-by'
> is a human declaring it's all legal and checked.
That should go without saying.
-- Steve
next prev parent reply other threads:[~2025-07-30 17:12 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 19:57 [PATCH 0/4] Add agent coding assistant configuration to Linux kernel Sasha Levin
2025-07-27 19:57 ` [PATCH 1/4] agents: add unified agent coding assistant configuration Sasha Levin
2025-07-28 2:37 ` Kees Cook
2025-07-28 4:43 ` Sasha Levin
2025-07-28 5:16 ` Kees Cook
2025-07-28 5:39 ` Sasha Levin
2025-07-30 22:06 ` Kevin Hilman
2025-07-30 23:47 ` Sasha Levin
2025-08-01 20:53 ` Rob Herring
2025-08-08 18:07 ` Kevin Hilman
2025-07-27 19:58 ` [PATCH 2/4] agents: add core development references Sasha Levin
2025-07-28 2:39 ` Kees Cook
2025-07-28 5:00 ` Sasha Levin
2025-07-28 5:10 ` Kees Cook
2025-07-28 5:59 ` Sasha Levin
2025-07-28 6:18 ` Kees Cook
2025-07-28 12:35 ` Sasha Levin
2025-07-30 16:25 ` Sasha Levin
2025-07-30 17:35 ` Al Viro
2025-07-30 18:29 ` Sasha Levin
2025-07-30 18:18 ` Matthew Wilcox
2025-07-30 18:41 ` Sasha Levin
2025-07-28 4:24 ` Greg KH
2025-07-28 4:52 ` Sasha Levin
2025-07-28 5:02 ` Kees Cook
2025-07-27 19:58 ` [PATCH 3/4] agents: add coding style documentation and rules Sasha Levin
2025-07-28 2:40 ` Kees Cook
2025-07-28 5:10 ` Sasha Levin
2025-07-28 5:21 ` Kees Cook
2025-07-28 6:03 ` Sasha Levin
2025-07-30 9:31 ` Krzysztof Kozlowski
2025-07-30 14:48 ` Jakub Kicinski
2025-07-30 15:10 ` Steven Rostedt
2025-07-27 19:58 ` [PATCH 4/4] agents: add legal requirements and agent attribution guidelines Sasha Levin
2025-07-28 2:43 ` Kees Cook
2025-08-05 22:08 ` Jeff Johnson
2025-08-05 23:11 ` Laurent Pinchart
2025-08-05 23:33 ` Sasha Levin
2025-08-06 14:12 ` Konstantin Ryabitsev
2025-08-06 21:53 ` Sasha Levin
2025-07-28 7:58 ` [PATCH 0/4] Add agent coding assistant configuration to Linux kernel Vlastimil Babka
2025-07-28 9:27 ` David Hildenbrand
2025-07-28 10:37 ` Greg KH
2025-07-28 10:47 ` David Hildenbrand
2025-07-28 13:05 ` Sasha Levin
2025-08-04 9:23 ` Michal Hocko
2025-08-04 9:41 ` Michal Hocko
2025-08-04 13:25 ` Sasha Levin
2025-08-04 22:03 ` Jiri Kosina
2025-08-04 22:14 ` Steven Rostedt
2025-08-04 22:30 ` Jiri Kosina
2025-08-04 22:53 ` dan.j.williams
2025-08-04 23:30 ` Sasha Levin
2025-08-04 23:39 ` Laurent Pinchart
2025-08-05 13:29 ` Steven Rostedt
2025-07-28 11:57 ` Sasha Levin
2025-07-28 8:42 ` Lorenzo Stoakes
2025-07-28 10:35 ` Greg KH
2025-07-28 10:52 ` Lorenzo Stoakes
2025-07-28 12:45 ` Sasha Levin
2025-07-28 13:13 ` Lorenzo Stoakes
2025-07-28 13:23 ` Sasha Levin
2025-07-28 13:28 ` Lorenzo Stoakes
2025-07-30 15:27 ` Steven Rostedt
2025-07-30 15:34 ` Lorenzo Stoakes
2025-07-30 16:18 ` Steven Rostedt
2025-07-30 16:33 ` Mauro Carvalho Chehab
2025-07-30 16:36 ` Sasha Levin
2025-07-30 16:59 ` Lorenzo Stoakes
2025-07-30 17:12 ` Sasha Levin
2025-07-30 17:23 ` Lorenzo Stoakes
2025-07-30 17:32 ` Steven Rostedt
2025-07-30 18:03 ` Sasha Levin
2025-07-30 18:18 ` Lorenzo Stoakes
2025-07-30 18:04 ` Lorenzo Stoakes
2025-07-30 19:16 ` Mark Brown
2025-07-30 17:25 ` Steven Rostedt
2025-07-30 17:34 ` Mark Brown
2025-07-30 17:36 ` Kees Cook
2025-08-04 10:20 ` Jiri Kosina
2025-07-30 17:05 ` Steven Rostedt
2025-07-30 17:46 ` Sasha Levin
2025-07-30 17:59 ` Al Viro
2025-07-30 18:10 ` Sasha Levin
2025-07-30 18:24 ` Lorenzo Stoakes
2025-07-30 18:59 ` Sasha Levin
2025-07-30 19:10 ` Theodore Ts'o
2025-07-30 19:40 ` Steven Rostedt
2025-07-30 19:51 ` Al Viro
2025-07-30 19:27 ` Steven Rostedt
2025-07-31 0:02 ` Mauro Carvalho Chehab
2025-07-30 16:40 ` Dr. David Alan Gilbert
2025-07-30 17:10 ` Lorenzo Stoakes
2025-07-30 17:20 ` Steven Rostedt
2025-07-30 17:33 ` Lorenzo Stoakes
2025-07-30 17:12 ` Steven Rostedt [this message]
2025-07-30 17:39 ` Dr. David Alan Gilbert
2025-07-30 17:51 ` Kees Cook
2025-07-30 16:58 ` Lorenzo Stoakes
2025-07-28 10:56 ` Laurent Pinchart
2025-08-12 18:13 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730131253.48f5b08d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=greg@kroah.com \
--cc=josh@joshtriplett.org \
--cc=kees@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=sashal@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).