linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>,
	dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
	joe@perches.com, corbet@lwn.net, apw@canonical.com,
	skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH] checkpatch: validate commit tag ordering
Date: Sat, 2 Aug 2025 12:12:00 +0200	[thread overview]
Message-ID: <20250802121200.665ea309@foz.lan> (raw)
In-Reply-To: <3e9106d35d41a044adeadffeea32fa096c9e1370@intel.com>

Em Fri, 01 Aug 2025 10:55:55 +0300
Jani Nikula <jani.nikula@intel.com> escreveu:

> On Thu, 31 Jul 2025, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On 31/07/2025 13:55, Geert Uytterhoeven wrote:  
> >> B4 does not follow the proper order:  
> >
> > There is no "proper order" in terms of absolute facts.  
> 
> Let's just decide whatever order b4 uses *is* the proper order, and save
> ourselves endless hours of debating! :p

I don't think it makes sense to have a "proper order" verified on
checkpatch, as some tags may appear on different places.

For instance, the custody chain was designed to have SoBs appearing
in different places:

- author(s) SoB together co-developed-by are usually the first ones;
- then patches may have been reviewed, tested, acked or passed on some
  other trees, gaining tags like tested-by, R-B, A-B, SoB, Cc;
- the subsystem maintainer will add his SoB in the end.

non-custody chain tags, like fixes, closes, reported-by...
usually comes first, but I don't think we need to enforce an specific
order.

Link, for instance, could be used on different places, with different
purposes.

At least for me, the only part that shall really follow a proper
order is the custody chain: It has to follow how the patch was handled,
from the authors at the top up to the maintainers at the bottom.

Thanks,
Mauro

  reply	other threads:[~2025-08-02 10:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  7:20 [PATCH] checkpatch: validate commit tag ordering Hendrik Hamerlinck
2025-07-24 15:04 ` Akira Yokosawa
2025-07-24 19:10 ` Jeff Johnson
2025-07-24 19:43 ` Konstantin Ryabitsev
2025-07-25  8:42 ` Krzysztof Kozlowski
2025-07-31 11:55   ` Geert Uytterhoeven
2025-07-31 12:46     ` Krzysztof Kozlowski
2025-08-01  7:55       ` Jani Nikula
2025-08-02 10:12         ` Mauro Carvalho Chehab [this message]
2025-08-02 16:26           ` Konstantin Ryabitsev
2025-07-26  7:34 ` Hendrik Hamerlinck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250802121200.665ea309@foz.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=apw@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hendrik.hamerlinck@hammernet.be \
    --cc=jani.nikula@intel.com \
    --cc=joe@perches.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=krzk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).