linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Haoyang LIU <tttturtleruss@gmail.com>,
	Dongliang Mu <dzm91@hust.edu.cn>,
	Yanteng Si <si.yanteng@linux.dev>, Alex Shi <alexs@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	hust-os-kernel-patches@googlegroups.com,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH V2] scripts/checktransupdate.py: add support for scanning directory
Date: Mon, 11 Aug 2025 14:24:46 -0700	[thread overview]
Message-ID: <20250811212446.GA924610@ax162> (raw)
In-Reply-To: <20250811170050.94997-1-tttturtleruss@gmail.com>

Hi Haoyang,

On Tue, Aug 12, 2025 at 01:00:50AM +0800, Haoyang LIU wrote:
> Origin script can only accept a file as parameter, this commit enables
> it to scan a directory.
> 
> Usage example:
> ./scripts/checktransupdate.py Documentation/translations/zh_CN/dev-tools
> 
> Signed-off-by: Haoyang LIU <tttturtleruss@gmail.com>
> ---
> 
> V1 -> V2: remove the fix of missing "f" in f-string and make it a new patch
> 
>  scripts/checktransupdate.py | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

Thanks for the update. While this seems reasonable to me from a purely
surface level glance over the actual Python, I have added the
Documentation folks that Dongliang added from the previous thread, who
really own and maintain this file (the original patch is at [1]). Please
include them in future revisions should they be necessary. It would
probably be good for something like this to be applied?

diff --git a/MAINTAINERS b/MAINTAINERS
index fe168477caa4..b7e3a8c8832e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7302,6 +7302,7 @@ P:	Documentation/doc-guide/maintainer-profile.rst
 T:	git git://git.lwn.net/linux.git docs-next
 F:	Documentation/
 F:	scripts/check-variable-fonts.sh
+F:	scripts/checktransupdate.py
 F:	scripts/documentation-file-ref-check
 F:	scripts/get_abi.py
 F:	scripts/kernel-doc*

[1]: https://lore.kernel.org/20250811170050.94997-1-tttturtleruss@gmail.com/

Cheers,
Nathan

       reply	other threads:[~2025-08-11 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250811170050.94997-1-tttturtleruss@gmail.com>
2025-08-11 21:24 ` Nathan Chancellor [this message]
2025-08-12  5:11   ` [PATCH V2] scripts/checktransupdate.py: add support for scanning directory Dongliang Mu
2025-08-12 10:09   ` Haoyang LIU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250811212446.GA924610@ax162 \
    --to=nathan@kernel.org \
    --cc=alexs@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dzm91@hust.edu.cn \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=justinstitt@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=si.yanteng@linux.dev \
    --cc=tttturtleruss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).