From: Jakub Kicinski <kuba@kernel.org>
To: Shahar Shitrit <shshitrit@nvidia.com>
Cc: Tariq Toukan <tariqt@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Jiri Pirko <jiri@resnulli.us>, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Donald Hunter <donald.hunter@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Brett Creeley <brett.creeley@amd.com>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Cai Huoqing <cai.huoqing@linux.dev>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, Mark Bloch <mbloch@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Manish Chopra <manishc@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-rdma@vger.kernel.org, Gal Pressman <gal@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next V3 4/5] devlink: Make health reporter error burst period configurable
Date: Mon, 18 Aug 2025 08:45:52 -0700 [thread overview]
Message-ID: <20250818084552.1d182f31@kernel.org> (raw)
In-Reply-To: <016a3fed-2f4b-4721-b92c-cf00cd5f3125@nvidia.com>
On Sun, 17 Aug 2025 19:08:47 +0300 Shahar Shitrit wrote:
> On 15/08/2025 22:26, Jakub Kicinski wrote:
> > On Wed, 13 Aug 2025 21:55:48 +0300 Tariq Toukan wrote:
> >> diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
> >> index bb87111d5e16..0e81640dd3b2 100644
> >> --- a/Documentation/netlink/specs/devlink.yaml
> >> +++ b/Documentation/netlink/specs/devlink.yaml
> >> @@ -853,6 +853,9 @@ attribute-sets:
> >> type: nest
> >> multi-attr: true
> >> nested-attributes: dl-rate-tc-bws
> >> + -
> >> + name: health-reporter-error-burst-period
> >
> > the "graceful-period" does not have the word "error"
> > in it. Why is it necessary to include it in this parameter?
> > What else would be bursting in an error reporter if not errors?
>
> I see. Would you suggest renaming it to "burst period" through the
> entire series?
> for example in devlink.h:
> default_error_burst_period --> default_burst_period
Yes, AFAICT it won't result in any loss of clarity.
next prev parent reply other threads:[~2025-08-18 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 18:55 [PATCH net-next V3 0/5] Expose error burst period for devlink health reporter Tariq Toukan
2025-08-13 18:55 ` [PATCH net-next V3 1/5] devlink: Move graceful period parameter to reporter ops Tariq Toukan
2025-08-15 19:19 ` Jakub Kicinski
2025-08-13 18:55 ` [PATCH net-next V3 2/5] devlink: Move health reporter recovery abort logic to a separate function Tariq Toukan
2025-08-13 18:55 ` [PATCH net-next V3 3/5] devlink: Introduce error burst period for health reporter Tariq Toukan
2025-08-15 19:23 ` Jakub Kicinski
2025-08-13 18:55 ` [PATCH net-next V3 4/5] devlink: Make health reporter error burst period configurable Tariq Toukan
2025-08-15 19:26 ` Jakub Kicinski
2025-08-17 16:08 ` Shahar Shitrit
2025-08-18 15:45 ` Jakub Kicinski [this message]
2025-08-13 18:55 ` [PATCH net-next V3 5/5] net/mlx5e: Set default error burst period for TX and RX reporters Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818084552.1d182f31@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=brett.creeley@amd.com \
--cc=cai.huoqing@linux.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=gal@nvidia.com \
--cc=hkelam@marvell.com \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jerinj@marvell.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=lcherian@marvell.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=mbloch@nvidia.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=shshitrit@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).