From: Jakub Kicinski <kuba@kernel.org>
To: Naveen Mamindlapalli <naveenm@marvell.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<horms@kernel.org>, <corbet@lwn.net>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] docs: networking: clarify expectation of persistent stats
Date: Tue, 26 Aug 2025 17:44:57 -0700 [thread overview]
Message-ID: <20250826174457.56705b46@kernel.org> (raw)
In-Reply-To: <20250825134755.3468861-1-naveenm@marvell.com>
On Mon, 25 Aug 2025 19:17:55 +0530 Naveen Mamindlapalli wrote:
> -Statistics must persist across routine operations like bringing the interface
> -down and up.
> +Statistics are expected to persist across routine operations like bringing the
Please don't weaken the requirement. The requirements is what it is.
> +interface down and up. This includes both standard interface statistics and
> +driver-defined statistics reported via `ethtool -S`.
Rest of the paragraph looks good, but I think the preferred form of
quotations is double back ticks? Most of this doc doesn't comply but
let's stick to double when adding new stuff.
> +However, this behavior is not always strictly followed, and some drivers do
> +reset these counters to zero when the device is closed and reopened. This can
> +lead to misinterpretation of network behavior by monitoring tools, such as
> +SNMP, that expect monotonically increasing counters.
> +
> +Driver authors are expected to preserve statistics across interface down/up
> +cycles to ensure consistent reporting and better integration with monitoring
> +tools that consume these statistics.
This feels like too many words. How about:
Note that the following legacy drivers do not comply with this requirement
and cannot be fixed without breaking existing users:
- driver1
- driver2
...
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-27 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 13:47 [PATCH net-next] docs: networking: clarify expectation of persistent stats Naveen Mamindlapalli
2025-08-27 0:44 ` Jakub Kicinski [this message]
2025-09-05 11:04 ` Naveen Mamindlapalli
2025-09-05 23:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826174457.56705b46@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).