* [PATCH] docs: driver-api pinctrl cleanup
@ 2025-08-27 5:43 Alex Tran
2025-08-27 7:03 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Alex Tran @ 2025-08-27 5:43 UTC (permalink / raw)
To: linus.walleij; +Cc: corbet, linux-gpio, linux-doc, linux-kernel, Alex Tran
Resource cleanup when using pinctrl.
Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
---
Documentation/driver-api/pin-control.rst | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/Documentation/driver-api/pin-control.rst b/Documentation/driver-api/pin-control.rst
index 27ea12363..281533c33 100644
--- a/Documentation/driver-api/pin-control.rst
+++ b/Documentation/driver-api/pin-control.rst
@@ -1202,22 +1202,24 @@ default state like this:
{
/* Allocate a state holder named "foo" etc */
struct foo_state *foo = ...;
+ int ret;
foo->p = devm_pinctrl_get(&device);
if (IS_ERR(foo->p)) {
- /* FIXME: clean up "foo" here */
- return PTR_ERR(foo->p);
+ ret = PTR_ERR(foo->p);
+ foo->p = NULL;
+ return ret;
}
foo->s = pinctrl_lookup_state(foo->p, PINCTRL_STATE_DEFAULT);
if (IS_ERR(foo->s)) {
- /* FIXME: clean up "foo" here */
+ devm_pinctrl_put(foo->p);
return PTR_ERR(foo->s);
}
ret = pinctrl_select_state(foo->p, foo->s);
if (ret < 0) {
- /* FIXME: clean up "foo" here */
+ devm_pinctrl_put(foo->p);
return ret;
}
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] docs: driver-api pinctrl cleanup
2025-08-27 5:43 [PATCH] docs: driver-api pinctrl cleanup Alex Tran
@ 2025-08-27 7:03 ` Jonathan Corbet
2025-08-27 7:27 ` Alex Tran
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2025-08-27 7:03 UTC (permalink / raw)
To: Alex Tran, linus.walleij; +Cc: linux-gpio, linux-doc, linux-kernel, Alex Tran
Alex Tran <alex.t.tran@gmail.com> writes:
> Resource cleanup when using pinctrl.
>
> Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> ---
> Documentation/driver-api/pin-control.rst | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
I hate to complain but ... this patch really needs a changelog saying
what you are changing and why.
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: driver-api pinctrl cleanup
2025-08-27 7:03 ` Jonathan Corbet
@ 2025-08-27 7:27 ` Alex Tran
0 siblings, 0 replies; 3+ messages in thread
From: Alex Tran @ 2025-08-27 7:27 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: linus.walleij, linux-gpio, linux-doc, linux-kernel
On Wed, Aug 27, 2025 at 12:03 AM Jonathan Corbet <corbet@lwn.net> wrote:
>
> Alex Tran <alex.t.tran@gmail.com> writes:
>
> > Resource cleanup when using pinctrl.
> >
> > Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
> > ---
> > Documentation/driver-api/pin-control.rst | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
>
> I hate to complain but ... this patch really needs a changelog saying
> what you are changing and why.
>
> Thanks,
>
> jon
Sorry about that. I'll send in a patch v2 with a better description
and a changelog.
--
Alex Tran
alex.t.tran@gmail.com | 408-406-2417
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-27 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-27 5:43 [PATCH] docs: driver-api pinctrl cleanup Alex Tran
2025-08-27 7:03 ` Jonathan Corbet
2025-08-27 7:27 ` Alex Tran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).