From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: jdelvare@suse.com, linux@roeck-us.net, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net,
wenliang202407@163.com, jre@pengutronix.de
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v3 2/4] hwmon: (ina238) Correctly clamp temperature
Date: Fri, 29 Aug 2025 15:05:10 +1200 [thread overview]
Message-ID: <20250829030512.1179998-3-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20250829030512.1179998-1-chris.packham@alliedtelesis.co.nz>
ina238_write_temp() was attempting to clamp the user input but was
throwing away the result. Ensure that we clamp the value to the
appropriate range before it is converted into a register value.
Fixes: 0d9f596b1fe3 ("hwmon: (ina238) Modify the calculation formula to adapt to different chips")
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Notes:
Changes in v3:
- New. Split off bugfix from main patch
drivers/hwmon/ina238.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/ina238.c b/drivers/hwmon/ina238.c
index 5a394eeff676..4d3dc018ead9 100644
--- a/drivers/hwmon/ina238.c
+++ b/drivers/hwmon/ina238.c
@@ -572,7 +572,7 @@ static int ina238_write_temp(struct device *dev, u32 attr, long val)
return -EOPNOTSUPP;
/* Signed */
- regval = clamp_val(val, -40000, 125000);
+ val = clamp_val(val, -40000, 125000);
regval = div_s64(val * 10000, data->config->temp_lsb) << data->config->temp_shift;
regval = clamp_val(regval, S16_MIN, S16_MAX) & (0xffff << data->config->temp_shift);
--
2.51.0
next prev parent reply other threads:[~2025-08-29 3:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 3:05 [PATCH v3 0/4] hwmon: Add support for INA780 Chris Packham
2025-08-29 3:05 ` [PATCH v3 1/4] dt-bindings: hwmon: ti,ina2xx: Add INA780 device Chris Packham
2025-08-31 22:35 ` Guenter Roeck
2025-08-29 3:05 ` Chris Packham [this message]
2025-08-29 9:55 ` [PATCH v3 2/4] hwmon: (ina238) Correctly clamp temperature Guenter Roeck
2025-08-31 21:12 ` Chris Packham
2025-08-31 22:09 ` Guenter Roeck
2025-08-31 22:34 ` Guenter Roeck
2025-08-29 3:05 ` [PATCH v3 3/4] hwmon: (ina238) Add ina238_config fields Chris Packham
2025-08-29 15:56 ` Guenter Roeck
2025-08-29 3:05 ` [PATCH v3 4/4] hwmon: (ina238) Add support for INA780 Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829030512.1179998-3-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jre@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).