From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-doc@vger.kernel.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v7 06/12] arm64/boot: Enable EL2 requirements for SPE_FEAT_FDS
Date: Mon, 1 Sep 2025 11:19:04 +0100 [thread overview]
Message-ID: <20250901101904.GK745921@e132581.arm.com> (raw)
In-Reply-To: <20250814-james-perf-feat_spe_eft-v7-6-6a743f7fa259@linaro.org>
On Thu, Aug 14, 2025 at 10:25:28AM +0100, James Clark wrote:
[...]
> diff --git a/arch/arm64/include/asm/el2_setup.h b/arch/arm64/include/asm/el2_setup.h
> index 3a4ca7f9acfb..a0361ddcdca4 100644
> --- a/arch/arm64/include/asm/el2_setup.h
> +++ b/arch/arm64/include/asm/el2_setup.h
> @@ -392,6 +392,17 @@
> orr x0, x0, #HDFGRTR2_EL2_nPMICFILTR_EL0
> orr x0, x0, #HDFGRTR2_EL2_nPMUACR_EL1
> .Lskip_pmuv3p9_\@:
> + /* If SPE is implemented, */
> + __spe_vers_imp .Lskip_spefds_\@, ID_AA64DFR0_EL1_PMSVer_IMP, x1
> + /* we can read PMSIDR and */
> + mrs_s x1, SYS_PMSIDR_EL1
> + and x1, x1, #PMSIDR_EL1_FDS
> + /* if FEAT_SPE_FDS is implemented, */
> + cbz x1, .Lskip_spefds_\@
> + /* disable traps to PMSDSFR. */
Nitpick: the comment is a bit ambiguous for me. Would it be better to
say "disable traps to EL2" or "set the PMSDSFR bit to disable trapping" ?
Otherwise, LGTM:
Reviewed-by: Leo Yan <leo.yan@arm.com>
> + orr x0, x0, #HDFGRTR2_EL2_nPMSDSFR_EL1
> +
> +.Lskip_spefds_\@:
> msr_s SYS_HDFGRTR2_EL2, x0
> msr_s SYS_HDFGWTR2_EL2, x0
> msr_s SYS_HFGRTR2_EL2, xzr
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-09-01 10:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 9:25 [PATCH v7 00/12] perf: arm_spe: Armv8.8 SPE features James Clark
2025-08-14 9:25 ` [PATCH v7 01/12] arm64: sysreg: Add new PMSFCR_EL1 fields and PMSDSFR_EL1 register James Clark
2025-08-14 9:25 ` [PATCH v7 02/12] perf: arm_spe: Support FEAT_SPEv1p4 filters James Clark
2025-08-14 9:25 ` [PATCH v7 03/12] perf: arm_spe: Expose event filter James Clark
2025-08-14 9:25 ` [PATCH v7 04/12] perf: arm_spe: Add support for FEAT_SPE_EFT extended filtering James Clark
2025-08-14 9:25 ` [PATCH v7 05/12] arm64/boot: Factor out a macro to check SPE version James Clark
2025-09-01 10:05 ` Leo Yan
2025-09-01 12:22 ` James Clark
2025-08-14 9:25 ` [PATCH v7 06/12] arm64/boot: Enable EL2 requirements for SPE_FEAT_FDS James Clark
2025-09-01 10:19 ` Leo Yan [this message]
2025-09-01 12:21 ` James Clark
2025-08-14 9:25 ` [PATCH v7 07/12] KVM: arm64: Add trap configs for PMSDSFR_EL1 James Clark
2025-08-14 9:25 ` [PATCH v7 08/12] perf: Add perf_event_attr::config4 James Clark
2025-08-18 15:51 ` Ian Rogers
2025-08-14 9:25 ` [PATCH v7 09/12] perf: arm_spe: Add support for filtering on data source James Clark
2025-09-01 10:27 ` Leo Yan
2025-08-14 9:25 ` [PATCH v7 10/12] tools headers UAPI: Sync linux/perf_event.h with the kernel sources James Clark
2025-08-14 9:25 ` [PATCH v7 11/12] perf tools: Add support for perf_event_attr::config4 James Clark
2025-08-14 9:25 ` [PATCH v7 12/12] perf docs: arm-spe: Document new SPE filtering features James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901101904.GK745921@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=joey.gouly@arm.com \
--cc=jolsa@kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).