From: Jakub Kicinski <kuba@kernel.org>
To: Fan Gong <gongfan1@huawei.com>
Cc: Zhu Yikai <zhuyikai1@h-partners.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>, <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <helgaas@kernel.org>, luosifu <luosifu@huawei.com>,
Xin Guo <guoxin09@huawei.com>,
Shen Chenyang <shenchenyang1@hisilicon.com>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>,
Shi Jing <shijing34@huawei.com>,
Meny Yossefi <meny.yossefi@huawei.com>,
Gur Stavi <gur.stavi@huawei.com>, Lee Trager <lee@trager.us>,
Michael Ellerman <mpe@ellerman.id.au>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Suman Ghosh <sumang@marvell.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Joe Damato <jdamato@fastly.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH net-next v03 02/14] hinic3: HW management interfaces
Date: Tue, 2 Sep 2025 18:08:43 -0700 [thread overview]
Message-ID: <20250902180843.5ba05bf2@kernel.org> (raw)
In-Reply-To: <07e099c1395b725d880900550eaceb44a189d901.1756524443.git.zhuyikai1@h-partners.com>
On Sat, 30 Aug 2025 16:08:41 +0800 Fan Gong wrote:
> +int hinic3_init_cfg_mgmt(struct hinic3_hwdev *hwdev)
> +{
> + struct hinic3_cfg_mgmt_info *cfg_mgmt;
> + int err;
> +
> + if (!hwdev->hwif->attr.num_ceqs) {
> + dev_err(hwdev->dev, "Ceq num cfg in fw is zero\n");
> + return -EINVAL;
> + }
The input checking in most of the functions looks like defensive
programming. The values should be checked when they are set / loaded,
not on input to random functions. Defensive programming should be
avoided in the kernel (meaning, unless you can point out actual callers
which need the validation, and can explain why doing the check in the
callee rather than the caller is cleaner -- the check should be in the
caller).
next prev parent reply other threads:[~2025-09-03 1:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 8:08 [PATCH net-next v03 00/14] net: hinic3: Add a driver for Huawei 3rd gen NIC - sw and hw initialization Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 01/14] hinic3: HW initialization Fan Gong
2025-09-03 1:06 ` Jakub Kicinski
2025-08-30 8:08 ` [PATCH net-next v03 02/14] hinic3: HW management interfaces Fan Gong
2025-09-03 1:06 ` Jakub Kicinski
2025-09-03 1:08 ` Jakub Kicinski [this message]
2025-09-03 1:09 ` Jakub Kicinski
2025-08-30 8:08 ` [PATCH net-next v03 03/14] hinic3: HW common function initialization Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 04/14] hinic3: HW capability initialization Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 05/14] hinic3: Command Queue flush interfaces Fan Gong
2025-09-03 1:15 ` Jakub Kicinski
2025-08-30 8:08 ` [PATCH net-next v03 06/14] hinic3: Nic_io initialization Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 07/14] hinic3: Queue pair endianness improvements Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 08/14] hinic3: Queue pair resource initialization Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 09/14] hinic3: Queue pair context initialization Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 10/14] hinic3: Tx & Rx configuration Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 11/14] hinic3: Add Rss function Fan Gong
2025-09-03 1:28 ` Jakub Kicinski
2025-08-30 8:08 ` [PATCH net-next v03 12/14] hinic3: Add port management Fan Gong
2025-09-03 1:30 ` Jakub Kicinski
2025-08-30 8:08 ` [PATCH net-next v03 13/14] hinic3: Fix missing napi->dev in netif_queue_set_napi Fan Gong
2025-08-30 8:08 ` [PATCH net-next v03 14/14] hinic3: Fix code style (Missing a blank line before return) Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902180843.5ba05bf2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luosifu@huawei.com \
--cc=meny.yossefi@huawei.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=sumang@marvell.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
--cc=zhuyikai1@h-partners.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).