From: "Darrick J. Wong" <djwong@kernel.org>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: brauner@kernel.org, miklos@szeredi.hu, hch@infradead.org,
linux-fsdevel@vger.kernel.org, kernel-team@meta.com,
linux-xfs@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 09/16] iomap: rename iomap_readpage_ctx struct to iomap_readfolio_ctx
Date: Wed, 3 Sep 2025 13:44:24 -0700 [thread overview]
Message-ID: <20250903204424.GP1587915@frogsfrogsfrogs> (raw)
In-Reply-To: <20250829235627.4053234-10-joannelkoong@gmail.com>
On Fri, Aug 29, 2025 at 04:56:20PM -0700, Joanne Koong wrote:
> ->readpage was deprecated and reads are now on folios.
>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
For this and the previous rename patches,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/iomap/buffered-io.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 743112c7f8e6..a3a9b6146c2f 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -317,7 +317,7 @@ static int iomap_read_inline_data(const struct iomap_iter *iter,
> return 0;
> }
>
> -struct iomap_readpage_ctx {
> +struct iomap_readfolio_ctx {
> struct folio *cur_folio;
> bool folio_unlocked;
> struct readahead_control *rac;
> @@ -357,7 +357,7 @@ static void iomap_read_end_io(struct bio *bio)
> }
>
> static void iomap_read_folio_range_async(struct iomap_iter *iter,
> - struct iomap_readpage_ctx *ctx, loff_t pos, size_t plen)
> + struct iomap_readfolio_ctx *ctx, loff_t pos, size_t plen)
> {
> struct folio *folio = ctx->cur_folio;
> const struct iomap *iomap = &iter->iomap;
> @@ -426,7 +426,7 @@ static void iomap_readfolio_submit(const struct iomap_iter *iter)
> }
> #else
> static void iomap_read_folio_range_async(struct iomap_iter *iter,
> - struct iomap_readpage_ctx *ctx, loff_t pos, size_t len)
> + struct iomap_readfolio_ctx *ctx, loff_t pos, size_t len)
> {
> WARN_ON_ONCE(1);
> }
> @@ -445,7 +445,7 @@ static void iomap_readfolio_submit(const struct iomap_iter *iter)
> #endif /* CONFIG_BLOCK */
>
> static int iomap_readfolio_iter(struct iomap_iter *iter,
> - struct iomap_readpage_ctx *ctx)
> + struct iomap_readfolio_ctx *ctx)
> {
> const struct iomap *iomap = &iter->iomap;
> loff_t pos = iter->pos;
> @@ -491,7 +491,7 @@ static int iomap_readfolio_iter(struct iomap_iter *iter,
> }
>
> static void iomap_readfolio_complete(const struct iomap_iter *iter,
> - const struct iomap_readpage_ctx *ctx)
> + const struct iomap_readfolio_ctx *ctx)
> {
> iomap_readfolio_submit(iter);
>
> @@ -506,7 +506,7 @@ int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops)
> .pos = folio_pos(folio),
> .len = folio_size(folio),
> };
> - struct iomap_readpage_ctx ctx = {
> + struct iomap_readfolio_ctx ctx = {
> .cur_folio = folio,
> };
> int ret;
> @@ -523,7 +523,7 @@ int iomap_read_folio(struct folio *folio, const struct iomap_ops *ops)
> EXPORT_SYMBOL_GPL(iomap_read_folio);
>
> static int iomap_readahead_iter(struct iomap_iter *iter,
> - struct iomap_readpage_ctx *ctx)
> + struct iomap_readfolio_ctx *ctx)
> {
> int ret;
>
> @@ -567,7 +567,7 @@ void iomap_readahead(struct readahead_control *rac, const struct iomap_ops *ops)
> .pos = readahead_pos(rac),
> .len = readahead_length(rac),
> };
> - struct iomap_readpage_ctx ctx = {
> + struct iomap_readfolio_ctx ctx = {
> .rac = rac,
> };
>
> --
> 2.47.3
>
>
next prev parent reply other threads:[~2025-09-03 20:44 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 23:56 [PATCH v1 00/16] fuse: use iomap for buffered reads + readahead Joanne Koong
2025-08-29 23:56 ` [PATCH v1 01/16] iomap: move async bio read logic into helper function Joanne Koong
2025-09-03 20:16 ` Darrick J. Wong
2025-09-04 6:00 ` Christoph Hellwig
2025-09-04 21:44 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 02/16] iomap: rename cur_folio_in_bio to folio_unlocked Joanne Koong
2025-09-03 20:26 ` [PATCH v1 02/16] iomap: rename cur_folio_in_bio to folio_unlockedOM Darrick J. Wong
2025-09-04 6:03 ` Christoph Hellwig
2025-09-04 22:06 ` Joanne Koong
2025-09-05 15:03 ` Darrick J. Wong
2025-08-29 23:56 ` [PATCH v1 03/16] iomap: refactor read/readahead completion Joanne Koong
2025-09-04 6:05 ` Christoph Hellwig
2025-09-04 23:16 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 04/16] iomap: use iomap_iter->private for stashing read/readahead bio Joanne Koong
2025-09-03 20:30 ` Darrick J. Wong
2025-09-04 6:07 ` Christoph Hellwig
2025-09-04 22:20 ` Joanne Koong
2025-09-04 23:15 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 05/16] iomap: propagate iomap_read_folio() error to caller Joanne Koong
2025-09-03 20:32 ` Darrick J. Wong
2025-09-04 6:09 ` Christoph Hellwig
2025-09-04 21:13 ` Matthew Wilcox
2025-09-22 16:49 ` Joanne Koong
2025-09-23 18:34 ` Darrick J. Wong
2025-09-24 23:12 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 06/16] iomap: move read/readahead logic out of CONFIG_BLOCK guard Joanne Koong
2025-08-29 23:56 ` [PATCH v1 07/16] iomap: iterate through entire folio in iomap_readpage_iter() Joanne Koong
2025-09-03 20:43 ` Darrick J. Wong
2025-09-04 22:37 ` Joanne Koong
2025-09-04 6:14 ` Christoph Hellwig
2025-09-04 22:45 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 08/16] iomap: rename iomap_readpage_iter() to iomap_readfolio_iter() Joanne Koong
2025-09-04 6:15 ` Christoph Hellwig
2025-09-04 22:47 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 09/16] iomap: rename iomap_readpage_ctx struct to iomap_readfolio_ctx Joanne Koong
2025-09-03 20:44 ` Darrick J. Wong [this message]
2025-08-29 23:56 ` [PATCH v1 10/16] iomap: add iomap_start_folio_read() helper Joanne Koong
2025-09-03 20:52 ` Darrick J. Wong
2025-08-29 23:56 ` [PATCH v1 11/16] iomap: make start folio read and finish folio read public APIs Joanne Koong
2025-09-03 20:53 ` Darrick J. Wong
2025-09-04 6:15 ` Christoph Hellwig
2025-08-29 23:56 ` [PATCH v1 12/16] iomap: add iomap_read_ops for read and readahead Joanne Koong
2025-09-03 21:08 ` Darrick J. Wong
2025-09-04 20:58 ` Joanne Koong
2025-09-04 6:21 ` Christoph Hellwig
2025-09-04 21:38 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 13/16] iomap: add a private arg " Joanne Koong
2025-08-30 1:54 ` Gao Xiang
2025-09-02 21:24 ` Joanne Koong
2025-09-03 1:55 ` Gao Xiang
2025-09-04 23:29 ` Joanne Koong
2025-09-05 2:21 ` Gao Xiang
2025-09-05 15:21 ` Darrick J. Wong
2025-09-08 6:56 ` Gao Xiang
2025-09-03 21:11 ` Darrick J. Wong
2025-08-29 23:56 ` [PATCH v1 14/16] fuse: use iomap for read_folio Joanne Koong
2025-09-03 21:13 ` Darrick J. Wong
2025-08-29 23:56 ` [PATCH v1 15/16] fuse: use iomap for readahead Joanne Koong
2025-09-03 21:17 ` Darrick J. Wong
2025-09-04 19:40 ` Joanne Koong
2025-09-04 19:46 ` Joanne Koong
2025-08-29 23:56 ` [PATCH v1 16/16] fuse: remove fuse_readpages_end() null mapping check Joanne Koong
2025-09-02 9:21 ` Miklos Szeredi
2025-09-02 21:19 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903204424.GP1587915@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=brauner@kernel.org \
--cc=hch@infradead.org \
--cc=joannelkoong@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox