From: Jakub Kicinski <kuba@kernel.org>
To: Ivan Vecera <ivecera@redhat.com>
Cc: netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Subject: Re: [PATCH net-next v2] dpll: zl3073x: Allow to use custom phase measure averaging factor
Date: Tue, 16 Sep 2025 15:25:06 -0700 [thread overview]
Message-ID: <20250916152506.256ea653@kernel.org> (raw)
In-Reply-To: <FA93EFB9-954B-421E-97B2-AE9E0A0A4216@redhat.com>
On Tue, 16 Sep 2025 20:16:57 +0200 Ivan Vecera wrote:
> >> Add devlink device parameter phase_offset_avg_factor to allow a user
> >> set tune the averaging factor via devlink interface.
> >
> >Is averaging phase offset normal for DPLL devices?
>
> I don't know... I expect that DPLL chips support phase offset
> measurement but probably implementation specific.
Ack, I was hoping Arkadiusz and Vadim could comment what their DPLL
devices do.
> >If it is we should probably add this to the official API.
>
> The problem in case of this Microchip DPLL devices is that this
> parameter is per ASIC. It is common for all DPLL channels
> (devices) inside the chip. That's why I chose devlink.
>
> >If it isn't we should probably default to smallest possible history?
>
> Do you mean the default value?
Yes, but let's wait for others to chime in.
next prev parent reply other threads:[~2025-09-16 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 7:23 [PATCH net-next v2] dpll: zl3073x: Allow to use custom phase measure averaging factor Ivan Vecera
2025-09-15 23:46 ` Jakub Kicinski
2025-09-16 18:16 ` Ivan Vecera
2025-09-16 22:25 ` Jakub Kicinski [this message]
2025-09-17 11:26 ` Kubalewski, Arkadiusz
2025-09-17 12:18 ` Ivan Vecera
2025-09-17 13:10 ` Kubalewski, Arkadiusz
2025-09-17 14:55 ` Ivan Vecera
2025-09-17 17:01 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916152506.256ea653@kernel.org \
--to=kuba@kernel.org \
--cc=Prathosh.Satish@microchip.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).