From: "Onur Özkan" <work@onurozkan.dev>
To: linux-kernel@vger.kernel.org
Cc: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com, corbet@lwn.net,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
"Onur Özkan" <work@onurozkan.dev>
Subject: [PATCH v2 1/2] checkpatch: detect unhandled placeholders in cover letters
Date: Wed, 17 Sep 2025 20:37:24 +0300 [thread overview]
Message-ID: <20250917173725.22547-2-work@onurozkan.dev> (raw)
In-Reply-To: <20250917173725.22547-1-work@onurozkan.dev>
Adds a new check PLACEHOLDER_USE to detect unhandled placeholders.
This prevents sending patch series with incomplete patches (mostly
in cover letters) containing auto generated subject or blurb lines.
These placeholders can be seen on mailing lists. With this change,
checkpatch will emit an error when such text is found.
Signed-off-by: Onur Özkan <work@onurozkan.dev>
---
scripts/checkpatch.pl | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e722dd6fa8ef..965faee71935 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3340,6 +3340,13 @@ sub process {
}
}
+# Check for auto-generated unhandled placeholder text (mostly for cover letters)
+ if (($in_commit_log || $in_header_lines) &&
+ $rawline =~ /(?:SUBJECT|BLURB) HERE/) {
+ ERROR("PLACEHOLDER_USE",
+ "Placeholder text detected\n" . $herecurr);
+ }
+
# Check for git id commit length and improperly formed commit descriptions
# A correctly formed commit description is:
# commit <SHA-1 hash length 12+ chars> ("Complete commit subject")
--
2.51.0
next prev parent reply other threads:[~2025-09-17 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 17:37 [PATCH v2 0/2] checkpatch: add new check PLACEHOLDER_USE Onur Özkan
2025-09-17 17:37 ` Onur Özkan [this message]
2025-09-17 17:37 ` [PATCH v2 2/2] checkpatch: document " Onur Özkan
2025-10-09 12:56 ` [PATCH v2 0/2] checkpatch: add " Onur Özkan
2025-10-09 20:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917173725.22547-2-work@onurozkan.dev \
--to=work@onurozkan.dev \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox