From: "Onur Özkan" <work@onurozkan.dev>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
rust-for-linux@vger.kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org, tmgross@umich.edu,
dakr@kernel.org, linux-kernel@vger.kernel.org,
acourbot@nvidia.com, airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, corbet@lwn.net, lyude@redhat.com,
linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/3] rust: xarray: abstract `xa_alloc_cyclic`
Date: Wed, 8 Oct 2025 08:26:49 +0300 [thread overview]
Message-ID: <20251008082649.1f9cacd0@nimda.home> (raw)
In-Reply-To: <CANiq72m8t2j3+XoELfYFG9ivymueOGdwpZnFhRVZ8f3Xw9ygiA@mail.gmail.com>
On Tue, 7 Oct 2025 19:28:31 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Tue, Oct 7, 2025 at 7:19 PM Onur Özkan <work@onurozkan.dev> wrote:
> >
> > Why do we not like to use the bindings type directly?
>
> For public APIs, we generally try to avoid exposing C types:
>
> https://docs.kernel.org/rust/general-information.html#abstractions-vs-bindings
>
> Sometimes it still makes sense, of course, e.g. a method may return
> an inner type so that it gets used by other abstractions to call into
> C. But generally we want to avoid exposing those for drivers and other
> abstractions wherever possible.
>
> Cheers,
> Miguel
Thank you for explaining it, I will drop the bindings type in the next
version.
Regards,
Onur
next prev parent reply other threads:[~2025-10-08 5:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 16:30 [PATCH 0/3] rust: xarray: abstract `xa_alloc` and `xa_alloc_cyclic` Onur Özkan
2025-10-06 16:30 ` [PATCH 1/3] rust: xarray: abstract `xa_alloc` Onur Özkan
2025-10-06 19:31 ` Benno Lossin
2025-10-07 10:58 ` Alice Ryhl
2025-10-08 10:18 ` Benno Lossin
2025-10-08 13:01 ` Alice Ryhl
2025-10-08 13:22 ` Onur Özkan
2025-10-08 16:01 ` Alice Ryhl
2025-10-06 23:09 ` Boqun Feng
2025-10-07 5:04 ` Onur Özkan
2025-10-06 16:30 ` [PATCH 2/3] rust: xarray: abstract `xa_alloc_cyclic` Onur Özkan
2025-10-07 10:56 ` Alice Ryhl
2025-10-07 12:31 ` Onur Özkan
2025-10-07 17:28 ` Miguel Ojeda
2025-10-08 5:26 ` Onur Özkan [this message]
2025-10-06 16:30 ` [PATCH 3/3] remove completed task from nova-core task list Onur Özkan
2025-10-07 11:01 ` [PATCH 0/3] rust: xarray: abstract `xa_alloc` and `xa_alloc_cyclic` Alice Ryhl
2025-10-07 12:37 ` Onur Özkan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008082649.1f9cacd0@nimda.home \
--to=work@onurozkan.dev \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).