[PATCH] leds: lp55xx_common: enable use without FW_LOADER_USER_HELPER

[PATCH] leds: lp55xx_common: enable use without FW_LOADER_USER_HELPER

[Sicelo A. Mhlongo]

Many distributions disable FW_LOADER_USER_HELPER, and this configuration
makes lp55xx LEDs completely unusable. Enable their use by only implying
the user helper, since the basic LEDs and the hardware patterns can be used
with only the sysfs interface.

Tested on Nokia N900 with LP5523.

Additionally do not refer to the sysfs interface as legacy anymore, since
it might be the only one available to users.

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 Documentation/leds/leds-lp5521.rst | 2 +-
 Documentation/leds/leds-lp5523.rst | 2 +-
 drivers/leds/Kconfig               | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/leds/leds-lp5521.rst b/Documentation/leds/leds-lp5521.rst
index 0432615b083d6..6888c5beceed8 100644
--- a/Documentation/leds/leds-lp5521.rst
+++ b/Documentation/leds/leds-lp5521.rst
@@ -22,7 +22,7 @@ More details of the instructions can be found from the public data sheet.
 LP5521 has the internal program memory for running various LED patterns.
 There are two ways to run LED patterns.
 
-1) Legacy interface - enginex_mode and enginex_load
+1) sysfs interface - enginex_mode and enginex_load
    Control interface for the engines:
 
    x is 1 .. 3
diff --git a/Documentation/leds/leds-lp5523.rst b/Documentation/leds/leds-lp5523.rst
index 7d7362a1dd575..d150bb7d7b703 100644
--- a/Documentation/leds/leds-lp5523.rst
+++ b/Documentation/leds/leds-lp5523.rst
@@ -35,7 +35,7 @@ If both fields are NULL, 'lp5523' is used by default.
 LP5523 has the internal program memory for running various LED patterns.
 There are two ways to run LED patterns.
 
-1) Legacy interface - enginex_mode, enginex_load and enginex_leds
+1) sysfs interface - enginex_mode, enginex_load and enginex_leds
 
   Control interface for the engines:
 
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 6e3dce7e35a49..3d1895ec38b2e 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -443,8 +443,8 @@ config LEDS_LP55XX_COMMON
 	depends on LEDS_CLASS_MULTICOLOR
 	depends on OF
 	depends on I2C
-	select FW_LOADER
-	select FW_LOADER_USER_HELPER
+	imply FW_LOADER
+	imply FW_LOADER_USER_HELPER
 	help
 	  This option supports common operations for LP5521/5523/55231/5562/5569/
 	  8501 devices.
-- 
2.51.0

Re: [PATCH] leds: lp55xx_common: enable use without FW_LOADER_USER_HELPER

[Lee Jones]

On Mon, 06 Oct 2025, Sicelo A. Mhlongo wrote:

> Many distributions disable FW_LOADER_USER_HELPER, and this configuration
> makes lp55xx LEDs completely unusable. Enable their use by only implying
> the user helper, since the basic LEDs and the hardware patterns can be used
> with only the sysfs interface.
> 
> Tested on Nokia N900 with LP5523.
> 
> Additionally do not refer to the sysfs interface as legacy anymore, since
> it might be the only one available to users.
> 
> Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
> ---
>  Documentation/leds/leds-lp5521.rst | 2 +-
>  Documentation/leds/leds-lp5523.rst | 2 +-
>  drivers/leds/Kconfig               | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]