[PATCH] docs: admin-guide: update tiny script for number of taint flags

[PATCH] docs: admin-guide: update tiny script for number of taint flags

[Randy Dunlap]

Account for 2 new taint flags being added by increasing the number of
bits handled by the tiny show-tainted-flags example script.

Fixes: 8eea4e744758 ("taint: Add TAINT_FWCTL")
Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: David Gow <davidgow@google.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
 Documentation/admin-guide/tainted-kernels.rst |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20251013.orig/Documentation/admin-guide/tainted-kernels.rst
+++ linux-next-20251013/Documentation/admin-guide/tainted-kernels.rst
@@ -74,7 +74,7 @@ a particular type of taint. It's best to
 script, but if you need something quick you can use this shell command to check
 which bits are set::
 
-	$ for i in $(seq 18); do echo $(($i-1)) $(($(cat /proc/sys/kernel/tainted)>>($i-1)&1));done
+	$ for i in $(seq 20); do echo $(($i-1)) $(($(cat /proc/sys/kernel/tainted)>>($i-1)&1));done
 
 Table for decoding tainted state
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags

[David Gow]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On Tue, 14 Oct 2025 at 11:15, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Account for 2 new taint flags being added by increasing the number of
> bits handled by the tiny show-tainted-flags example script.
>
> Fixes: 8eea4e744758 ("taint: Add TAINT_FWCTL")
> Fixes: 2852ca7fba9f ("panic: Taint kernel if tests are run")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: David Gow <davidgow@google.com>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---

Thanks for catching this!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5281 bytes --]

Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags

[Jason Gunthorpe]

On Mon, Oct 13, 2025 at 08:15:38PM -0700, Randy Dunlap wrote:
> Account for 2 new taint flags being added by increasing the number of
> bits handled by the tiny show-tainted-flags example script.

Maybe add a comment near the array about this :\

Jason

Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags

[Randy Dunlap]

On 10/14/25 5:14 AM, Jason Gunthorpe wrote:
> On Mon, Oct 13, 2025 at 08:15:38PM -0700, Randy Dunlap wrote:
>> Account for 2 new taint flags being added by increasing the number of
>> bits handled by the tiny show-tainted-flags example script.
> 
> Maybe add a comment near the array about this :\

Something like this?


--- linux-next-20251014.orig/kernel/panic.c
+++ linux-next-20251014/kernel/panic.c
@@ -638,6 +638,12 @@ EXPORT_SYMBOL(panic);
 /*
  * TAINT_FORCED_RMMOD could be a per-module flag but the module
  * is being removed anyway.
+ *
+ * NOTE: if you modify the taint_flags or TAINT_FLAGS_COUNT,
+ * please also modify tools/debugging/kernel-chktaint and
+ * Documentation/admin-guide/tainted-kernels.rst, including its
+ * small shell script that prints the TAINT_FLAGS_COUNT bits of
+ * /proc/sys/kernel/tainted.
  */
 const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = {
 	TAINT_FLAG(PROPRIETARY_MODULE,		'P', 'G', true),



-- 
~Randy

Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags

[Jason Gunthorpe]

On Tue, Oct 14, 2025 at 03:57:15PM -0700, Randy Dunlap wrote:
> 
> 
> On 10/14/25 5:14 AM, Jason Gunthorpe wrote:
> > On Mon, Oct 13, 2025 at 08:15:38PM -0700, Randy Dunlap wrote:
> >> Account for 2 new taint flags being added by increasing the number of
> >> bits handled by the tiny show-tainted-flags example script.
> > 
> > Maybe add a comment near the array about this :\
> 
> Something like this?
> 
> 
> --- linux-next-20251014.orig/kernel/panic.c
> +++ linux-next-20251014/kernel/panic.c
> @@ -638,6 +638,12 @@ EXPORT_SYMBOL(panic);
>  /*
>   * TAINT_FORCED_RMMOD could be a per-module flag but the module
>   * is being removed anyway.
> + *
> + * NOTE: if you modify the taint_flags or TAINT_FLAGS_COUNT,
> + * please also modify tools/debugging/kernel-chktaint and
> + * Documentation/admin-guide/tainted-kernels.rst, including its
> + * small shell script that prints the TAINT_FLAGS_COUNT bits of
> + * /proc/sys/kernel/tainted.
>   */
>  const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = {
>  	TAINT_FLAG(PROPRIETARY_MODULE,		'P', 'G', true),

Yeah, that looks great

Thanks,
Jason