From: Jason Gunthorpe <jgg@nvidia.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, David Gow <davidgow@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: admin-guide: update tiny script for number of taint flags
Date: Wed, 15 Oct 2025 13:43:09 -0300 [thread overview]
Message-ID: <20251015164309.GA3901471@nvidia.com> (raw)
In-Reply-To: <3b7f31b9-443a-465c-90ac-5b539852d799@infradead.org>
On Tue, Oct 14, 2025 at 03:57:15PM -0700, Randy Dunlap wrote:
>
>
> On 10/14/25 5:14 AM, Jason Gunthorpe wrote:
> > On Mon, Oct 13, 2025 at 08:15:38PM -0700, Randy Dunlap wrote:
> >> Account for 2 new taint flags being added by increasing the number of
> >> bits handled by the tiny show-tainted-flags example script.
> >
> > Maybe add a comment near the array about this :\
>
> Something like this?
>
>
> --- linux-next-20251014.orig/kernel/panic.c
> +++ linux-next-20251014/kernel/panic.c
> @@ -638,6 +638,12 @@ EXPORT_SYMBOL(panic);
> /*
> * TAINT_FORCED_RMMOD could be a per-module flag but the module
> * is being removed anyway.
> + *
> + * NOTE: if you modify the taint_flags or TAINT_FLAGS_COUNT,
> + * please also modify tools/debugging/kernel-chktaint and
> + * Documentation/admin-guide/tainted-kernels.rst, including its
> + * small shell script that prints the TAINT_FLAGS_COUNT bits of
> + * /proc/sys/kernel/tainted.
> */
> const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = {
> TAINT_FLAG(PROPRIETARY_MODULE, 'P', 'G', true),
Yeah, that looks great
Thanks,
Jason
prev parent reply other threads:[~2025-10-15 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 3:15 [PATCH] docs: admin-guide: update tiny script for number of taint flags Randy Dunlap
2025-10-14 8:05 ` David Gow
2025-10-14 12:14 ` Jason Gunthorpe
2025-10-14 22:57 ` Randy Dunlap
2025-10-15 16:43 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015164309.GA3901471@nvidia.com \
--to=jgg@nvidia.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).