From: Tomas Mudrunka <tomas.mudrunka@gmail.com>
To: corbet@lwn.net
Cc: bagasdotme@gmail.com, cengiz@kernel.wtf,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, mail@anselmschueler.com,
tomas.mudrunka@gmail.com
Subject: Re: [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters
Date: Thu, 16 Oct 2025 12:17:58 +0200 [thread overview]
Message-ID: <20251016101758.1441349-1-tomas.mudrunka@gmail.com> (raw)
In-Reply-To: <87wm4xbkim.fsf@trenco.lwn.net>
Hi. I am author of that sentence and this is NACK from me.
> I'm not sure this is right - there is a warning here that additional
> characters may acquire a meaning in the future, so one should not
> develop the habit of writing them now.
As you've said... I don't see anything confusing about that.
The warning was added for a reason, because there was discussion
about some people writing extra characters in there, which might
cause issues down the line if we refactor the code in future.
> After all these years, I think
> the chances of fundamental sysrq changes are pretty small,
Actualy it is not that long since the underscore mode was added...
> but I still don't see why we would take the warning out?
Exactly. Thank you.
next prev parent reply other threads:[~2025-10-16 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 11:24 [PATCH] Documentation: sysrq: Remove contradicting sentence on extra /proc/sysrq-trigger characters Bagas Sanjaya
2025-10-09 2:18 ` Randy Dunlap
2025-10-14 14:55 ` Jonathan Corbet
2025-10-14 17:57 ` Randy Dunlap
2025-10-15 0:11 ` Bagas Sanjaya
2025-10-15 6:18 ` Jiri Slaby
2025-10-15 9:39 ` Bagas Sanjaya
2025-10-16 10:17 ` Tomas Mudrunka [this message]
2025-10-16 10:47 ` Bagas Sanjaya
2025-10-16 18:51 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016101758.1441349-1-tomas.mudrunka@gmail.com \
--to=tomas.mudrunka@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=cengiz@kernel.wtf \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mail@anselmschueler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).